-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(package.json): Fix collision during commit. #5463
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Just a tiny comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! (nevermind my previous comment)
This change and other recent ones make me wonder if we can integrate prettier fully into eslint via eslint-plugin-prettier. I'll open an issue |
Doesn't prettier themselves discourage that practice? |
Oh, interesting! I'd love to learn more about that. I've successfully used this configuration for a while now. I think the conversation can be better resolved in #5466 however so as to not pollute this one. |
Description
Many times when I try to run commit, it fails because both
lint:fix
andprettier:fix
are trying to write to the same file at the same time. These should not be run concurrently, so made this change to run them sequentially.Related Issues
Check List
npx turbo lint
to ensure the code follows the style guide. And runnpx turbo lint:fix
to fix the style errors if necessary.npx turbo format
to ensure the code follows the style guide.npx turbo test
to check if all tests are passing, and/ornpx turbo test:snapshot
to update snapshots if I created and/or updated React Components.