Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(package.json): Fix collision during commit. #5463

Merged
merged 2 commits into from
Jul 2, 2023

Conversation

Harkunwar
Copy link
Contributor

Description

Many times when I try to run commit, it fails because both lint:fix and prettier:fix are trying to write to the same file at the same time. These should not be run concurrently, so made this change to run them sequentially.

Related Issues

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npx turbo lint to ensure the code follows the style guide. And run npx turbo lint:fix to fix the style errors if necessary.
  • I have run npx turbo format to ensure the code follows the style guide.
  • I have run npx turbo test to check if all tests are passing, and/or npx turbo test:snapshot to update snapshots if I created and/or updated React Components.
  • I've covered new added functionality with unit tests if necessary.

@Harkunwar Harkunwar requested a review from a team as a code owner July 2, 2023 12:23
@vercel
Copy link

vercel bot commented Jul 2, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 2, 2023 0:53am
nodejs-org-stories ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 2, 2023 0:53am

@vercel vercel bot temporarily deployed to Preview – nodejs-org July 2, 2023 12:24 Inactive
@vercel vercel bot temporarily deployed to Preview – nodejs-org-stories July 2, 2023 12:25 Inactive
@vercel vercel bot temporarily deployed to Preview – nodejs-org July 2, 2023 12:52 Inactive
@vercel vercel bot temporarily deployed to Preview – nodejs-org-stories July 2, 2023 12:53 Inactive
Copy link
Member

@ovflowd ovflowd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just a tiny comment

Copy link
Member

@ovflowd ovflowd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! (nevermind my previous comment)

@ovflowd ovflowd merged commit ddb88b8 into nodejs:main Jul 2, 2023
@bmuenzenmeyer
Copy link
Collaborator

This change and other recent ones make me wonder if we can integrate prettier fully into eslint via eslint-plugin-prettier. I'll open an issue

@ovflowd
Copy link
Member

ovflowd commented Jul 2, 2023

This change and other recent ones make me wonder if we can integrate prettier fully into eslint via eslint-plugin-prettier. I'll open an issue

Doesn't prettier themselves discourage that practice?

@bmuenzenmeyer
Copy link
Collaborator

Doesn't prettier themselves discourage that practice?

Oh, interesting! I'd love to learn more about that. I've successfully used this configuration for a while now. I think the conversation can be better resolved in #5466 however so as to not pollute this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants