Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate of BlogCard, NodeFeature, and Hero from nodejs.dev #5308

Closed
2 of 3 tasks
ovflowd opened this issue Apr 20, 2023 · 9 comments
Closed
2 of 3 tasks

Migrate of BlogCard, NodeFeature, and Hero from nodejs.dev #5308

ovflowd opened this issue Apr 20, 2023 · 9 comments
Labels
feature-request Requesting a new Technological Feature to be added to the Website website redesign Issue/PR part of the Node.js Website Redesign

Comments

@ovflowd
Copy link
Member

ovflowd commented Apr 20, 2023

Continuing the migration of components from nodejs.dev that we started here, we want to migrate a few other small Components that are used in a few pages but that don't really belong anywhere right now.

This issue will keep track of these components and their development progress.

The Migration of each Component

  • Each Component has its sub-folder (e.g., components/Banner)
  • The folder structure should pretty much be the same (CSS components, React, and sub-components), but feel free to make changes if you see deemed
  • Please add some if the Component still needs to get unit tests. At least to ensure the Component is rendering. If the Component has states/CTAs (Buttons/Triggers), please cover them too.
  • The Storybook of each component should allow interaction with all possible states of the Component
  • If the Component depends on Hooks, please migrate them too, with the following caveat:
    • If that component only uses the Hook, move it to the same folder of the Component
    • Otherwise, migrate it to the hooks folder of the repository.
  • If the Component has a Gatsby-specific logic (e.g. Dark Theme Switcher), if it is straightforward enough (e.g. a dark theme switcher plugin for Next.js or it is simple enough to code by ourselves, e.g. a Hook that we manage together with a React Provider) then feel free to do it.
    • Otherwise, if you have questions, please ask them on this Issue or your Draft PR for the Component.

List of Components to Migrate

@ovflowd ovflowd added website redesign Issue/PR part of the Node.js Website Redesign feature-request Requesting a new Technological Feature to be added to the Website labels Apr 20, 2023
@ovflowd ovflowd moved this to 🔖 Ready in Website Redesign Apr 20, 2023
@ovflowd ovflowd changed the title Migrate of BlogCard, NodeFeature and other minor Components from nodejs.dev Migrate of BlogCard, NodeFeature and Hero from nodejs.dev Apr 20, 2023
@ovflowd ovflowd changed the title Migrate of BlogCard, NodeFeature and Hero from nodejs.dev Migrate of BlogCard, NodeFeature, and Hero from nodejs.dev Apr 20, 2023
@Harkunwar
Copy link
Contributor

I'll start work on migrating the BlogCard component.

@shanpriyan shanpriyan moved this from 🔖 Ready to 🏗 In progress in Website Redesign Apr 24, 2023
@ktssr
Copy link
Contributor

ktssr commented Apr 27, 2023

Will pick Hero component

@AugustinMauroy
Copy link
Member

Hey folks !
Can I take node feat ?

@ovflowd
Copy link
Member Author

ovflowd commented Apr 27, 2023

Sure thing. But there are still open topics on the ShellBox one... But feel free to tackle Node Feat :)

@AugustinMauroy
Copy link
Member

@ovflowd I have corrected with the feedback. Unless there is an error in understanding 😄

@AugustinMauroy
Copy link
Member

Should I put my component in home/NodeFeat.tsx or in home/nodefeat/index.tsx ?

@ovflowd
Copy link
Member Author

ovflowd commented Apr 28, 2023

components/Home/NodeFeature/index.tsx

@ovflowd
Copy link
Member Author

ovflowd commented Jul 27, 2023

⚠️ Important Update

Due to this update, we're halting all Component development for now until further notice, as the design will significantly diverge, and we do not want to spend time writing Components we don't even know if a counterpart should exist.

Please follow this discussion as we're going to update as soon as we have final designs and a plan for what should be done. Designs and further information will be shared soon.

@ovflowd ovflowd moved this from 🏗 In progress to 📋 Backlog in Website Redesign Jul 27, 2023
@ovflowd
Copy link
Member Author

ovflowd commented Aug 27, 2023

We're closing this issue for the time-being as we're going either to update these issues if needed or create new ones for the development of the new design.

@ovflowd ovflowd closed this as not planned Won't fix, can't repro, duplicate, stale Aug 27, 2023
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Website Redesign Aug 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Requesting a new Technological Feature to be added to the Website website redesign Issue/PR part of the Node.js Website Redesign
Projects
Archived in project
Development

No branches or pull requests

4 participants