From ce1f407d3b6be95c07edd994a544d1870c3960ba Mon Sep 17 00:00:00 2001 From: Nathan Baulch Date: Sun, 22 Sep 2024 15:03:43 +1000 Subject: [PATCH 1/8] tools: fix typos --- tools/actions/commit-queue.sh | 2 +- tools/cpplint.py | 10 +++---- tools/dep_updaters/utils.sh | 4 +-- tools/gen_node_def.cc | 2 +- tools/github_reporter/index.js | 26 ++++++++--------- tools/gyp/docs/Hacking.md | 2 +- tools/gyp/docs/LanguageSpecification.md | 6 ++-- tools/gyp/docs/UserDocumentation.md | 4 +-- tools/gyp/pylib/gyp/generator/cmake.py | 6 ++-- tools/gyp/pylib/gyp/generator/msvs.py | 2 +- tools/gyp/pylib/gyp/xcode_emulation.py | 2 +- tools/gyp/pylib/gyp/xcodeproj_file.py | 4 +-- tools/gyp/pylib/packaging/metadata.py | 2 +- tools/gyp/tools/pretty_vcproj.py | 4 +-- tools/gypi_to_gn.py | 4 +-- tools/icu/icutrim.py | 6 ++-- .../75/source/tools/genccode/genccode.c | 2 +- .../75/source/tools/genccode/pkg_genc.h | 2 +- .../75/source/tools/toolutil/pkg_genc.h | 2 +- tools/inspector_protocol/code_generator.py | 2 +- tools/inspector_protocol/encoding/encoding.cc | 2 +- tools/inspector_protocol/encoding/encoding.h | 4 +-- tools/inspector_protocol/jinja2/bccache.py | 2 +- tools/inspector_protocol/jinja2/compiler.py | 8 +++--- tools/inspector_protocol/jinja2/debug.py | 2 +- .../inspector_protocol/jinja2/environment.py | 8 +++--- tools/inspector_protocol/jinja2/ext.py | 2 +- tools/inspector_protocol/jinja2/filters.py | 2 +- tools/inspector_protocol/jinja2/nodes.py | 6 ++-- tools/inspector_protocol/jinja2/runtime.py | 2 +- tools/inspector_protocol/jinja2/sandbox.py | 6 ++-- tools/inspector_protocol/jinja2/utils.py | 2 +- .../lib/encoding_cpp.template | 2 +- .../lib/encoding_h.template | 4 +-- tools/lint-md/lint-md.mjs | 28 +++++++++---------- tools/msvs/vswhere_usability_wrapper.cmd | 2 +- tools/pseudo-tty.py | 2 +- tools/v8_gypfiles/features.gypi | 2 +- tools/v8_gypfiles/inspector.gypi | 2 +- tools/v8_gypfiles/v8.gyp | 2 +- 40 files changed, 92 insertions(+), 92 deletions(-) diff --git a/tools/actions/commit-queue.sh b/tools/actions/commit-queue.sh index 7778e07fe4bd03..3b3138053cb636 100755 --- a/tools/actions/commit-queue.sh +++ b/tools/actions/commit-queue.sh @@ -57,7 +57,7 @@ for pr in "$@"; do fi git node land --autorebase --yes $MULTIPLE_COMMIT_POLICY "$pr" >output 2>&1 || echo "Failed to land #${pr}" - # cat here otherwise we'll be supressing the output of git node land + # cat here otherwise we'll be suppressing the output of git node land cat output # TODO(mmarchini): workaround for ncu not returning the expected status code, diff --git a/tools/cpplint.py b/tools/cpplint.py index 5d6172d5a4e8b1..025f6dc16de362 100755 --- a/tools/cpplint.py +++ b/tools/cpplint.py @@ -913,7 +913,7 @@ # Files to exclude from linting. This is set by the --exclude flag. _excludes = None -# Whether to supress all PrintInfo messages, UNRELATED to --quiet flag +# Whether to suppress all PrintInfo messages, UNRELATED to --quiet flag _quiet = False # The allowed line length of files. @@ -1040,7 +1040,7 @@ def ParseNolintSuppressions(filename, raw_line, linenum, error): 'Unknown NOLINT error category: %s' % category) -def ProcessGlobalSuppresions(lines): +def ProcessGlobalSuppressions(lines): """Updates the list of global error suppressions. Parses any lint directives in the file that have global effect. @@ -1068,7 +1068,7 @@ def IsErrorSuppressedByNolint(category, linenum): """Returns true if the specified error category is suppressed on this line. Consults the global error_suppressions map populated by - ParseNolintSuppressions/ProcessGlobalSuppresions/ResetNolintSuppressions. + ParseNolintSuppressions/ProcessGlobalSuppressions/ResetNolintSuppressions. Args: category: str, the category of the error. @@ -1311,7 +1311,7 @@ def __init__(self): self._filters_backup = self.filters[:] self.counting = 'total' # In what way are we counting errors? self.errors_by_category = {} # string to int dict storing error counts - self.quiet = False # Suppress non-error messagess? + self.quiet = False # Suppress non-error messages? # output format: # "emacs" - format that emacs can parse (default) @@ -6617,7 +6617,7 @@ def ProcessFileData(filename, file_extension, lines, error, ResetNolintSuppressions() CheckForCopyright(filename, lines, error) - ProcessGlobalSuppresions(lines) + ProcessGlobalSuppressions(lines) RemoveMultiLineComments(filename, lines, error) clean_lines = CleansedLines(lines) diff --git a/tools/dep_updaters/utils.sh b/tools/dep_updaters/utils.sh index 774da85aafc303..76a40d4bbc4970 100644 --- a/tools/dep_updaters/utils.sh +++ b/tools/dep_updaters/utils.sh @@ -3,7 +3,7 @@ ROOT=$(cd "$(dirname "$0")/../.." && pwd) export ROOT -# This function compare new version with current version of a depdendency and +# This function compare new version with current version of a dependency and # exit the script if the versions are the same # # $1 is the package name e.g. 'acorn', 'ada', 'base64' etc. See the file @@ -55,7 +55,7 @@ finalize_version_update() { # https://github.com/nodejs/node/blob/main/doc/contributing/maintaining/maintaining-dependencies.md # for a complete list of package name # $2 is the downloaded archive -# $3 (optional) is the deposited sha256 cheksum. When provided, it is checked +# $3 (optional) is the deposited sha256 checksum. When provided, it is checked # against the checksum generated from the archive log_and_verify_sha256sum() { package_name="$1" diff --git a/tools/gen_node_def.cc b/tools/gen_node_def.cc index f4cabbd84c1f75..6b3e2d84c53c0a 100644 --- a/tools/gen_node_def.cc +++ b/tools/gen_node_def.cc @@ -11,7 +11,7 @@ // symbols from the DLL and redirects them back to the DLL. // This allows node.exe to export the same symbols as libnode.dll // when building Node.js as a shared library. This is conceptually -// similary to the create_expfile.sh script used on AIX. +// similarly to the create_expfile.sh script used on AIX. // // Generating this .def file requires parsing data out of the // PE32/PE32+ file format. Helper structs are defined in diff --git a/tools/github_reporter/index.js b/tools/github_reporter/index.js index 9abd7e231e1421..766dd523a1eac7 100644 --- a/tools/github_reporter/index.js +++ b/tools/github_reporter/index.js @@ -7410,7 +7410,7 @@ var require_client = __commonJS({ throw new InvalidArgumentError("allowH2 must be a valid boolean value"); } if (maxConcurrentStreams != null && (typeof maxConcurrentStreams !== "number" || maxConcurrentStreams < 1)) { - throw new InvalidArgumentError("maxConcurrentStreams must be a possitive integer, greater than 0"); + throw new InvalidArgumentError("maxConcurrentStreams must be a positive integer, greater than 0"); } if (typeof connect2 !== "function") { connect2 = buildConnector({ @@ -7451,7 +7451,7 @@ var require_client = __commonJS({ this[kHTTP2SessionState] = !allowH2 ? null : { // streams: null, // Fixed queue of streams - For future support of `push` openStreams: 0, - // Keep track of them to decide wether or not unref the session + // Keep track of them to decide whether or not unref the session maxConcurrentStreams: maxConcurrentStreams != null ? maxConcurrentStreams : 100 // Max peerConcurrentStreams for a Node h2 server }; @@ -9459,7 +9459,7 @@ var require_agent = __commonJS({ this[kFactory] = factory; this[kClients] = /* @__PURE__ */ new Map(); this[kFinalizer] = new FinalizationRegistry( - /* istanbul ignore next: gc is undeterministic */ + /* istanbul ignore next: gc is indeterministic */ (key) => { const ref = this[kClients].get(key); if (ref !== void 0 && ref.deref() === void 0) { @@ -13060,7 +13060,7 @@ var require_request2 = __commonJS({ return this[kState].reloadNavigation; } // Returns a boolean indicating whether or not request is for a history - // navigation (a.k.a. back-foward navigation). + // navigation (a.k.a. back-forward navigation). get isHistoryNavigation() { webidl.brandCheck(this, Request); return this[kState].historyNavigation; @@ -13527,9 +13527,9 @@ var require_fetch = __commonJS({ taskDestination = request.client.globalObject; crossOriginIsolatedCapability = request.client.crossOriginIsolatedCapability; } - const currenTime = coarsenedSharedCurrentTime(crossOriginIsolatedCapability); + const currentTime = coarsenedSharedCurrentTime(crossOriginIsolatedCapability); const timingInfo = createOpaqueTimingInfo({ - startTime: currenTime + startTime: currentTime }); const fetchParams = { controller: new Fetch(dispatcher), @@ -18582,7 +18582,7 @@ var require_summary = __commonJS({ /** * If the summary buffer is empty * - * @returns {boolen} true if the buffer is empty + * @returns {boolean} true if the buffer is empty */ isEmptyBuffer() { return this._buffer.length === 0; @@ -18667,10 +18667,10 @@ var require_summary = __commonJS({ return this.addRaw(element).addEOL(); } /** - * Adds a collapsable HTML details element to the summary buffer + * Adds a collapsible HTML details element to the summary buffer * * @param {string} label text for the closed state - * @param {string} content collapsable content + * @param {string} content collapsible content * * @returns {Summary} summary instance */ @@ -19390,7 +19390,7 @@ module.exports = async function githubReporter(source) { break; } } - const formatedDiagnostics = diagnostics.map((d) => { + const formattedDiagnostics = diagnostics.map((d) => { const [key, ...rest] = d.split(" "); const value = rest.join(" "); return [ @@ -19398,11 +19398,11 @@ module.exports = async function githubReporter(source) { DIAGNOSTIC_VALUES[key] ? DIAGNOSTIC_VALUES[key](value) : value ]; }); - core.startGroup(`Test results (${formatedDiagnostics.find(([key]) => key === DIAGNOSTIC_KEYS.pass)?.[1] ?? counter.pass} passed, ${formatedDiagnostics.find(([key]) => key === DIAGNOSTIC_KEYS.fail)?.[1] ?? counter.fail} failed)`); - core.notice(formatedDiagnostics.map((d) => d.join(": ")).join(EOL)); + core.startGroup(`Test results (${formattedDiagnostics.find(([key]) => key === DIAGNOSTIC_KEYS.pass)?.[1] ?? counter.pass} passed, ${formattedDiagnostics.find(([key]) => key === DIAGNOSTIC_KEYS.fail)?.[1] ?? counter.fail} failed)`); + core.notice(formattedDiagnostics.map((d) => d.join(": ")).join(EOL)); core.endGroup(); if (process.env.GITHUB_STEP_SUMMARY) { - await core.summary.addHeading("Test Results").addTable(formatedDiagnostics).write(); + await core.summary.addHeading("Test Results").addTable(formattedDiagnostics).write(); } }; /*! Bundled license information: diff --git a/tools/gyp/docs/Hacking.md b/tools/gyp/docs/Hacking.md index 89b3b8bea923ec..b00783bd36f2bb 100644 --- a/tools/gyp/docs/Hacking.md +++ b/tools/gyp/docs/Hacking.md @@ -34,7 +34,7 @@ See [Testing](Testing.md) for more details on the test framework. Note that it can be handy to look at the project files output by the tests to diagnose problems. The easiest way to do that is by kindly asking the test driver to leave the temporary directories it creates in-place. -This is done by setting the enviroment variable "PRESERVE", e.g. +This is done by setting the environment variable "PRESERVE", e.g. ``` set PRESERVE=all # On Windows diff --git a/tools/gyp/docs/LanguageSpecification.md b/tools/gyp/docs/LanguageSpecification.md index 178b8c83169919..f8fff097ab73f3 100644 --- a/tools/gyp/docs/LanguageSpecification.md +++ b/tools/gyp/docs/LanguageSpecification.md @@ -157,7 +157,7 @@ have structural meaning for target definitions: | `all_dependent_settings` | A dictionary of settings to be applied to all dependents of the target, transitively. This includes direct dependents and the entire set of their dependents, and so on. This section may contain anything found within a `target` dictionary, except `configurations`, `target_name`, and `type` sections. Compare `direct_dependent_settings` and `link_settings`. | | `configurations` | A list of dictionaries defining build configurations for the target. See the "Configurations" section below. | | `copies` | A list of copy actions to perform. See the "Copies" section below. | -| `defines` | A list of preprocesor definitions to be passed on the command line to the C/C++ compiler (via `-D` or `/D` options). | +| `defines` | A list of preprocessor definitions to be passed on the command line to the C/C++ compiler (via `-D` or `/D` options). | | `dependencies` | A list of targets on which this target depends. Targets in other `.gyp` files are specified as `../path/to/other.gyp:target_we_want`. | | `direct_dependent_settings` | A dictionary of settings to be applied to other targets that depend on this target. These settings will only be applied to direct dependents. This section may contain anything found within a `target` dictionary, except `configurations`, `target_name`, and `type` sections. Compare with `all_dependent_settings` and `link_settings`. | | `include_dirs` | A list of include directories to be passed on the command line to the C/C++ compiler (via `-I` or `/I` options). | @@ -208,8 +208,8 @@ Configuration dictionaries may also contain these elements: Conditionals may appear within any dictionary in a `.gyp` file. There are two tpes of conditionals, which differ only in the timing of their -processing. `conditons` sections are processed shortly after loading -`.gyp` files, and `target_conditons` sections are processed after all +processing. `conditions` sections are processed shortly after loading +`.gyp` files, and `target_conditions` sections are processed after all dependencies have been computed. A conditional section is introduced with a `conditions` or diff --git a/tools/gyp/docs/UserDocumentation.md b/tools/gyp/docs/UserDocumentation.md index 808f37a1a9361c..35bea38718c674 100644 --- a/tools/gyp/docs/UserDocumentation.md +++ b/tools/gyp/docs/UserDocumentation.md @@ -807,7 +807,7 @@ directory: ``` Adding a library often involves updating multiple `.gyp` files, adding -the target to the approprate `.gyp` file (possibly a newly-added `.gyp` +the target to the appropriate `.gyp` file (possibly a newly-added `.gyp` file), and updating targets in the other `.gyp` files that depend on (link with) the new library. @@ -858,7 +858,7 @@ because of those settings' being listed in the `direct_dependent_settings` block. Note that these settings will likely need to be replicated in the -settings for the library target itsef, so that the library will build +settings for the library target itself, so that the library will build with the same options. This does not prevent the target from defining additional options for its "internal" use when compiling its own source files. (In the above example, these are the `LOCAL_DEFINE_FOR_LIBBAR` diff --git a/tools/gyp/pylib/gyp/generator/cmake.py b/tools/gyp/pylib/gyp/generator/cmake.py index 320a891aa8adc9..1453cbc8f2d82c 100644 --- a/tools/gyp/pylib/gyp/generator/cmake.py +++ b/tools/gyp/pylib/gyp/generator/cmake.py @@ -251,7 +251,7 @@ def WriteActions(target_name, actions, extra_sources, extra_deps, path_to_gyp, o target_name: the name of the CMake target being generated. actions: the Gyp 'actions' dict for this target. extra_sources: [(, )] to append with generated source files. - extra_deps: [] to append with generated targets. + extra_deps: [] to append with generated targets. path_to_gyp: relative path from CMakeLists.txt being generated to the Gyp file in which the target being generated is defined. """ @@ -340,7 +340,7 @@ def WriteRules(target_name, rules, extra_sources, extra_deps, path_to_gyp, outpu target_name: the name of the CMake target being generated. actions: the Gyp 'actions' dict for this target. extra_sources: [(, )] to append with generated source files. - extra_deps: [] to append with generated targets. + extra_deps: [] to append with generated targets. path_to_gyp: relative path from CMakeLists.txt being generated to the Gyp file in which the target being generated is defined. """ @@ -457,7 +457,7 @@ def WriteCopies(target_name, copies, extra_deps, path_to_gyp, output): Args: target_name: the name of the CMake target being generated. actions: the Gyp 'actions' dict for this target. - extra_deps: [] to append with generated targets. + extra_deps: [] to append with generated targets. path_to_gyp: relative path from CMakeLists.txt being generated to the Gyp file in which the target being generated is defined. """ diff --git a/tools/gyp/pylib/gyp/generator/msvs.py b/tools/gyp/pylib/gyp/generator/msvs.py index 6b5b24acc00019..891e92e9824e43 100644 --- a/tools/gyp/pylib/gyp/generator/msvs.py +++ b/tools/gyp/pylib/gyp/generator/msvs.py @@ -3274,7 +3274,7 @@ def _GetMSBuildPropertyGroup(spec, label, properties): num_configurations = len(spec["configurations"]) def GetEdges(node): - # Use a definition of edges such that user_of_variable -> used_varible. + # Use a definition of edges such that user_of_variable -> used_variable. # This happens to be easier in this case, since a variable's # definition contains all variables it references in a single string. edges = set() diff --git a/tools/gyp/pylib/gyp/xcode_emulation.py b/tools/gyp/pylib/gyp/xcode_emulation.py index 5f2c097f63e1f4..72151765da9acc 100644 --- a/tools/gyp/pylib/gyp/xcode_emulation.py +++ b/tools/gyp/pylib/gyp/xcode_emulation.py @@ -1858,7 +1858,7 @@ def _TopologicallySortedEnvVarKeys(env): regex = re.compile(r"\$\{([a-zA-Z0-9\-_]+)\}") def GetEdges(node): - # Use a definition of edges such that user_of_variable -> used_varible. + # Use a definition of edges such that user_of_variable -> used_variable. # This happens to be easier in this case, since a variable's # definition contains all variables it references in a single string. # We can then reverse the result of the topological sort at the end. diff --git a/tools/gyp/pylib/gyp/xcodeproj_file.py b/tools/gyp/pylib/gyp/xcodeproj_file.py index 33c667c266bf69..5b9d0026c178e4 100644 --- a/tools/gyp/pylib/gyp/xcodeproj_file.py +++ b/tools/gyp/pylib/gyp/xcodeproj_file.py @@ -74,7 +74,7 @@ PBXBuildFile appears extraneous, but there's actually one reason for this: file-specific compiler flags are added to the PBXBuildFile object so as to allow a single file to be a member of multiple targets while having distinct -compiler flags for each. These flags can be modified in the Xcode applciation +compiler flags for each. These flags can be modified in the Xcode application in the "Build" tab of a File Info window. When a project is open in the Xcode application, Xcode will rewrite it. As @@ -662,7 +662,7 @@ def _XCKVPrint(self, file, tabs, key, value): tabs is an int identifying the indentation level. If the class' _should_print_single_line variable is True, tabs is ignored and the - key-value pair will be followed by a space insead of a newline. + key-value pair will be followed by a space instead of a newline. """ if self._should_print_single_line: diff --git a/tools/gyp/pylib/packaging/metadata.py b/tools/gyp/pylib/packaging/metadata.py index fb274930799da0..7f067dda7a8b2b 100644 --- a/tools/gyp/pylib/packaging/metadata.py +++ b/tools/gyp/pylib/packaging/metadata.py @@ -206,7 +206,7 @@ def _parse_project_urls(data: List[str]) -> Dict[str, str]: # be the missing value, then they'd have multiple '' values that # overwrite each other in a accumulating dict. # - # The other potentional issue is that it's possible to have the + # The other potential issue is that it's possible to have the # same label multiple times in the metadata, with no solid "right" # answer with what to do in that case. As such, we'll do the only # thing we can, which is treat the field as unparseable and add it diff --git a/tools/gyp/tools/pretty_vcproj.py b/tools/gyp/tools/pretty_vcproj.py index 72c65d7fc495f9..d4b58fd87f9e32 100755 --- a/tools/gyp/tools/pretty_vcproj.py +++ b/tools/gyp/tools/pretty_vcproj.py @@ -207,7 +207,7 @@ def CleanupVcproj(node): node.appendChild(new_node) -def GetConfiguationNodes(vcproj): +def GetConfigurationNodes(vcproj): # TODO(nsylvain): Find a better way to navigate the xml. nodes = [] for node in vcproj.childNodes: @@ -307,7 +307,7 @@ def main(argv): # First thing we need to do is find the Configuration Node and merge them # with the vsprops they include. - for configuration_node in GetConfiguationNodes(dom.documentElement): + for configuration_node in GetConfigurationNodes(dom.documentElement): # Get the property sheets associated with this configuration. vsprops = configuration_node.getAttribute("InheritedPropertySheets") diff --git a/tools/gypi_to_gn.py b/tools/gypi_to_gn.py index 08eb948f5b2a65..327cd38d7ba63a 100755 --- a/tools/gypi_to_gn.py +++ b/tools/gypi_to_gn.py @@ -37,7 +37,7 @@ in GYP down requires a level of indirection. Any calls will have to be removed and cleaned up once the GYP-to-GN transition is complete. As a result, we only use this script when the list of files is large and -frequently-changing. In these cases, having one canonical list outweights the +frequently-changing. In these cases, having one canonical list outweighs the downsides. As of this writing, the GN build is basically complete. It's likely that all large and frequently changing targets where this is appropriate use this @@ -253,7 +253,7 @@ def LoadPythonDictionary(path): def ReplaceSubstrings(values, search_for, replace_with): """Recursively replaces substrings in a value. - Replaces all substrings of the "search_for" with "repace_with" for all + Replaces all substrings of the "search_for" with "replace_with" for all strings occurring in "values". This is done by recursively iterating into lists as well as the keys and values of dictionaries.""" if isinstance(values, str): diff --git a/tools/icu/icutrim.py b/tools/icu/icutrim.py index 0ae8c23319db93..b66dea148f65d7 100755 --- a/tools/icu/icutrim.py +++ b/tools/icu/icutrim.py @@ -214,7 +214,7 @@ def queueForRemoval(tree): mytree = trees[tree] if options.verbose > 0: print("* %s: %d items" % (tree, len(mytree["locs"]))) - # do varible substitution for this tree here + # do variable substitution for this tree here if isinstance(config["trees"][tree], basestring): treeStr = config["trees"][tree] if options.verbose > 5: @@ -280,7 +280,7 @@ def addTreeByType(tree, mytree): else: tree = treeprefix[0:-1] if(options.verbose>6): - print("procesing %s" % (tree)) + print("processing %s" % (tree)) trees[tree] = { "extension": ".res", "treeprefix": treeprefix, "hasIndex": True } # read in the resource list for the tree treelistfile = os.path.join(options.tmpdir,"%s.lst" % tree) @@ -331,7 +331,7 @@ def removeList(count=0): if(options.verbose > 5): print(" now %d items to remove" % len(remove)) if(oldcount == len(remove)): - print(" ERROR: could not add any mor eitems to remove. Fail.") + print(" ERROR: could not add any more items to remove. Fail.") sys.exit(1) removeList(count+1) diff --git a/tools/icu/patches/75/source/tools/genccode/genccode.c b/tools/icu/patches/75/source/tools/genccode/genccode.c index 0f243952a7d452..a5eed472e93233 100644 --- a/tools/icu/patches/75/source/tools/genccode/genccode.c +++ b/tools/icu/patches/75/source/tools/genccode/genccode.c @@ -134,7 +134,7 @@ main(int argc, char* argv[]) { "\t-m or --match-arch file.o match the architecture (CPU, 32/64 bits) of the specified .o\n" "\t ELF format defaults to i386. Windows defaults to the native platform.\n" "\t-c or --cpu-arch Specify a CPU architecture for which to write a .obj file for ClangCL on Windows\n" - "\t Valid values for this opton are x64, x86 and arm64.\n" + "\t Valid values for this option are x64, x86 and arm64.\n" "\t--skip-dll-export Don't export the ICU data entry point symbol (for use when statically linking)\n"); #endif fprintf(stderr, diff --git a/tools/icu/patches/75/source/tools/genccode/pkg_genc.h b/tools/icu/patches/75/source/tools/genccode/pkg_genc.h index 76474ec7df6fd8..5ee762c1f266e0 100644 --- a/tools/icu/patches/75/source/tools/genccode/pkg_genc.h +++ b/tools/icu/patches/75/source/tools/genccode/pkg_genc.h @@ -52,7 +52,7 @@ #define USE_SINGLE_CCODE_FILE #endif -/* Need to fix the file seperator character when using MinGW. */ +/* Need to fix the file separator character when using MinGW. */ #if defined(WINDOWS_WITH_GNUC) || defined(USING_CYGWIN) #define PKGDATA_FILE_SEP_STRING "/" #else diff --git a/tools/icu/patches/75/source/tools/toolutil/pkg_genc.h b/tools/icu/patches/75/source/tools/toolutil/pkg_genc.h index 76474ec7df6fd8..5ee762c1f266e0 100644 --- a/tools/icu/patches/75/source/tools/toolutil/pkg_genc.h +++ b/tools/icu/patches/75/source/tools/toolutil/pkg_genc.h @@ -52,7 +52,7 @@ #define USE_SINGLE_CCODE_FILE #endif -/* Need to fix the file seperator character when using MinGW. */ +/* Need to fix the file separator character when using MinGW. */ #if defined(WINDOWS_WITH_GNUC) || defined(USING_CYGWIN) #define PKGDATA_FILE_SEP_STRING "/" #else diff --git a/tools/inspector_protocol/code_generator.py b/tools/inspector_protocol/code_generator.py index a6e163c6fe911f..77b2aa00bcdf79 100755 --- a/tools/inspector_protocol/code_generator.py +++ b/tools/inspector_protocol/code_generator.py @@ -681,7 +681,7 @@ def generate_lib_file(file_name, template_files): generate_lib_file(os.path.join(config.lib.output, to_file_name(config, "base_string_adapter.h")), base_string_adapter_h_templates) generate_lib_file(os.path.join(config.lib.output, to_file_name(config, "base_string_adapter.cc")), base_string_adapter_cc_templates) - # Make gyp / make generatos happy, otherwise make rebuilds world. + # Make gyp / make generators happy, otherwise make rebuilds world. inputs_ts = max(map(os.path.getmtime, inputs)) up_to_date = True for output_file in outputs.keys(): diff --git a/tools/inspector_protocol/encoding/encoding.cc b/tools/inspector_protocol/encoding/encoding.cc index f7e933e41afac5..ee0c0562f46e76 100644 --- a/tools/inspector_protocol/encoding/encoding.cc +++ b/tools/inspector_protocol/encoding/encoding.cc @@ -1747,7 +1747,7 @@ class JsonParser { } static bool IsSpaceOrNewLine(Char c) { - // \v = vertial tab; \f = form feed page break. + // \v = vertical tab; \f = form feed page break. return c == ' ' || c == '\n' || c == '\v' || c == '\f' || c == '\r' || c == '\t'; } diff --git a/tools/inspector_protocol/encoding/encoding.h b/tools/inspector_protocol/encoding/encoding.h index a1bcfc4be3db4a..e8ebe4e3378aed 100644 --- a/tools/inspector_protocol/encoding/encoding.h +++ b/tools/inspector_protocol/encoding/encoding.h @@ -181,9 +181,9 @@ class StreamingParserHandler { virtual void HandleNull() = 0; // The parser may send one error even after other events have already - // been received. Client code is reponsible to then discard the + // been received. Client code is responsible to then discard the // already processed events. - // |error| must be an eror, as in, |error.is_ok()| can't be true. + // |error| must be an error, as in, |error.is_ok()| can't be true. virtual void HandleError(Status error) = 0; }; diff --git a/tools/inspector_protocol/jinja2/bccache.py b/tools/inspector_protocol/jinja2/bccache.py index 080e527cabf33b..ec980ae268bb42 100644 --- a/tools/inspector_protocol/jinja2/bccache.py +++ b/tools/inspector_protocol/jinja2/bccache.py @@ -5,7 +5,7 @@ This module implements the bytecode cache system Jinja is optionally using. This is useful if you have very complex template situations and - the compiliation of all those templates slow down your application too + the compilation of all those templates slow down your application too much. Situations where this is useful are often forking web applications that diff --git a/tools/inspector_protocol/jinja2/compiler.py b/tools/inspector_protocol/jinja2/compiler.py index d534a827391aeb..28686a6a8bb004 100644 --- a/tools/inspector_protocol/jinja2/compiler.py +++ b/tools/inspector_protocol/jinja2/compiler.py @@ -410,7 +410,7 @@ def signature(self, node, frame, extra_kwargs=None): """Writes a function call to the stream for the current node. A leading comma is added automatically. The extra keyword arguments may not include python keywords otherwise a syntax - error could occour. The extra keyword arguments should be given + error could occur. The extra keyword arguments should be given as python dict. """ # if any of the given keyword arguments is a python keyword @@ -1044,13 +1044,13 @@ def visit_For(self, node, frame): if node.test: loop_filter_func = self.temporary_identifier() test_frame.symbols.analyze_node(node, for_branch='test') - self.writeline('%s(fiter):' % self.func(loop_filter_func), node.test) + self.writeline('%s(filter):' % self.func(loop_filter_func), node.test) self.indent() self.enter_frame(test_frame) self.writeline(self.environment.is_async and 'async for ' or 'for ') self.visit(node.target, loop_frame) self.write(' in ') - self.write(self.environment.is_async and 'auto_aiter(fiter)' or 'fiter') + self.write(self.environment.is_async and 'auto_aiter(filter)' or 'filter') self.write(':') self.indent() self.writeline('if ', node.test) @@ -1256,7 +1256,7 @@ def visit_Output(self, node, frame): except nodes.Impossible: body.append(child) continue - # the frame can't be volatile here, becaus otherwise the + # the frame can't be volatile here, because otherwise the # as_const() function would raise an Impossible exception # at that point. try: diff --git a/tools/inspector_protocol/jinja2/debug.py b/tools/inspector_protocol/jinja2/debug.py index b61139f0cde17f..c3df3cace652d1 100644 --- a/tools/inspector_protocol/jinja2/debug.py +++ b/tools/inspector_protocol/jinja2/debug.py @@ -239,7 +239,7 @@ def fake_exc_info(exc_info, filename, lineno): else: locals = {} - # assamble fake globals we need + # assemble fake globals we need globals = { '__name__': filename, '__file__': filename, diff --git a/tools/inspector_protocol/jinja2/environment.py b/tools/inspector_protocol/jinja2/environment.py index 549d9afab456b4..67271a7a440819 100644 --- a/tools/inspector_protocol/jinja2/environment.py +++ b/tools/inspector_protocol/jinja2/environment.py @@ -240,7 +240,7 @@ class Environment(object): sandboxed = False #: True if the environment is just an overlay - overlayed = False + overlaid = False #: the environment this environment is linked to if it is an overlay linked_to = None @@ -364,7 +364,7 @@ def overlay(self, block_start_string=missing, block_end_string=missing, bytecode_cache=missing): """Create a new overlay environment that shares all the data with the current environment except for cache and the overridden attributes. - Extensions cannot be removed for an overlayed environment. An overlayed + Extensions cannot be removed for an overlaid environment. An overlaid environment automatically gets all the extensions of the environment it is linked to plus optional extra extensions. @@ -378,7 +378,7 @@ def overlay(self, block_start_string=missing, block_end_string=missing, rv = object.__new__(self.__class__) rv.__dict__.update(self.__dict__) - rv.overlayed = True + rv.overlaid = True rv.linked_to = self for key, value in iteritems(args): @@ -1074,7 +1074,7 @@ def make_module(self, vars=None, shared=False, locals=None): def make_module_async(self, vars=None, shared=False, locals=None): """As template module creation can invoke template code for - asynchronous exections this method must be used instead of the + asynchronous executions this method must be used instead of the normal :meth:`make_module` one. Likewise the module attribute becomes unavailable in async mode. """ diff --git a/tools/inspector_protocol/jinja2/ext.py b/tools/inspector_protocol/jinja2/ext.py index 0734a84f73d0dd..eed3f21025ec55 100644 --- a/tools/inspector_protocol/jinja2/ext.py +++ b/tools/inspector_protocol/jinja2/ext.py @@ -545,7 +545,7 @@ def babel_extract(fileobj, keywords, comment_tags, options): .. versionchanged:: 2.3 Basic support for translation comments was added. If `comment_tags` is now set to a list of keywords for extraction, the extractor will - try to find the best preceeding comment that begins with one of the + try to find the best preceding comment that begins with one of the keywords. For best results, make sure to not have more than one gettext call in one line of code and the matching comment in the same line or the line before. diff --git a/tools/inspector_protocol/jinja2/filters.py b/tools/inspector_protocol/jinja2/filters.py index 267ddddaa03478..a323e2587c0710 100644 --- a/tools/inspector_protocol/jinja2/filters.py +++ b/tools/inspector_protocol/jinja2/filters.py @@ -400,7 +400,7 @@ def do_join(eval_ctx, value, d=u'', attribute=None): if attribute is not None: value = imap(make_attrgetter(eval_ctx.environment, attribute), value) - # no automatic escaping? joining is a lot eaiser then + # no automatic escaping? joining is a lot easier then if not eval_ctx.autoescape: return text_type(d).join(imap(text_type, value)) diff --git a/tools/inspector_protocol/jinja2/nodes.py b/tools/inspector_protocol/jinja2/nodes.py index 4d9a01ad8bb2e7..849ad028a7e865 100644 --- a/tools/inspector_protocol/jinja2/nodes.py +++ b/tools/inspector_protocol/jinja2/nodes.py @@ -636,7 +636,7 @@ def as_const(self, eval_ctx=None): # we have to be careful here because we call filter_ below. # if this variable would be called filter, 2to3 would wrap the - # call in a list beause it is assuming we are talking about the + # call in a list because it is assuming we are talking about the # builtin filter function here which no longer returns a list in # python 3. because of that, do not rename filter_ to filter! filter_ = self.environment.filters.get(self.name) @@ -803,7 +803,7 @@ class Div(BinExpr): class FloorDiv(BinExpr): - """Divides the left by the right node and truncates conver the + """Divides the left by the right node and truncates convert the result into an integer by truncating. """ operator = '//' @@ -896,7 +896,7 @@ class InternalName(Expr): yourself but the parser provides a :meth:`~jinja2.parser.Parser.free_identifier` method that creates a new identifier for you. This identifier is not available from the - template and is not threated specially by the compiler. + template and is not treated specially by the compiler. """ fields = ('name',) diff --git a/tools/inspector_protocol/jinja2/runtime.py b/tools/inspector_protocol/jinja2/runtime.py index f9d7a6806caf54..49a7702228d673 100644 --- a/tools/inspector_protocol/jinja2/runtime.py +++ b/tools/inspector_protocol/jinja2/runtime.py @@ -515,7 +515,7 @@ def __call__(self, *args, **kwargs): # check here. # # This is considered safe because an eval context is not a valid - # argument to callables otherwise anwyays. Worst case here is + # argument to callables otherwise anyways. Worst case here is # that if no eval context is passed we fall back to the compile # time autoescape flag. if args and isinstance(args[0], EvalContext): diff --git a/tools/inspector_protocol/jinja2/sandbox.py b/tools/inspector_protocol/jinja2/sandbox.py index 93fb9d45f32d8b..03aaebd2eca293 100644 --- a/tools/inspector_protocol/jinja2/sandbox.py +++ b/tools/inspector_protocol/jinja2/sandbox.py @@ -40,7 +40,7 @@ #: unsafe method attributes. function attributes are unsafe for methods too UNSAFE_METHOD_ATTRIBUTES = set(['im_class', 'im_func', 'im_self']) -#: unsafe generator attirbutes. +#: unsafe generator attributes. UNSAFE_GENERATOR_ATTRIBUTES = set(['gi_frame', 'gi_code']) #: unsafe attributes on coroutines @@ -299,7 +299,7 @@ class SandboxedEnvironment(Environment): def intercept_unop(self, operator): """Called during template compilation with the name of a unary operator to check if it should be intercepted at runtime. If this - method returns `True`, :meth:`call_unop` is excuted for this unary + method returns `True`, :meth:`call_unop` is executed for this unary operator. The default implementation of :meth:`call_unop` will use the :attr:`unop_table` dictionary to perform the operator with the same logic as the builtin one. @@ -439,7 +439,7 @@ def is_safe_attribute(self, obj, attr, value): return not modifies_known_mutable(obj, attr) -# This really is not a public API apparenlty. +# This really is not a public API apparently. try: from _string import formatter_field_name_split except ImportError: diff --git a/tools/inspector_protocol/jinja2/utils.py b/tools/inspector_protocol/jinja2/utils.py index 502a311c08e549..083ea274b9fc7f 100644 --- a/tools/inspector_protocol/jinja2/utils.py +++ b/tools/inspector_protocol/jinja2/utils.py @@ -614,7 +614,7 @@ def __call__(self): class Namespace(object): """A namespace object that can hold arbitrary attributes. It may be - initialized from a dictionary or with keyword argments.""" + initialized from a dictionary or with keyword arguments.""" def __init__(*args, **kwargs): self, args = args[0], args[1:] diff --git a/tools/inspector_protocol/lib/encoding_cpp.template b/tools/inspector_protocol/lib/encoding_cpp.template index a0377d12f7dbb1..ae1b0bf2929a09 100644 --- a/tools/inspector_protocol/lib/encoding_cpp.template +++ b/tools/inspector_protocol/lib/encoding_cpp.template @@ -1755,7 +1755,7 @@ class JsonParser { } static bool IsSpaceOrNewLine(Char c) { - // \v = vertial tab; \f = form feed page break. + // \v = vertical tab; \f = form feed page break. return c == ' ' || c == '\n' || c == '\v' || c == '\f' || c == '\r' || c == '\t'; } diff --git a/tools/inspector_protocol/lib/encoding_h.template b/tools/inspector_protocol/lib/encoding_h.template index 2601192e160543..9832575ff37fc4 100644 --- a/tools/inspector_protocol/lib/encoding_h.template +++ b/tools/inspector_protocol/lib/encoding_h.template @@ -190,9 +190,9 @@ class StreamingParserHandler { virtual void HandleNull() = 0; // The parser may send one error even after other events have already - // been received. Client code is reponsible to then discard the + // been received. Client code is responsible to then discard the // already processed events. - // |error| must be an eror, as in, |error.is_ok()| can't be true. + // |error| must be an error, as in, |error.is_ok()| can't be true. virtual void HandleError(Status error) = 0; }; diff --git a/tools/lint-md/lint-md.mjs b/tools/lint-md/lint-md.mjs index 5a6ab56740ffb0..bb53ce039c4107 100644 --- a/tools/lint-md/lint-md.mjs +++ b/tools/lint-md/lint-md.mjs @@ -146,13 +146,13 @@ function trough() { } } } - function use(middelware) { - if (typeof middelware !== 'function') { + function use(middleware) { + if (typeof middleware !== 'function') { throw new TypeError( - 'Expected `middelware` to be a function, not ' + middelware + 'Expected `middleware` to be a function, not ' + middleware ) } - fns.push(middelware); + fns.push(middleware); return pipeline } } @@ -9936,15 +9936,15 @@ function exitParagraphWithTaskListItem(token) { if (head && head.type === 'text') { const siblings = parent.children; let index = -1; - let firstParaghraph; + let firstParagraph; while (++index < siblings.length) { const sibling = siblings[index]; if (sibling.type === 'paragraph') { - firstParaghraph = sibling; + firstParagraph = sibling; break } } - if (firstParaghraph === node) { + if (firstParagraph === node) { head.value = head.value.slice(1); if (head.value.length === 0) { node.children.shift(); @@ -14904,7 +14904,7 @@ const remarkLintCodeBlockStyle = lintRule$1( * * ## What is this? * - * This package checks the whitepsace in definition labels. + * This package checks the whitespace in definition labels. * * GFM footnotes are not affected by this rule as footnote labels cannot * contain whitespace. @@ -15609,7 +15609,7 @@ const remarkLintFileExtension = lintRule$1( * ## Recommendation * * There are different strategies for placing definitions. - * The simplest is perhaps to place them all at the bottem of documents. + * The simplest is perhaps to place them all at the bottom of documents. * If you prefer that, turn on this rule. * * [api-remark-lint-final-definition]: #unifieduseremarklintfinaldefinition @@ -17136,7 +17136,7 @@ const remarkLintNoHeadingIndent = lintRule$1( * @example * {"label": "output", "name": "not-ok.md"} * - * 3:1-3:10: Unexpected duplicate toplevel heading, exected a single heading with rank `1` + * 3:1-3:10: Unexpected duplicate toplevel heading, expected a single heading with rank `1` * * @example * {"config": 2, "label": "input", "name": "not-ok.md"} @@ -17147,7 +17147,7 @@ const remarkLintNoHeadingIndent = lintRule$1( * @example * {"config": 2, "label": "output", "name": "not-ok.md"} * - * 3:1-3:11: Unexpected duplicate toplevel heading, exected a single heading with rank `2` + * 3:1-3:11: Unexpected duplicate toplevel heading, expected a single heading with rank `2` * * @example * {"label": "input", "name": "html.md"} @@ -17160,7 +17160,7 @@ const remarkLintNoHeadingIndent = lintRule$1( * @example * {"label": "output", "name": "html.md"} * - * 5:1-5:14: Unexpected duplicate toplevel heading, exected a single heading with rank `1` + * 5:1-5:14: Unexpected duplicate toplevel heading, expected a single heading with rank `1` * * @example * {"label": "input", "mdx": true, "name": "mdx.mdx"} @@ -17172,7 +17172,7 @@ const remarkLintNoHeadingIndent = lintRule$1( * @example * {"label": "output", "mdx": true, "name": "mdx.mdx"} * - * 4:1-4:14: Unexpected duplicate toplevel heading, exected a single heading with rank `1` + * 4:1-4:14: Unexpected duplicate toplevel heading, expected a single heading with rank `1` */ const htmlRe = / nul > nul if errorlevel 1 goto :no-vswhere diff --git a/tools/pseudo-tty.py b/tools/pseudo-tty.py index 96300a679a58b3..5ce90250506c20 100755 --- a/tools/pseudo-tty.py +++ b/tools/pseudo-tty.py @@ -47,7 +47,7 @@ def pipe(sfd, dfd): if __name__ == '__main__': argv = sys.argv[1:] - # Make select() interruptable by SIGCHLD. + # Make select() interruptible by SIGCHLD. signal.signal(signal.SIGCHLD, lambda nr, _: None) parent_fd, child_fd = pty.openpty() diff --git a/tools/v8_gypfiles/features.gypi b/tools/v8_gypfiles/features.gypi index 6e21dac6d70ede..18479d7d2abc44 100644 --- a/tools/v8_gypfiles/features.gypi +++ b/tools/v8_gypfiles/features.gypi @@ -219,7 +219,7 @@ # Enable third party HEAP library 'v8_enable_third_party_heap%': 0, - # Libaries used by third party heap + # Libraries used by third party heap 'v8_third_party_heap_libs%': [], # Source code used by third party heap diff --git a/tools/v8_gypfiles/inspector.gypi b/tools/v8_gypfiles/inspector.gypi index 2f227f6fc2b4b0..aed336e76ee6b0 100644 --- a/tools/v8_gypfiles/inspector.gypi +++ b/tools/v8_gypfiles/inspector.gypi @@ -105,7 +105,7 @@ # Flat merge `third_party/inspector_protocol:inspector_string_conversions` '<(inspector_path)/v8-string-conversions.cc', '<(inspector_path)/v8-string-conversions.h', - # Flat merge `third_party/inspector_protocal:crdtp_platform` + # Flat merge `third_party/inspector_protocol:crdtp_platform` '<(inspector_protocol_path)/crdtp/json_platform.h', '<(inspector_protocol_path)/crdtp/json_platform_v8.cc', # Flat merge `third_party/inspector_protocol:crdtp` diff --git a/tools/v8_gypfiles/v8.gyp b/tools/v8_gypfiles/v8.gyp index 627b30fbee293a..262d52b0f48fb9 100644 --- a/tools/v8_gypfiles/v8.gyp +++ b/tools/v8_gypfiles/v8.gyp @@ -1893,7 +1893,7 @@ ['enable_lto=="true"', { 'cflags_cc': [ '-fno-lto' ], }], - # Chnges in push_registers_asm.cc in V8 v12.8 requires using + # Changes in push_registers_asm.cc in V8 v12.8 requires using # push_registers_masm on Windows even with ClangCL on x64 ['OS=="win"', { 'conditions': [ From 78b3e59b7d1a24b30815e140d29d850d5847ed47 Mon Sep 17 00:00:00 2001 From: Nathan Baulch Date: Tue, 24 Sep 2024 06:51:21 +1000 Subject: [PATCH 2/8] tools: restore github_reporter typos --- tools/github_reporter/index.js | 26 +++++++++++++------------- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/tools/github_reporter/index.js b/tools/github_reporter/index.js index 766dd523a1eac7..9abd7e231e1421 100644 --- a/tools/github_reporter/index.js +++ b/tools/github_reporter/index.js @@ -7410,7 +7410,7 @@ var require_client = __commonJS({ throw new InvalidArgumentError("allowH2 must be a valid boolean value"); } if (maxConcurrentStreams != null && (typeof maxConcurrentStreams !== "number" || maxConcurrentStreams < 1)) { - throw new InvalidArgumentError("maxConcurrentStreams must be a positive integer, greater than 0"); + throw new InvalidArgumentError("maxConcurrentStreams must be a possitive integer, greater than 0"); } if (typeof connect2 !== "function") { connect2 = buildConnector({ @@ -7451,7 +7451,7 @@ var require_client = __commonJS({ this[kHTTP2SessionState] = !allowH2 ? null : { // streams: null, // Fixed queue of streams - For future support of `push` openStreams: 0, - // Keep track of them to decide whether or not unref the session + // Keep track of them to decide wether or not unref the session maxConcurrentStreams: maxConcurrentStreams != null ? maxConcurrentStreams : 100 // Max peerConcurrentStreams for a Node h2 server }; @@ -9459,7 +9459,7 @@ var require_agent = __commonJS({ this[kFactory] = factory; this[kClients] = /* @__PURE__ */ new Map(); this[kFinalizer] = new FinalizationRegistry( - /* istanbul ignore next: gc is indeterministic */ + /* istanbul ignore next: gc is undeterministic */ (key) => { const ref = this[kClients].get(key); if (ref !== void 0 && ref.deref() === void 0) { @@ -13060,7 +13060,7 @@ var require_request2 = __commonJS({ return this[kState].reloadNavigation; } // Returns a boolean indicating whether or not request is for a history - // navigation (a.k.a. back-forward navigation). + // navigation (a.k.a. back-foward navigation). get isHistoryNavigation() { webidl.brandCheck(this, Request); return this[kState].historyNavigation; @@ -13527,9 +13527,9 @@ var require_fetch = __commonJS({ taskDestination = request.client.globalObject; crossOriginIsolatedCapability = request.client.crossOriginIsolatedCapability; } - const currentTime = coarsenedSharedCurrentTime(crossOriginIsolatedCapability); + const currenTime = coarsenedSharedCurrentTime(crossOriginIsolatedCapability); const timingInfo = createOpaqueTimingInfo({ - startTime: currentTime + startTime: currenTime }); const fetchParams = { controller: new Fetch(dispatcher), @@ -18582,7 +18582,7 @@ var require_summary = __commonJS({ /** * If the summary buffer is empty * - * @returns {boolean} true if the buffer is empty + * @returns {boolen} true if the buffer is empty */ isEmptyBuffer() { return this._buffer.length === 0; @@ -18667,10 +18667,10 @@ var require_summary = __commonJS({ return this.addRaw(element).addEOL(); } /** - * Adds a collapsible HTML details element to the summary buffer + * Adds a collapsable HTML details element to the summary buffer * * @param {string} label text for the closed state - * @param {string} content collapsible content + * @param {string} content collapsable content * * @returns {Summary} summary instance */ @@ -19390,7 +19390,7 @@ module.exports = async function githubReporter(source) { break; } } - const formattedDiagnostics = diagnostics.map((d) => { + const formatedDiagnostics = diagnostics.map((d) => { const [key, ...rest] = d.split(" "); const value = rest.join(" "); return [ @@ -19398,11 +19398,11 @@ module.exports = async function githubReporter(source) { DIAGNOSTIC_VALUES[key] ? DIAGNOSTIC_VALUES[key](value) : value ]; }); - core.startGroup(`Test results (${formattedDiagnostics.find(([key]) => key === DIAGNOSTIC_KEYS.pass)?.[1] ?? counter.pass} passed, ${formattedDiagnostics.find(([key]) => key === DIAGNOSTIC_KEYS.fail)?.[1] ?? counter.fail} failed)`); - core.notice(formattedDiagnostics.map((d) => d.join(": ")).join(EOL)); + core.startGroup(`Test results (${formatedDiagnostics.find(([key]) => key === DIAGNOSTIC_KEYS.pass)?.[1] ?? counter.pass} passed, ${formatedDiagnostics.find(([key]) => key === DIAGNOSTIC_KEYS.fail)?.[1] ?? counter.fail} failed)`); + core.notice(formatedDiagnostics.map((d) => d.join(": ")).join(EOL)); core.endGroup(); if (process.env.GITHUB_STEP_SUMMARY) { - await core.summary.addHeading("Test Results").addTable(formattedDiagnostics).write(); + await core.summary.addHeading("Test Results").addTable(formatedDiagnostics).write(); } }; /*! Bundled license information: From 15d0047ce27ecb96e2820c200ab90fcf17d826db Mon Sep 17 00:00:00 2001 From: Nathan Baulch Date: Tue, 24 Sep 2024 07:35:58 +1000 Subject: [PATCH 3/8] tools: restore gyp typos --- tools/gyp/docs/Hacking.md | 2 +- tools/gyp/docs/LanguageSpecification.md | 6 +++--- tools/gyp/docs/UserDocumentation.md | 4 ++-- tools/gyp/pylib/gyp/generator/cmake.py | 6 +++--- tools/gyp/pylib/gyp/generator/msvs.py | 2 +- tools/gyp/pylib/gyp/xcode_emulation.py | 2 +- tools/gyp/pylib/gyp/xcodeproj_file.py | 4 ++-- tools/gyp/pylib/packaging/metadata.py | 2 +- tools/gyp/tools/pretty_vcproj.py | 4 ++-- 9 files changed, 16 insertions(+), 16 deletions(-) diff --git a/tools/gyp/docs/Hacking.md b/tools/gyp/docs/Hacking.md index b00783bd36f2bb..89b3b8bea923ec 100644 --- a/tools/gyp/docs/Hacking.md +++ b/tools/gyp/docs/Hacking.md @@ -34,7 +34,7 @@ See [Testing](Testing.md) for more details on the test framework. Note that it can be handy to look at the project files output by the tests to diagnose problems. The easiest way to do that is by kindly asking the test driver to leave the temporary directories it creates in-place. -This is done by setting the environment variable "PRESERVE", e.g. +This is done by setting the enviroment variable "PRESERVE", e.g. ``` set PRESERVE=all # On Windows diff --git a/tools/gyp/docs/LanguageSpecification.md b/tools/gyp/docs/LanguageSpecification.md index f8fff097ab73f3..178b8c83169919 100644 --- a/tools/gyp/docs/LanguageSpecification.md +++ b/tools/gyp/docs/LanguageSpecification.md @@ -157,7 +157,7 @@ have structural meaning for target definitions: | `all_dependent_settings` | A dictionary of settings to be applied to all dependents of the target, transitively. This includes direct dependents and the entire set of their dependents, and so on. This section may contain anything found within a `target` dictionary, except `configurations`, `target_name`, and `type` sections. Compare `direct_dependent_settings` and `link_settings`. | | `configurations` | A list of dictionaries defining build configurations for the target. See the "Configurations" section below. | | `copies` | A list of copy actions to perform. See the "Copies" section below. | -| `defines` | A list of preprocessor definitions to be passed on the command line to the C/C++ compiler (via `-D` or `/D` options). | +| `defines` | A list of preprocesor definitions to be passed on the command line to the C/C++ compiler (via `-D` or `/D` options). | | `dependencies` | A list of targets on which this target depends. Targets in other `.gyp` files are specified as `../path/to/other.gyp:target_we_want`. | | `direct_dependent_settings` | A dictionary of settings to be applied to other targets that depend on this target. These settings will only be applied to direct dependents. This section may contain anything found within a `target` dictionary, except `configurations`, `target_name`, and `type` sections. Compare with `all_dependent_settings` and `link_settings`. | | `include_dirs` | A list of include directories to be passed on the command line to the C/C++ compiler (via `-I` or `/I` options). | @@ -208,8 +208,8 @@ Configuration dictionaries may also contain these elements: Conditionals may appear within any dictionary in a `.gyp` file. There are two tpes of conditionals, which differ only in the timing of their -processing. `conditions` sections are processed shortly after loading -`.gyp` files, and `target_conditions` sections are processed after all +processing. `conditons` sections are processed shortly after loading +`.gyp` files, and `target_conditons` sections are processed after all dependencies have been computed. A conditional section is introduced with a `conditions` or diff --git a/tools/gyp/docs/UserDocumentation.md b/tools/gyp/docs/UserDocumentation.md index 35bea38718c674..808f37a1a9361c 100644 --- a/tools/gyp/docs/UserDocumentation.md +++ b/tools/gyp/docs/UserDocumentation.md @@ -807,7 +807,7 @@ directory: ``` Adding a library often involves updating multiple `.gyp` files, adding -the target to the appropriate `.gyp` file (possibly a newly-added `.gyp` +the target to the approprate `.gyp` file (possibly a newly-added `.gyp` file), and updating targets in the other `.gyp` files that depend on (link with) the new library. @@ -858,7 +858,7 @@ because of those settings' being listed in the `direct_dependent_settings` block. Note that these settings will likely need to be replicated in the -settings for the library target itself, so that the library will build +settings for the library target itsef, so that the library will build with the same options. This does not prevent the target from defining additional options for its "internal" use when compiling its own source files. (In the above example, these are the `LOCAL_DEFINE_FOR_LIBBAR` diff --git a/tools/gyp/pylib/gyp/generator/cmake.py b/tools/gyp/pylib/gyp/generator/cmake.py index 1453cbc8f2d82c..320a891aa8adc9 100644 --- a/tools/gyp/pylib/gyp/generator/cmake.py +++ b/tools/gyp/pylib/gyp/generator/cmake.py @@ -251,7 +251,7 @@ def WriteActions(target_name, actions, extra_sources, extra_deps, path_to_gyp, o target_name: the name of the CMake target being generated. actions: the Gyp 'actions' dict for this target. extra_sources: [(, )] to append with generated source files. - extra_deps: [] to append with generated targets. + extra_deps: [] to append with generated targets. path_to_gyp: relative path from CMakeLists.txt being generated to the Gyp file in which the target being generated is defined. """ @@ -340,7 +340,7 @@ def WriteRules(target_name, rules, extra_sources, extra_deps, path_to_gyp, outpu target_name: the name of the CMake target being generated. actions: the Gyp 'actions' dict for this target. extra_sources: [(, )] to append with generated source files. - extra_deps: [] to append with generated targets. + extra_deps: [] to append with generated targets. path_to_gyp: relative path from CMakeLists.txt being generated to the Gyp file in which the target being generated is defined. """ @@ -457,7 +457,7 @@ def WriteCopies(target_name, copies, extra_deps, path_to_gyp, output): Args: target_name: the name of the CMake target being generated. actions: the Gyp 'actions' dict for this target. - extra_deps: [] to append with generated targets. + extra_deps: [] to append with generated targets. path_to_gyp: relative path from CMakeLists.txt being generated to the Gyp file in which the target being generated is defined. """ diff --git a/tools/gyp/pylib/gyp/generator/msvs.py b/tools/gyp/pylib/gyp/generator/msvs.py index 891e92e9824e43..6b5b24acc00019 100644 --- a/tools/gyp/pylib/gyp/generator/msvs.py +++ b/tools/gyp/pylib/gyp/generator/msvs.py @@ -3274,7 +3274,7 @@ def _GetMSBuildPropertyGroup(spec, label, properties): num_configurations = len(spec["configurations"]) def GetEdges(node): - # Use a definition of edges such that user_of_variable -> used_variable. + # Use a definition of edges such that user_of_variable -> used_varible. # This happens to be easier in this case, since a variable's # definition contains all variables it references in a single string. edges = set() diff --git a/tools/gyp/pylib/gyp/xcode_emulation.py b/tools/gyp/pylib/gyp/xcode_emulation.py index 72151765da9acc..5f2c097f63e1f4 100644 --- a/tools/gyp/pylib/gyp/xcode_emulation.py +++ b/tools/gyp/pylib/gyp/xcode_emulation.py @@ -1858,7 +1858,7 @@ def _TopologicallySortedEnvVarKeys(env): regex = re.compile(r"\$\{([a-zA-Z0-9\-_]+)\}") def GetEdges(node): - # Use a definition of edges such that user_of_variable -> used_variable. + # Use a definition of edges such that user_of_variable -> used_varible. # This happens to be easier in this case, since a variable's # definition contains all variables it references in a single string. # We can then reverse the result of the topological sort at the end. diff --git a/tools/gyp/pylib/gyp/xcodeproj_file.py b/tools/gyp/pylib/gyp/xcodeproj_file.py index 5b9d0026c178e4..33c667c266bf69 100644 --- a/tools/gyp/pylib/gyp/xcodeproj_file.py +++ b/tools/gyp/pylib/gyp/xcodeproj_file.py @@ -74,7 +74,7 @@ PBXBuildFile appears extraneous, but there's actually one reason for this: file-specific compiler flags are added to the PBXBuildFile object so as to allow a single file to be a member of multiple targets while having distinct -compiler flags for each. These flags can be modified in the Xcode application +compiler flags for each. These flags can be modified in the Xcode applciation in the "Build" tab of a File Info window. When a project is open in the Xcode application, Xcode will rewrite it. As @@ -662,7 +662,7 @@ def _XCKVPrint(self, file, tabs, key, value): tabs is an int identifying the indentation level. If the class' _should_print_single_line variable is True, tabs is ignored and the - key-value pair will be followed by a space instead of a newline. + key-value pair will be followed by a space insead of a newline. """ if self._should_print_single_line: diff --git a/tools/gyp/pylib/packaging/metadata.py b/tools/gyp/pylib/packaging/metadata.py index 7f067dda7a8b2b..fb274930799da0 100644 --- a/tools/gyp/pylib/packaging/metadata.py +++ b/tools/gyp/pylib/packaging/metadata.py @@ -206,7 +206,7 @@ def _parse_project_urls(data: List[str]) -> Dict[str, str]: # be the missing value, then they'd have multiple '' values that # overwrite each other in a accumulating dict. # - # The other potential issue is that it's possible to have the + # The other potentional issue is that it's possible to have the # same label multiple times in the metadata, with no solid "right" # answer with what to do in that case. As such, we'll do the only # thing we can, which is treat the field as unparseable and add it diff --git a/tools/gyp/tools/pretty_vcproj.py b/tools/gyp/tools/pretty_vcproj.py index d4b58fd87f9e32..72c65d7fc495f9 100755 --- a/tools/gyp/tools/pretty_vcproj.py +++ b/tools/gyp/tools/pretty_vcproj.py @@ -207,7 +207,7 @@ def CleanupVcproj(node): node.appendChild(new_node) -def GetConfigurationNodes(vcproj): +def GetConfiguationNodes(vcproj): # TODO(nsylvain): Find a better way to navigate the xml. nodes = [] for node in vcproj.childNodes: @@ -307,7 +307,7 @@ def main(argv): # First thing we need to do is find the Configuration Node and merge them # with the vsprops they include. - for configuration_node in GetConfigurationNodes(dom.documentElement): + for configuration_node in GetConfiguationNodes(dom.documentElement): # Get the property sheets associated with this configuration. vsprops = configuration_node.getAttribute("InheritedPropertySheets") From 3e7520bee742c01999d2d2b9d115f65c74e74682 Mon Sep 17 00:00:00 2001 From: Nathan Baulch Date: Tue, 24 Sep 2024 07:49:38 +1000 Subject: [PATCH 4/8] tools: restore icu typos --- tools/icu/icutrim.py | 6 +++--- tools/icu/patches/75/source/tools/genccode/genccode.c | 2 +- tools/icu/patches/75/source/tools/genccode/pkg_genc.h | 2 +- tools/icu/patches/75/source/tools/toolutil/pkg_genc.h | 2 +- 4 files changed, 6 insertions(+), 6 deletions(-) diff --git a/tools/icu/icutrim.py b/tools/icu/icutrim.py index b66dea148f65d7..0ae8c23319db93 100755 --- a/tools/icu/icutrim.py +++ b/tools/icu/icutrim.py @@ -214,7 +214,7 @@ def queueForRemoval(tree): mytree = trees[tree] if options.verbose > 0: print("* %s: %d items" % (tree, len(mytree["locs"]))) - # do variable substitution for this tree here + # do varible substitution for this tree here if isinstance(config["trees"][tree], basestring): treeStr = config["trees"][tree] if options.verbose > 5: @@ -280,7 +280,7 @@ def addTreeByType(tree, mytree): else: tree = treeprefix[0:-1] if(options.verbose>6): - print("processing %s" % (tree)) + print("procesing %s" % (tree)) trees[tree] = { "extension": ".res", "treeprefix": treeprefix, "hasIndex": True } # read in the resource list for the tree treelistfile = os.path.join(options.tmpdir,"%s.lst" % tree) @@ -331,7 +331,7 @@ def removeList(count=0): if(options.verbose > 5): print(" now %d items to remove" % len(remove)) if(oldcount == len(remove)): - print(" ERROR: could not add any more items to remove. Fail.") + print(" ERROR: could not add any mor eitems to remove. Fail.") sys.exit(1) removeList(count+1) diff --git a/tools/icu/patches/75/source/tools/genccode/genccode.c b/tools/icu/patches/75/source/tools/genccode/genccode.c index a5eed472e93233..0f243952a7d452 100644 --- a/tools/icu/patches/75/source/tools/genccode/genccode.c +++ b/tools/icu/patches/75/source/tools/genccode/genccode.c @@ -134,7 +134,7 @@ main(int argc, char* argv[]) { "\t-m or --match-arch file.o match the architecture (CPU, 32/64 bits) of the specified .o\n" "\t ELF format defaults to i386. Windows defaults to the native platform.\n" "\t-c or --cpu-arch Specify a CPU architecture for which to write a .obj file for ClangCL on Windows\n" - "\t Valid values for this option are x64, x86 and arm64.\n" + "\t Valid values for this opton are x64, x86 and arm64.\n" "\t--skip-dll-export Don't export the ICU data entry point symbol (for use when statically linking)\n"); #endif fprintf(stderr, diff --git a/tools/icu/patches/75/source/tools/genccode/pkg_genc.h b/tools/icu/patches/75/source/tools/genccode/pkg_genc.h index 5ee762c1f266e0..76474ec7df6fd8 100644 --- a/tools/icu/patches/75/source/tools/genccode/pkg_genc.h +++ b/tools/icu/patches/75/source/tools/genccode/pkg_genc.h @@ -52,7 +52,7 @@ #define USE_SINGLE_CCODE_FILE #endif -/* Need to fix the file separator character when using MinGW. */ +/* Need to fix the file seperator character when using MinGW. */ #if defined(WINDOWS_WITH_GNUC) || defined(USING_CYGWIN) #define PKGDATA_FILE_SEP_STRING "/" #else diff --git a/tools/icu/patches/75/source/tools/toolutil/pkg_genc.h b/tools/icu/patches/75/source/tools/toolutil/pkg_genc.h index 5ee762c1f266e0..76474ec7df6fd8 100644 --- a/tools/icu/patches/75/source/tools/toolutil/pkg_genc.h +++ b/tools/icu/patches/75/source/tools/toolutil/pkg_genc.h @@ -52,7 +52,7 @@ #define USE_SINGLE_CCODE_FILE #endif -/* Need to fix the file separator character when using MinGW. */ +/* Need to fix the file seperator character when using MinGW. */ #if defined(WINDOWS_WITH_GNUC) || defined(USING_CYGWIN) #define PKGDATA_FILE_SEP_STRING "/" #else From 50ae18849ca6fc6cc6fd57787b1712131064f676 Mon Sep 17 00:00:00 2001 From: Nathan Baulch Date: Tue, 24 Sep 2024 07:50:22 +1000 Subject: [PATCH 5/8] tools: restore inspector_protocol typos --- tools/inspector_protocol/code_generator.py | 2 +- tools/inspector_protocol/encoding/encoding.cc | 2 +- tools/inspector_protocol/encoding/encoding.h | 4 ++-- tools/inspector_protocol/jinja2/bccache.py | 2 +- tools/inspector_protocol/jinja2/compiler.py | 8 ++++---- tools/inspector_protocol/jinja2/debug.py | 2 +- tools/inspector_protocol/jinja2/environment.py | 8 ++++---- tools/inspector_protocol/jinja2/ext.py | 2 +- tools/inspector_protocol/jinja2/filters.py | 2 +- tools/inspector_protocol/jinja2/nodes.py | 6 +++--- tools/inspector_protocol/jinja2/runtime.py | 2 +- tools/inspector_protocol/jinja2/sandbox.py | 6 +++--- tools/inspector_protocol/jinja2/utils.py | 2 +- tools/inspector_protocol/lib/encoding_cpp.template | 2 +- tools/inspector_protocol/lib/encoding_h.template | 4 ++-- 15 files changed, 27 insertions(+), 27 deletions(-) diff --git a/tools/inspector_protocol/code_generator.py b/tools/inspector_protocol/code_generator.py index 77b2aa00bcdf79..a6e163c6fe911f 100755 --- a/tools/inspector_protocol/code_generator.py +++ b/tools/inspector_protocol/code_generator.py @@ -681,7 +681,7 @@ def generate_lib_file(file_name, template_files): generate_lib_file(os.path.join(config.lib.output, to_file_name(config, "base_string_adapter.h")), base_string_adapter_h_templates) generate_lib_file(os.path.join(config.lib.output, to_file_name(config, "base_string_adapter.cc")), base_string_adapter_cc_templates) - # Make gyp / make generators happy, otherwise make rebuilds world. + # Make gyp / make generatos happy, otherwise make rebuilds world. inputs_ts = max(map(os.path.getmtime, inputs)) up_to_date = True for output_file in outputs.keys(): diff --git a/tools/inspector_protocol/encoding/encoding.cc b/tools/inspector_protocol/encoding/encoding.cc index ee0c0562f46e76..f7e933e41afac5 100644 --- a/tools/inspector_protocol/encoding/encoding.cc +++ b/tools/inspector_protocol/encoding/encoding.cc @@ -1747,7 +1747,7 @@ class JsonParser { } static bool IsSpaceOrNewLine(Char c) { - // \v = vertical tab; \f = form feed page break. + // \v = vertial tab; \f = form feed page break. return c == ' ' || c == '\n' || c == '\v' || c == '\f' || c == '\r' || c == '\t'; } diff --git a/tools/inspector_protocol/encoding/encoding.h b/tools/inspector_protocol/encoding/encoding.h index e8ebe4e3378aed..a1bcfc4be3db4a 100644 --- a/tools/inspector_protocol/encoding/encoding.h +++ b/tools/inspector_protocol/encoding/encoding.h @@ -181,9 +181,9 @@ class StreamingParserHandler { virtual void HandleNull() = 0; // The parser may send one error even after other events have already - // been received. Client code is responsible to then discard the + // been received. Client code is reponsible to then discard the // already processed events. - // |error| must be an error, as in, |error.is_ok()| can't be true. + // |error| must be an eror, as in, |error.is_ok()| can't be true. virtual void HandleError(Status error) = 0; }; diff --git a/tools/inspector_protocol/jinja2/bccache.py b/tools/inspector_protocol/jinja2/bccache.py index ec980ae268bb42..080e527cabf33b 100644 --- a/tools/inspector_protocol/jinja2/bccache.py +++ b/tools/inspector_protocol/jinja2/bccache.py @@ -5,7 +5,7 @@ This module implements the bytecode cache system Jinja is optionally using. This is useful if you have very complex template situations and - the compilation of all those templates slow down your application too + the compiliation of all those templates slow down your application too much. Situations where this is useful are often forking web applications that diff --git a/tools/inspector_protocol/jinja2/compiler.py b/tools/inspector_protocol/jinja2/compiler.py index 28686a6a8bb004..d534a827391aeb 100644 --- a/tools/inspector_protocol/jinja2/compiler.py +++ b/tools/inspector_protocol/jinja2/compiler.py @@ -410,7 +410,7 @@ def signature(self, node, frame, extra_kwargs=None): """Writes a function call to the stream for the current node. A leading comma is added automatically. The extra keyword arguments may not include python keywords otherwise a syntax - error could occur. The extra keyword arguments should be given + error could occour. The extra keyword arguments should be given as python dict. """ # if any of the given keyword arguments is a python keyword @@ -1044,13 +1044,13 @@ def visit_For(self, node, frame): if node.test: loop_filter_func = self.temporary_identifier() test_frame.symbols.analyze_node(node, for_branch='test') - self.writeline('%s(filter):' % self.func(loop_filter_func), node.test) + self.writeline('%s(fiter):' % self.func(loop_filter_func), node.test) self.indent() self.enter_frame(test_frame) self.writeline(self.environment.is_async and 'async for ' or 'for ') self.visit(node.target, loop_frame) self.write(' in ') - self.write(self.environment.is_async and 'auto_aiter(filter)' or 'filter') + self.write(self.environment.is_async and 'auto_aiter(fiter)' or 'fiter') self.write(':') self.indent() self.writeline('if ', node.test) @@ -1256,7 +1256,7 @@ def visit_Output(self, node, frame): except nodes.Impossible: body.append(child) continue - # the frame can't be volatile here, because otherwise the + # the frame can't be volatile here, becaus otherwise the # as_const() function would raise an Impossible exception # at that point. try: diff --git a/tools/inspector_protocol/jinja2/debug.py b/tools/inspector_protocol/jinja2/debug.py index c3df3cace652d1..b61139f0cde17f 100644 --- a/tools/inspector_protocol/jinja2/debug.py +++ b/tools/inspector_protocol/jinja2/debug.py @@ -239,7 +239,7 @@ def fake_exc_info(exc_info, filename, lineno): else: locals = {} - # assemble fake globals we need + # assamble fake globals we need globals = { '__name__': filename, '__file__': filename, diff --git a/tools/inspector_protocol/jinja2/environment.py b/tools/inspector_protocol/jinja2/environment.py index 67271a7a440819..549d9afab456b4 100644 --- a/tools/inspector_protocol/jinja2/environment.py +++ b/tools/inspector_protocol/jinja2/environment.py @@ -240,7 +240,7 @@ class Environment(object): sandboxed = False #: True if the environment is just an overlay - overlaid = False + overlayed = False #: the environment this environment is linked to if it is an overlay linked_to = None @@ -364,7 +364,7 @@ def overlay(self, block_start_string=missing, block_end_string=missing, bytecode_cache=missing): """Create a new overlay environment that shares all the data with the current environment except for cache and the overridden attributes. - Extensions cannot be removed for an overlaid environment. An overlaid + Extensions cannot be removed for an overlayed environment. An overlayed environment automatically gets all the extensions of the environment it is linked to plus optional extra extensions. @@ -378,7 +378,7 @@ def overlay(self, block_start_string=missing, block_end_string=missing, rv = object.__new__(self.__class__) rv.__dict__.update(self.__dict__) - rv.overlaid = True + rv.overlayed = True rv.linked_to = self for key, value in iteritems(args): @@ -1074,7 +1074,7 @@ def make_module(self, vars=None, shared=False, locals=None): def make_module_async(self, vars=None, shared=False, locals=None): """As template module creation can invoke template code for - asynchronous executions this method must be used instead of the + asynchronous exections this method must be used instead of the normal :meth:`make_module` one. Likewise the module attribute becomes unavailable in async mode. """ diff --git a/tools/inspector_protocol/jinja2/ext.py b/tools/inspector_protocol/jinja2/ext.py index eed3f21025ec55..0734a84f73d0dd 100644 --- a/tools/inspector_protocol/jinja2/ext.py +++ b/tools/inspector_protocol/jinja2/ext.py @@ -545,7 +545,7 @@ def babel_extract(fileobj, keywords, comment_tags, options): .. versionchanged:: 2.3 Basic support for translation comments was added. If `comment_tags` is now set to a list of keywords for extraction, the extractor will - try to find the best preceding comment that begins with one of the + try to find the best preceeding comment that begins with one of the keywords. For best results, make sure to not have more than one gettext call in one line of code and the matching comment in the same line or the line before. diff --git a/tools/inspector_protocol/jinja2/filters.py b/tools/inspector_protocol/jinja2/filters.py index a323e2587c0710..267ddddaa03478 100644 --- a/tools/inspector_protocol/jinja2/filters.py +++ b/tools/inspector_protocol/jinja2/filters.py @@ -400,7 +400,7 @@ def do_join(eval_ctx, value, d=u'', attribute=None): if attribute is not None: value = imap(make_attrgetter(eval_ctx.environment, attribute), value) - # no automatic escaping? joining is a lot easier then + # no automatic escaping? joining is a lot eaiser then if not eval_ctx.autoescape: return text_type(d).join(imap(text_type, value)) diff --git a/tools/inspector_protocol/jinja2/nodes.py b/tools/inspector_protocol/jinja2/nodes.py index 849ad028a7e865..4d9a01ad8bb2e7 100644 --- a/tools/inspector_protocol/jinja2/nodes.py +++ b/tools/inspector_protocol/jinja2/nodes.py @@ -636,7 +636,7 @@ def as_const(self, eval_ctx=None): # we have to be careful here because we call filter_ below. # if this variable would be called filter, 2to3 would wrap the - # call in a list because it is assuming we are talking about the + # call in a list beause it is assuming we are talking about the # builtin filter function here which no longer returns a list in # python 3. because of that, do not rename filter_ to filter! filter_ = self.environment.filters.get(self.name) @@ -803,7 +803,7 @@ class Div(BinExpr): class FloorDiv(BinExpr): - """Divides the left by the right node and truncates convert the + """Divides the left by the right node and truncates conver the result into an integer by truncating. """ operator = '//' @@ -896,7 +896,7 @@ class InternalName(Expr): yourself but the parser provides a :meth:`~jinja2.parser.Parser.free_identifier` method that creates a new identifier for you. This identifier is not available from the - template and is not treated specially by the compiler. + template and is not threated specially by the compiler. """ fields = ('name',) diff --git a/tools/inspector_protocol/jinja2/runtime.py b/tools/inspector_protocol/jinja2/runtime.py index 49a7702228d673..f9d7a6806caf54 100644 --- a/tools/inspector_protocol/jinja2/runtime.py +++ b/tools/inspector_protocol/jinja2/runtime.py @@ -515,7 +515,7 @@ def __call__(self, *args, **kwargs): # check here. # # This is considered safe because an eval context is not a valid - # argument to callables otherwise anyways. Worst case here is + # argument to callables otherwise anwyays. Worst case here is # that if no eval context is passed we fall back to the compile # time autoescape flag. if args and isinstance(args[0], EvalContext): diff --git a/tools/inspector_protocol/jinja2/sandbox.py b/tools/inspector_protocol/jinja2/sandbox.py index 03aaebd2eca293..93fb9d45f32d8b 100644 --- a/tools/inspector_protocol/jinja2/sandbox.py +++ b/tools/inspector_protocol/jinja2/sandbox.py @@ -40,7 +40,7 @@ #: unsafe method attributes. function attributes are unsafe for methods too UNSAFE_METHOD_ATTRIBUTES = set(['im_class', 'im_func', 'im_self']) -#: unsafe generator attributes. +#: unsafe generator attirbutes. UNSAFE_GENERATOR_ATTRIBUTES = set(['gi_frame', 'gi_code']) #: unsafe attributes on coroutines @@ -299,7 +299,7 @@ class SandboxedEnvironment(Environment): def intercept_unop(self, operator): """Called during template compilation with the name of a unary operator to check if it should be intercepted at runtime. If this - method returns `True`, :meth:`call_unop` is executed for this unary + method returns `True`, :meth:`call_unop` is excuted for this unary operator. The default implementation of :meth:`call_unop` will use the :attr:`unop_table` dictionary to perform the operator with the same logic as the builtin one. @@ -439,7 +439,7 @@ def is_safe_attribute(self, obj, attr, value): return not modifies_known_mutable(obj, attr) -# This really is not a public API apparently. +# This really is not a public API apparenlty. try: from _string import formatter_field_name_split except ImportError: diff --git a/tools/inspector_protocol/jinja2/utils.py b/tools/inspector_protocol/jinja2/utils.py index 083ea274b9fc7f..502a311c08e549 100644 --- a/tools/inspector_protocol/jinja2/utils.py +++ b/tools/inspector_protocol/jinja2/utils.py @@ -614,7 +614,7 @@ def __call__(self): class Namespace(object): """A namespace object that can hold arbitrary attributes. It may be - initialized from a dictionary or with keyword arguments.""" + initialized from a dictionary or with keyword argments.""" def __init__(*args, **kwargs): self, args = args[0], args[1:] diff --git a/tools/inspector_protocol/lib/encoding_cpp.template b/tools/inspector_protocol/lib/encoding_cpp.template index ae1b0bf2929a09..a0377d12f7dbb1 100644 --- a/tools/inspector_protocol/lib/encoding_cpp.template +++ b/tools/inspector_protocol/lib/encoding_cpp.template @@ -1755,7 +1755,7 @@ class JsonParser { } static bool IsSpaceOrNewLine(Char c) { - // \v = vertical tab; \f = form feed page break. + // \v = vertial tab; \f = form feed page break. return c == ' ' || c == '\n' || c == '\v' || c == '\f' || c == '\r' || c == '\t'; } diff --git a/tools/inspector_protocol/lib/encoding_h.template b/tools/inspector_protocol/lib/encoding_h.template index 9832575ff37fc4..2601192e160543 100644 --- a/tools/inspector_protocol/lib/encoding_h.template +++ b/tools/inspector_protocol/lib/encoding_h.template @@ -190,9 +190,9 @@ class StreamingParserHandler { virtual void HandleNull() = 0; // The parser may send one error even after other events have already - // been received. Client code is responsible to then discard the + // been received. Client code is reponsible to then discard the // already processed events. - // |error| must be an error, as in, |error.is_ok()| can't be true. + // |error| must be an eror, as in, |error.is_ok()| can't be true. virtual void HandleError(Status error) = 0; }; From e5ccf36863cf2960bc0e202c265126da51a6974e Mon Sep 17 00:00:00 2001 From: Nathan Baulch Date: Tue, 24 Sep 2024 07:51:11 +1000 Subject: [PATCH 6/8] tools: restore lint-md typos --- tools/lint-md/lint-md.mjs | 28 ++++++++++++++-------------- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/tools/lint-md/lint-md.mjs b/tools/lint-md/lint-md.mjs index bb53ce039c4107..5a6ab56740ffb0 100644 --- a/tools/lint-md/lint-md.mjs +++ b/tools/lint-md/lint-md.mjs @@ -146,13 +146,13 @@ function trough() { } } } - function use(middleware) { - if (typeof middleware !== 'function') { + function use(middelware) { + if (typeof middelware !== 'function') { throw new TypeError( - 'Expected `middleware` to be a function, not ' + middleware + 'Expected `middelware` to be a function, not ' + middelware ) } - fns.push(middleware); + fns.push(middelware); return pipeline } } @@ -9936,15 +9936,15 @@ function exitParagraphWithTaskListItem(token) { if (head && head.type === 'text') { const siblings = parent.children; let index = -1; - let firstParagraph; + let firstParaghraph; while (++index < siblings.length) { const sibling = siblings[index]; if (sibling.type === 'paragraph') { - firstParagraph = sibling; + firstParaghraph = sibling; break } } - if (firstParagraph === node) { + if (firstParaghraph === node) { head.value = head.value.slice(1); if (head.value.length === 0) { node.children.shift(); @@ -14904,7 +14904,7 @@ const remarkLintCodeBlockStyle = lintRule$1( * * ## What is this? * - * This package checks the whitespace in definition labels. + * This package checks the whitepsace in definition labels. * * GFM footnotes are not affected by this rule as footnote labels cannot * contain whitespace. @@ -15609,7 +15609,7 @@ const remarkLintFileExtension = lintRule$1( * ## Recommendation * * There are different strategies for placing definitions. - * The simplest is perhaps to place them all at the bottom of documents. + * The simplest is perhaps to place them all at the bottem of documents. * If you prefer that, turn on this rule. * * [api-remark-lint-final-definition]: #unifieduseremarklintfinaldefinition @@ -17136,7 +17136,7 @@ const remarkLintNoHeadingIndent = lintRule$1( * @example * {"label": "output", "name": "not-ok.md"} * - * 3:1-3:10: Unexpected duplicate toplevel heading, expected a single heading with rank `1` + * 3:1-3:10: Unexpected duplicate toplevel heading, exected a single heading with rank `1` * * @example * {"config": 2, "label": "input", "name": "not-ok.md"} @@ -17147,7 +17147,7 @@ const remarkLintNoHeadingIndent = lintRule$1( * @example * {"config": 2, "label": "output", "name": "not-ok.md"} * - * 3:1-3:11: Unexpected duplicate toplevel heading, expected a single heading with rank `2` + * 3:1-3:11: Unexpected duplicate toplevel heading, exected a single heading with rank `2` * * @example * {"label": "input", "name": "html.md"} @@ -17160,7 +17160,7 @@ const remarkLintNoHeadingIndent = lintRule$1( * @example * {"label": "output", "name": "html.md"} * - * 5:1-5:14: Unexpected duplicate toplevel heading, expected a single heading with rank `1` + * 5:1-5:14: Unexpected duplicate toplevel heading, exected a single heading with rank `1` * * @example * {"label": "input", "mdx": true, "name": "mdx.mdx"} @@ -17172,7 +17172,7 @@ const remarkLintNoHeadingIndent = lintRule$1( * @example * {"label": "output", "mdx": true, "name": "mdx.mdx"} * - * 4:1-4:14: Unexpected duplicate toplevel heading, expected a single heading with rank `1` + * 4:1-4:14: Unexpected duplicate toplevel heading, exected a single heading with rank `1` */ const htmlRe = / Date: Wed, 9 Oct 2024 07:39:47 +1100 Subject: [PATCH 7/8] tools: restore cpplint typos --- tools/cpplint.py | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/tools/cpplint.py b/tools/cpplint.py index 025f6dc16de362..5d6172d5a4e8b1 100755 --- a/tools/cpplint.py +++ b/tools/cpplint.py @@ -913,7 +913,7 @@ # Files to exclude from linting. This is set by the --exclude flag. _excludes = None -# Whether to suppress all PrintInfo messages, UNRELATED to --quiet flag +# Whether to supress all PrintInfo messages, UNRELATED to --quiet flag _quiet = False # The allowed line length of files. @@ -1040,7 +1040,7 @@ def ParseNolintSuppressions(filename, raw_line, linenum, error): 'Unknown NOLINT error category: %s' % category) -def ProcessGlobalSuppressions(lines): +def ProcessGlobalSuppresions(lines): """Updates the list of global error suppressions. Parses any lint directives in the file that have global effect. @@ -1068,7 +1068,7 @@ def IsErrorSuppressedByNolint(category, linenum): """Returns true if the specified error category is suppressed on this line. Consults the global error_suppressions map populated by - ParseNolintSuppressions/ProcessGlobalSuppressions/ResetNolintSuppressions. + ParseNolintSuppressions/ProcessGlobalSuppresions/ResetNolintSuppressions. Args: category: str, the category of the error. @@ -1311,7 +1311,7 @@ def __init__(self): self._filters_backup = self.filters[:] self.counting = 'total' # In what way are we counting errors? self.errors_by_category = {} # string to int dict storing error counts - self.quiet = False # Suppress non-error messages? + self.quiet = False # Suppress non-error messagess? # output format: # "emacs" - format that emacs can parse (default) @@ -6617,7 +6617,7 @@ def ProcessFileData(filename, file_extension, lines, error, ResetNolintSuppressions() CheckForCopyright(filename, lines, error) - ProcessGlobalSuppressions(lines) + ProcessGlobalSuppresions(lines) RemoveMultiLineComments(filename, lines, error) clean_lines = CleansedLines(lines) From 4f32733e7f44cd8e4b98ea847e99dd5ba24108e6 Mon Sep 17 00:00:00 2001 From: Nathan Baulch Date: Wed, 9 Oct 2024 16:55:58 +1100 Subject: [PATCH 8/8] Update tools/gen_node_def.cc MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-authored-by: Michaël Zasso --- tools/gen_node_def.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/gen_node_def.cc b/tools/gen_node_def.cc index 6b3e2d84c53c0a..10e2939c80bbfd 100644 --- a/tools/gen_node_def.cc +++ b/tools/gen_node_def.cc @@ -11,7 +11,7 @@ // symbols from the DLL and redirects them back to the DLL. // This allows node.exe to export the same symbols as libnode.dll // when building Node.js as a shared library. This is conceptually -// similarly to the create_expfile.sh script used on AIX. +// similar to the create_expfile.sh script used on AIX. // // Generating this .def file requires parsing data out of the // PE32/PE32+ file format. Helper structs are defined in