From 86167c2043e4df7e58cb5eb91b3ff12e70e682ef Mon Sep 17 00:00:00 2001 From: Rich Trott Date: Sat, 27 Feb 2016 22:08:08 -0800 Subject: [PATCH] build: run lint before tests Have `make test` run linting tools before tests rather than after. Lint is likely to find issues quickly. Tests may take a while to run. So do the linting first. Interestingly, it appears that `vcbuild.bat` is already set up this way on Windows. Refs: https://github.com/nodejs/node/issues/4546#issuecomment-189755007 --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index bcb434d6a5576e..d551ef2e446288 100644 --- a/Makefile +++ b/Makefile @@ -111,9 +111,9 @@ v8: $(MAKE) -C deps/v8 $(V8_ARCH) $(V8_BUILD_OPTIONS) test: | cctest # Depends on 'all'. - $(PYTHON) tools/test.py --mode=release message parallel sequential -J $(MAKE) jslint $(MAKE) cpplint + $(PYTHON) tools/test.py --mode=release message parallel sequential -J test-parallel: all $(PYTHON) tools/test.py --mode=release parallel -J