-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
node-api: make napi_get_buffer_info check if passed buffer is valid #51571
Conversation
Review requested:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fixed the linting errors, however, I have no idea why the test suddenly blew up on macOS. Possibly flaky? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@Janrupf kicked off another CI, I should have waited until the local ones had run before doing that earlier, we'll see what the results look like now. |
Formatting should be good now, though the coverage test failed. I'm not sure if this is related to my changes (seems a bit unlikely) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Jenkins still says its under security embargo, so I have no idea why the tests fail (they do pass locally...), any chance someone could take a look at this/make the logs available? |
CI seems to be failing due to something unrelated again, @mhdawson mind taking a look? |
I think it's been too long to resume the existing ci, kicked off another one, expect it to need to be resumed a few times. |
@mhdawson CI failed again (sorry for the pings...), this time another random check. I don't think this is related to my changes, but neither can I fully confirm it is not. Any idea if thats a flaky test or something really is broken? |
Opened - #51813 for latest flaky test failure. |
Landed in 281c342 |
PR-URL: #51571 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Vladimir Morozov <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]>
PR-URL: #51571 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Vladimir Morozov <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]>
PR-URL: #51571 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Vladimir Morozov <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]>
PR-URL: #51571 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Vladimir Morozov <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]>
PR-URL: #51571 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Vladimir Morozov <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]>
PR-URL: nodejs#51571 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Vladimir Morozov <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]>
Fixes #51570