-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
benchmark: update iterations in benchmark/util/splice-one.js #50698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
benchmark
Issues and PRs related to the benchmark subsystem.
util
Issues and PRs related to the built-in util module.
labels
Nov 13, 2023
Increase the number of iterations from 1e5 to 5e6 to avoid the test performance gap caused by inactive V8 optimization caused by insufficient number of iterations Refs: nodejs#50571
H4ad
approved these changes
Nov 17, 2023
H4ad
added
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
request-ci
Add this label to start a Jenkins CI on a PR.
labels
Nov 17, 2023
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
Nov 17, 2023
H4ad
added
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Nov 26, 2023
nodejs-github-bot
removed
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Nov 26, 2023
Landed in f8c27e6 |
martenrichter
pushed a commit
to martenrichter/node
that referenced
this pull request
Nov 26, 2023
Increase the number of iterations from 1e5 to 5e6 to avoid the test performance gap caused by inactive V8 optimization caused by insufficient number of iterations Refs: nodejs#50571 PR-URL: nodejs#50698 Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
lucshi
pushed a commit
to lucshi/node
that referenced
this pull request
Nov 27, 2023
Increase the number of iterations from 1e5 to 5e6 to avoid the test performance gap caused by inactive V8 optimization caused by insufficient number of iterations Refs: nodejs#50571 PR-URL: nodejs#50698 Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
RafaelGSS
pushed a commit
that referenced
this pull request
Nov 27, 2023
Increase the number of iterations from 1e5 to 5e6 to avoid the test performance gap caused by inactive V8 optimization caused by insufficient number of iterations Refs: #50571 PR-URL: #50698 Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
Merged
RafaelGSS
pushed a commit
that referenced
this pull request
Nov 29, 2023
Increase the number of iterations from 1e5 to 5e6 to avoid the test performance gap caused by inactive V8 optimization caused by insufficient number of iterations Refs: #50571 PR-URL: #50698 Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
RafaelGSS
pushed a commit
that referenced
this pull request
Nov 30, 2023
Increase the number of iterations from 1e5 to 5e6 to avoid the test performance gap caused by inactive V8 optimization caused by insufficient number of iterations Refs: #50571 PR-URL: #50698 Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
UlisesGascon
pushed a commit
that referenced
this pull request
Dec 11, 2023
Increase the number of iterations from 1e5 to 5e6 to avoid the test performance gap caused by inactive V8 optimization caused by insufficient number of iterations Refs: #50571 PR-URL: #50698 Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
Merged
UlisesGascon
pushed a commit
that referenced
this pull request
Dec 13, 2023
Increase the number of iterations from 1e5 to 5e6 to avoid the test performance gap caused by inactive V8 optimization caused by insufficient number of iterations Refs: #50571 PR-URL: #50698 Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
UlisesGascon
pushed a commit
that referenced
this pull request
Dec 15, 2023
Increase the number of iterations from 1e5 to 5e6 to avoid the test performance gap caused by inactive V8 optimization caused by insufficient number of iterations Refs: #50571 PR-URL: #50698 Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
UlisesGascon
pushed a commit
that referenced
this pull request
Dec 19, 2023
Increase the number of iterations from 1e5 to 5e6 to avoid the test performance gap caused by inactive V8 optimization caused by insufficient number of iterations Refs: #50571 PR-URL: #50698 Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
benchmark
Issues and PRs related to the benchmark subsystem.
util
Issues and PRs related to the built-in util module.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: #50571
In case
util/splice-one.js
, when onlypos=end
I found that the performance gap between node-21.x and node-20.x increased from -15% to 5% after I changed iterations from default1e5
to5e6
. (node-20.x is the baseline.)To make sure there was no problem with this modification, I tested the other 8 situations in this case (there are 9 situations in total, 3 types of
pos
, 3 types ofsize
).Here is the tests data and the new binary is
node 21.x
.node-21.x vs node-20.x