-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
benchmark: differentiate whatwg and legacy url #47377
Conversation
Huh? That sounds like a good reason not to backport Ada to Node.js 18 if it's going to cause a regression. |
I mean Ada is faster than url.parse by 3x. Bad way to rephrase it, my bad! |
cc @nodejs/url @nodejs/performance appreciate reviews |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm ok with this as long as the results between the new legacy-only and whatwg-only benchmarks are still comparable – which they seem to be.
Commit Queue failed- Loading data for nodejs/node/pull/47377 ✔ Done loading data for nodejs/node/pull/47377 ----------------------------------- PR info ------------------------------------ Title benchmark: differentiate whatwg and legacy url (#47377) Author Yagiz Nizipli (@anonrig) Branch anonrig:benchmark-urls -> nodejs:main Labels url, benchmark, author ready, commit-queue-squash Commits 2 - benchmark: differentiate whatwg and legacy url - fixup! benchmark: differentiate whatwg and legacy url Committers 1 - Yagiz Nizipli PR-URL: https://github.com/nodejs/node/pull/47377 Reviewed-By: Benjamin Gruenbaum Reviewed-By: Tiancheng "Timothy" Gu ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/47377 Reviewed-By: Benjamin Gruenbaum Reviewed-By: Tiancheng "Timothy" Gu -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last review: ⚠ - fixup! benchmark: differentiate whatwg and legacy url ℹ This PR was created on Mon, 03 Apr 2023 02:09:09 GMT ✔ Approvals: 2 ✔ - Benjamin Gruenbaum (@benjamingr): https://github.com/nodejs/node/pull/47377#pullrequestreview-1374972136 ✔ - Tiancheng "Timothy" Gu (@TimothyGu) (TSC): https://github.com/nodejs/node/pull/47377#pullrequestreview-1375735658 ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/4693909020 |
@nodejs/performance can you review? |
Landed in cd0fcf2 |
PR-URL: #47377 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: Matthew Aitken <[email protected]>
PR-URL: #47377 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: Matthew Aitken <[email protected]>
depends on #47351 and #47179 |
PR-URL: #47377 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: Matthew Aitken <[email protected]>
PR-URL: nodejs/node#47377 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: Matthew Aitken <[email protected]>
PR-URL: nodejs/node#47377 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: Matthew Aitken <[email protected]>
After merging Ada pull request, Ada will be 3x faster than the legacy
url.parse
method, and we don't even need to run the legacy benchmarks most of the time. This pull request splits the benchmarks into multiple benchmarks.