From 8ddb975852d99aa9e8011add31f3c86356ee0532 Mon Sep 17 00:00:00 2001 From: Keyhan Vakil Date: Tue, 2 Aug 2022 01:41:50 +0000 Subject: [PATCH 1/3] doc,worker: deprecate --trace-atomics-wait V8 has asked if it possible to remove the functionality underlying `--trace-atomics-wait`. Let's start with a documentation-only deprecation. Refs: https://github.com/nodejs/node/issues/42982 --- doc/api/cli.md | 3 +++ doc/api/deprecations.md | 14 ++++++++++++++ doc/node.1 | 1 + 3 files changed, 18 insertions(+) diff --git a/doc/api/cli.md b/doc/api/cli.md index 51a84cebb79678..7e3c0cb575b72d 100644 --- a/doc/api/cli.md +++ b/doc/api/cli.md @@ -1244,8 +1244,11 @@ for TLSv1.2, which is not as secure as TLSv1.3. +> Stability: 0 - Deprecated + Print short summaries of calls to [`Atomics.wait()`][] to stderr. The output could look like this: diff --git a/doc/api/deprecations.md b/doc/api/deprecations.md index efc17e94528dc1..c1d0c496acfcb3 100644 --- a/doc/api/deprecations.md +++ b/doc/api/deprecations.md @@ -3177,6 +3177,19 @@ Type: Documentation-only `code` values other than `undefined`, `null`, integer numbers and integer strings (e.g., '1') are deprecated as parameter in [`process.exit()`][]. +### DEP0165: `--trace-atomics-wait` + + + +Type: Documentation-only + +The [`--trace-atomics-wait`][] flag is deprecated. + [Legacy URL API]: url.md#legacy-url-api [NIST SP 800-38D]: https://nvlpubs.nist.gov/nistpubs/Legacy/SP/nistspecialpublication800-38d.pdf [RFC 6066]: https://tools.ietf.org/html/rfc6066#section-3 @@ -3184,6 +3197,7 @@ strings (e.g., '1') are deprecated as parameter in [`process.exit()`][]. [`"exports"` or `"main"` entry]: packages.md#main-entry-point-export [`--pending-deprecation`]: cli.md#--pending-deprecation [`--throw-deprecation`]: cli.md#--throw-deprecation +[`--trace-atomics-wait`]: cli.md#--trace-atomics-wait [`--unhandled-rejections`]: cli.md#--unhandled-rejectionsmode [`Buffer.allocUnsafeSlow(size)`]: buffer.md#static-method-bufferallocunsafeslowsize [`Buffer.from(array)`]: buffer.md#static-method-bufferfromarray diff --git a/doc/node.1 b/doc/node.1 index ecc275df658813..2c179442ab2f41 100644 --- a/doc/node.1 +++ b/doc/node.1 @@ -435,6 +435,7 @@ favour of TLSv1.3, which is more secure. Print short summaries of calls to .Sy Atomics.wait() . . +This flag is deprecated. .It Fl -trace-deprecation Print stack traces for deprecations. . From 67ecb5e53de8d25d1eec7f245b847c1feeda8dde Mon Sep 17 00:00:00 2001 From: Keyhan Vakil Date: Wed, 3 Aug 2022 00:37:35 +0000 Subject: [PATCH 2/3] fixup! doc,worker: deprecate --trace-atomics-wait --- src/node_options.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/node_options.cc b/src/node_options.cc index 5189df1ae66ee1..dd810a24e092a5 100644 --- a/src/node_options.cc +++ b/src/node_options.cc @@ -540,7 +540,7 @@ EnvironmentOptionsParser::EnvironmentOptionsParser() { &EnvironmentOptions::throw_deprecation, kAllowedInEnvironment); AddOption("--trace-atomics-wait", - "trace Atomics.wait() operations", + "(deprecated) trace Atomics.wait() operations", &EnvironmentOptions::trace_atomics_wait, kAllowedInEnvironment); AddOption("--trace-deprecation", From d598121add6d122f0f5b968b691bf7a245678f36 Mon Sep 17 00:00:00 2001 From: Keyhan Vakil Date: Wed, 3 Aug 2022 03:55:50 +0000 Subject: [PATCH 3/3] fixup! doc,worker: deprecate --trace-atomics-wait