stream: allow using .push()/.unshift() during once('data')
#34957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the `.push()` or `.unshift()` call would just have jumped straight to emitting a `'data'` event, even if there were no listeners, effectively just silently dropping the chunk.
addaleax
added
stream
3 tasks
github-actions
bot
removed
the
request-ci
lpinca
approved these changes
Aug 28, 2020
cjihrig
approved these changes
Aug 28, 2020
Trott
approved these changes
Aug 28, 2020
|
Benchmark CI as requested by @mcollina in #34958: https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/662/ I don’t know what impact the result would have on the PR here, though. Unless this turns out to be a really bad performance regression, I’d say that correctness comes first. |
|
Based on benchmarks the impact is negligible 01:28:09 confidence improvement accuracy (*) (**) (***)
01:28:09 streams/creation.js kind='duplex' n=50000000 -1.51 % ±2.87% ±3.82% ±4.97%
01:28:09 streams/creation.js kind='readable' n=50000000 -1.32 % ±2.46% ±3.27% ±4.26%
01:28:09 streams/creation.js kind='transform' n=50000000 1.09 % ±3.36% ±4.47% ±5.81%
01:28:09 streams/creation.js kind='writable' n=50000000 -0.80 % ±3.32% ±4.42% ±5.75%
01:28:09 streams/pipe.js n=5000000 1.03 % ±2.58% ±3.44% ±4.51%
01:28:09 streams/pipe-object-mode.js n=5000000 -1.82 % ±3.49% ±4.67% ±6.15%
01:28:09 streams/readable-async-iterator.js sync='no' n=100000 0.25 % ±2.58% ±3.43% ±4.47%
01:28:09 streams/readable-async-iterator.js sync='yes' n=100000 0.01 % ±4.45% ±5.93% ±7.71%
01:28:09 streams/readable-bigread.js n=1000 -2.38 % ±2.78% ±3.70% ±4.82%
01:28:09 streams/readable-bigunevenread.js n=1000 0.80 % ±5.46% ±7.27% ±9.47%
01:28:09 streams/readable-boundaryread.js type='buffer' n=2000 2.44 % ±3.76% ±5.03% ±6.60%
01:28:09 streams/readable-boundaryread.js type='string' n=2000 -0.21 % ±2.22% ±2.96% ±3.86%
01:28:09 streams/readable-readall.js n=5000 2.98 % ±3.28% ±4.36% ±5.68%
01:28:09 streams/readable-unevenread.js n=1000 -0.53 % ±1.43% ±1.91% ±2.48%
01:28:09 streams/writable-manywrites.js len=1024 callback='no' writev='no' sync='no' n=2000000 -0.39 % ±1.32% ±1.76% ±2.29%
01:28:09 streams/writable-manywrites.js len=1024 callback='no' writev='no' sync='yes' n=2000000 3.61 % ±4.43% ±5.89% ±7.67%
01:28:09 streams/writable-manywrites.js len=1024 callback='no' writev='yes' sync='no' n=2000000 0.34 % ±2.34% ±3.11% ±4.05%
01:28:09 streams/writable-manywrites.js len=1024 callback='no' writev='yes' sync='yes' n=2000000 0.73 % ±3.60% ±4.79% ±6.24%
01:28:09 streams/writable-manywrites.js len=1024 callback='yes' writev='no' sync='no' n=2000000 -0.38 % ±1.37% ±1.82% ±2.38%
01:28:09 streams/writable-manywrites.js len=1024 callback='yes' writev='no' sync='yes' n=2000000 -1.99 % ±3.29% ±4.37% ±5.69%
01:28:09 streams/writable-manywrites.js len=1024 callback='yes' writev='yes' sync='no' n=2000000 1.05 % ±2.07% ±2.76% ±3.59%
01:28:09 streams/writable-manywrites.js len=1024 callback='yes' writev='yes' sync='yes' n=2000000 -0.82 % ±2.90% ±3.87% ±5.03%
01:28:09 streams/writable-manywrites.js len=32768 callback='no' writev='no' sync='no' n=2000000 0.30 % ±1.48% ±1.97% ±2.56%
01:28:09 streams/writable-manywrites.js len=32768 callback='no' writev='no' sync='yes' n=2000000 -2.36 % ±3.70% ±4.93% ±6.42%
01:28:09 streams/writable-manywrites.js len=32768 callback='no' writev='yes' sync='no' n=2000000 -1.18 % ±2.66% ±3.56% ±4.66%
01:28:09 streams/writable-manywrites.js len=32768 callback='no' writev='yes' sync='yes' n=2000000 -1.09 % ±3.20% ±4.26% ±5.54%
01:28:09 streams/writable-manywrites.js len=32768 callback='yes' writev='no' sync='no' n=2000000 -1.25 % ±3.54% ±4.73% ±6.20%
01:28:09 streams/writable-manywrites.js len=32768 callback='yes' writev='no' sync='yes' n=2000000 -1.66 % ±3.22% ±4.29% ±5.59%
01:28:09 streams/writable-manywrites.js len=32768 callback='yes' writev='yes' sync='no' n=2000000 * 3.31 % ±3.05% ±4.08% ±5.34%
01:28:09 streams/writable-manywrites.js len=32768 callback='yes' writev='yes' sync='yes' n=2000000 1.51 % ±4.08% ±5.43% ±7.09%
01:28:09
01:28:09 Be aware that when doing many comparisons the risk of a false-positive
01:28:09 result increases. In this case there are 30 comparisons, you can thus
01:28:09 expect the following amount of false-positive results:
01:28:09 1.50 false positives, when considering a 5% risk acceptance (*, **, ***),
01:28:09 0.30 false positives, when considering a 1% risk acceptance (**, ***),
01:28:09 0.03 false positives, when considering a 0.1% risk acceptance (***) |
lundibundi
approved these changes
Aug 29, 2020
lundibundi
added
the
author ready
rickyes
approved these changes
Aug 30, 2020
Trott
pushed a commit
that referenced
this pull request
Aug 30, 2020
Previously, the `.push()` or `.unshift()` call would just have jumped straight to emitting a `'data'` event, even if there were no listeners, effectively just silently dropping the chunk. PR-URL: #34957 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Denys Otrishko <[email protected]> Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Ricky Zhou <[email protected]>
|
Landed in c1ef122 |
richardlau
pushed a commit
that referenced
this pull request
Sep 1, 2020
Previously, the `.push()` or `.unshift()` call would just have jumped straight to emitting a `'data'` event, even if there were no listeners, effectively just silently dropping the chunk. PR-URL: #34957 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Denys Otrishko <[email protected]> Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Ricky Zhou <[email protected]>
addaleax
added a commit
that referenced
this pull request
Sep 22, 2020
Previously, the `.push()` or `.unshift()` call would just have jumped straight to emitting a `'data'` event, even if there were no listeners, effectively just silently dropping the chunk. PR-URL: #34957 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Denys Otrishko <[email protected]> Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Ricky Zhou <[email protected]>
addaleax
added a commit
that referenced
this pull request
Sep 22, 2020
Previously, the `.push()` or `.unshift()` call would just have jumped straight to emitting a `'data'` event, even if there were no listeners, effectively just silently dropping the chunk. PR-URL: #34957 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Denys Otrishko <[email protected]> Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Ricky Zhou <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the
.push()or.unshift()call would just have jumpedstraight to emitting a
'data'event, even if there were no listeners,effectively just silently dropping the chunk.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes