From 63153c5a33c9aa6a50b129711e3d6e49621c5c2c Mon Sep 17 00:00:00 2001 From: gengjiawen Date: Fri, 19 Jun 2020 22:10:15 +0800 Subject: [PATCH] quic: fix clang warning --- src/quic/node_quic_crypto.cc | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/quic/node_quic_crypto.cc b/src/quic/node_quic_crypto.cc index 4b4ec901001f40..491fbcf1109100 100644 --- a/src/quic/node_quic_crypto.cc +++ b/src/quic/node_quic_crypto.cc @@ -560,7 +560,9 @@ Local GetALPNProtocol(const QuicSession& session) { QuicCryptoContext* ctx = session.crypto_context(); Environment* env = session.env(); std::string alpn = ctx->selected_alpn(); - if (alpn == NGTCP2_ALPN_H3 + 1) { + // This supposed to be `NGTCP2_ALPN_H3 + 1` + // Details see https://github.com/nodejs/node/issues/33959 + if (alpn == &NGTCP2_ALPN_H3[1]) { return env->quic_alpn_string(); } else { return ToV8Value(