diff --git a/src/node_url.cc b/src/node_url.cc index 8751588d8bf309..a181d5fb5d8d7c 100644 --- a/src/node_url.cc +++ b/src/node_url.cc @@ -1488,7 +1488,7 @@ void URL::Parse(const char* input, state = kSpecialRelativeOrAuthority; } else if (special) { state = kSpecialAuthoritySlashes; - } else if (p[1] == '/') { + } else if (p + 1 < end && p[1] == '/') { state = kPathOrAuthority; p++; } else { @@ -1548,7 +1548,7 @@ void URL::Parse(const char* input, } break; case kSpecialRelativeOrAuthority: - if (ch == '/' && p[1] == '/') { + if (ch == '/' && p + 1 < end && p[1] == '/') { state = kSpecialAuthorityIgnoreSlashes; p++; } else { @@ -1696,7 +1696,7 @@ void URL::Parse(const char* input, break; case kSpecialAuthoritySlashes: state = kSpecialAuthorityIgnoreSlashes; - if (ch == '/' && p[1] == '/') { + if (ch == '/' && p + 1 < end && p[1] == '/') { p++; } else { continue; diff --git a/test/cctest/test_url.cc b/test/cctest/test_url.cc index 96f9741386360f..2e78b24a5e3424 100644 --- a/test/cctest/test_url.cc +++ b/test/cctest/test_url.cc @@ -81,6 +81,26 @@ TEST_F(URLTest, Base3) { EXPECT_EQ(simple.path(), "/baz"); } +TEST_F(URLTest, TruncatedAfterProtocol) { + char input[2] = { 'q', ':' }; + URL simple(input, sizeof(input)); + + EXPECT_FALSE(simple.flags() & URL_FLAGS_FAILED); + EXPECT_EQ(simple.protocol(), "q:"); + EXPECT_EQ(simple.host(), ""); + EXPECT_EQ(simple.path(), "/"); +} + +TEST_F(URLTest, TruncatedAfterProtocol2) { + char input[6] = { 'h', 't', 't', 'p', ':', '/' }; + URL simple(input, sizeof(input)); + + EXPECT_TRUE(simple.flags() & URL_FLAGS_FAILED); + EXPECT_EQ(simple.protocol(), "http:"); + EXPECT_EQ(simple.host(), ""); + EXPECT_EQ(simple.path(), ""); +} + TEST_F(URLTest, ToFilePath) { #define T(url, path) EXPECT_EQ(path, URL(url).ToFilePath()) T("http://example.org/foo/bar", "");