From d9b5672ecacb68caa02600aaafb48013f360ccc2 Mon Sep 17 00:00:00 2001 From: Anna Henningsen Date: Tue, 14 Apr 2020 19:01:29 +0200 Subject: [PATCH] tools: fix mkcodecache when run with ASAN Fixes: https://github.com/nodejs/node/issues/32835 --- tools/code_cache/mkcodecache.cc | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/tools/code_cache/mkcodecache.cc b/tools/code_cache/mkcodecache.cc index 34af7bc61ba374..23df0f69317b8b 100644 --- a/tools/code_cache/mkcodecache.cc +++ b/tools/code_cache/mkcodecache.cc @@ -49,8 +49,8 @@ int main(int argc, char* argv[]) { // Create a new Isolate and make it the current one. Isolate::CreateParams create_params; - create_params.array_buffer_allocator = - ArrayBuffer::Allocator::NewDefaultAllocator(); + create_params.array_buffer_allocator_shared.reset( + ArrayBuffer::Allocator::NewDefaultAllocator()); Isolate* isolate = Isolate::New(create_params); { Isolate::Scope isolate_scope(isolate); @@ -65,6 +65,7 @@ int main(int argc, char* argv[]) { out << cache; out.close(); } + isolate->Dispose(); v8::V8::ShutdownPlatform(); return 0;