From e9688651f3e1a7a2a48d53ed428a7c08f5604078 Mon Sep 17 00:00:00 2001
From: Harshitha KP <harshi46@in.ibm.com>
Date: Mon, 13 Jan 2020 08:15:50 -0500
Subject: [PATCH 1/4] doc: document missing properties in child_process

fixes:https://github.com/nodejs/node/issues/27206
---
 doc/api/child_process.md | 35 +++++++++++++++++++++++++++++++++++
 1 file changed, 35 insertions(+)

diff --git a/doc/api/child_process.md b/doc/api/child_process.md
index f9b0ebf1f92a05..3bcd90be9c2428 100644
--- a/doc/api/child_process.md
+++ b/doc/api/child_process.md
@@ -1075,6 +1075,13 @@ When the child process is a Node.js instance (e.g. spawned using
 [`child_process.fork()`][]), the `process.disconnect()` method can be invoked
 within the child process to close the IPC channel as well.
 
+###subprocess.exitCode:
+
+* {integer}
+
+`subprocess.exitcode` property indicates  exit code of the child process.
+If child process is still running, the field will be null.
+
 ### `subprocess.kill([signal])`
 <!-- YAML
 added: v0.1.90
@@ -1368,6 +1375,34 @@ It is also recommended that any `'message'` handlers in the child process
 verify that `socket` exists, as the connection may have been closed during the
 time it takes to send the connection to the child.
 
+###subprocess.signalCode:
+
+* {integer}
+
+`subprocess.signalCode` property indicates the signal number received by
+the child process if any, from the parent node prcess, else null.
+
+###subprocess.spawnfie:
+
+* {string}
+
+`subprocess.spawnfile` property indicates the executable file name of
+the child process that is launched.
+
+For [`child_process.fork()`][], its value will be equal to
+[`process.execPath`][].
+For [`child_process.spawn()`][], its value will be the name of
+the executable file.
+For [`child_process.exec()`][],  its value will be the name of the shell
+in which the child process is launched.
+
+###subprocess.spawnargs:
+
+* {Array}
+
+`subprocess.spawnargs` property represents the full list of command line
+arguments the child process was launched with.
+
 ### `subprocess.stderr`
 <!-- YAML
 added: v0.1.90

From 9a2db08cedfe585e0da0bcb12dfcd6c266547789 Mon Sep 17 00:00:00 2001
From: Harshitha KP <harshi46@in.ibm.com>
Date: Mon, 13 Jan 2020 23:40:54 -0500
Subject: [PATCH 2/4] fixup: address review comments

---
 doc/api/child_process.md | 20 ++++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)

diff --git a/doc/api/child_process.md b/doc/api/child_process.md
index 3bcd90be9c2428..ee5b03a32e28bd 100644
--- a/doc/api/child_process.md
+++ b/doc/api/child_process.md
@@ -1075,12 +1075,12 @@ When the child process is a Node.js instance (e.g. spawned using
 [`child_process.fork()`][]), the `process.disconnect()` method can be invoked
 within the child process to close the IPC channel as well.
 
-###subprocess.exitCode:
+###`subprocess.exitCode`
 
 * {integer}
 
-`subprocess.exitcode` property indicates  exit code of the child process.
-If child process is still running, the field will be null.
+The `subprocess.exitcode` property indicates the exit code of the child process.
+If the child process is still running, the field will be null.
 
 ### `subprocess.kill([signal])`
 <!-- YAML
@@ -1375,18 +1375,18 @@ It is also recommended that any `'message'` handlers in the child process
 verify that `socket` exists, as the connection may have been closed during the
 time it takes to send the connection to the child.
 
-###subprocess.signalCode:
+###`subprocess.signalCode`
 
 * {integer}
 
-`subprocess.signalCode` property indicates the signal number received by
-the child process if any, from the parent node prcess, else null.
+The `subprocess.signalCode` property indicates the signal number received by
+the child process if any, else null.
 
-###subprocess.spawnfie:
+###`subprocess.spawnfile`
 
 * {string}
 
-`subprocess.spawnfile` property indicates the executable file name of
+The `subprocess.spawnfile` property indicates the executable file name of
 the child process that is launched.
 
 For [`child_process.fork()`][], its value will be equal to
@@ -1396,11 +1396,11 @@ the executable file.
 For [`child_process.exec()`][],  its value will be the name of the shell
 in which the child process is launched.
 
-###subprocess.spawnargs:
+###`subprocess.spawnargs`
 
 * {Array}
 
-`subprocess.spawnargs` property represents the full list of command line
+The `subprocess.spawnargs` property represents the full list of command line
 arguments the child process was launched with.
 
 ### `subprocess.stderr`

From a0b0d68faa3b90af62fe9ec127497cf4786dae52 Mon Sep 17 00:00:00 2001
From: Harshitha KP <harshi46@in.ibm.com>
Date: Tue, 14 Jan 2020 08:39:07 -0500
Subject: [PATCH 3/4] fixup: address review comment

---
 doc/api/child_process.md | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/doc/api/child_process.md b/doc/api/child_process.md
index ee5b03a32e28bd..6e9b74374c8eea 100644
--- a/doc/api/child_process.md
+++ b/doc/api/child_process.md
@@ -1075,7 +1075,7 @@ When the child process is a Node.js instance (e.g. spawned using
 [`child_process.fork()`][]), the `process.disconnect()` method can be invoked
 within the child process to close the IPC channel as well.
 
-###`subprocess.exitCode`
+### `subprocess.exitCode`
 
 * {integer}
 
@@ -1375,14 +1375,14 @@ It is also recommended that any `'message'` handlers in the child process
 verify that `socket` exists, as the connection may have been closed during the
 time it takes to send the connection to the child.
 
-###`subprocess.signalCode`
+### `subprocess.signalCode`
 
 * {integer}
 
 The `subprocess.signalCode` property indicates the signal number received by
 the child process if any, else null.
 
-###`subprocess.spawnfile`
+### `subprocess.spawnfile`
 
 * {string}
 
@@ -1396,7 +1396,7 @@ the executable file.
 For [`child_process.exec()`][],  its value will be the name of the shell
 in which the child process is launched.
 
-###`subprocess.spawnargs`
+### `subprocess.spawnargs`
 
 * {Array}
 

From 4f9931b2ccc0422321129374eb82b7d4acec84cc Mon Sep 17 00:00:00 2001
From: Harshitha KP <harshi46@in.ibm.com>
Date: Thu, 16 Jan 2020 00:16:49 -0500
Subject: [PATCH 4/4] fixup: address review comment

---
 doc/api/child_process.md | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/doc/api/child_process.md b/doc/api/child_process.md
index 6e9b74374c8eea..5e695a3a510ca2 100644
--- a/doc/api/child_process.md
+++ b/doc/api/child_process.md
@@ -1382,6 +1382,13 @@ time it takes to send the connection to the child.
 The `subprocess.signalCode` property indicates the signal number received by
 the child process if any, else null.
 
+### `subprocess.spawnargs`
+
+* {Array}
+
+The `subprocess.spawnargs` property represents the full list of command line
+arguments the child process was launched with.
+
 ### `subprocess.spawnfile`
 
 * {string}
@@ -1396,13 +1403,6 @@ the executable file.
 For [`child_process.exec()`][],  its value will be the name of the shell
 in which the child process is launched.
 
-### `subprocess.spawnargs`
-
-* {Array}
-
-The `subprocess.spawnargs` property represents the full list of command line
-arguments the child process was launched with.
-
 ### `subprocess.stderr`
 <!-- YAML
 added: v0.1.90