-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
http: use internal/debuglog directly in lib/_http_agent.js #26567
Conversation
@micheleriva thanks for your PR! Please have another look at the commit guidelines again. |
@micheleriva Can you checkout the commit guidelines and rewrite the commit message? BTW, please remove the |
@joyeecheung we can fix the commit message while landing. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
CI: https://ci.nodejs.org/job/node-test-pull-request/22196/ ✅ (besides Windows) |
@micheleriva I am very sorry but it seems like this change has already landed in Node.js else wise. Thanks a lot for your contribution and keep up the good work! |
This PR reduces internal usage of public require('util').
Single PR as asked here: #26546 (comment)
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes