From 3db07ff5cb4a4712d4e43635c1591c3d9a18ef33 Mon Sep 17 00:00:00 2001
From: Matteo Collina <hello@matteocollina.com>
Date: Thu, 22 Nov 2018 17:36:17 +0100
Subject: [PATCH 1/3] doc: document fs.write limitation with TTY

Fixes: https://github.com/nodejs/node/issues/24550
---
 doc/api/fs.md | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/doc/api/fs.md b/doc/api/fs.md
index e73fd1ad26ed27..0f5e88fbc8aaa6 100644
--- a/doc/api/fs.md
+++ b/doc/api/fs.md
@@ -3528,6 +3528,13 @@ On Linux, positional writes don't work when the file is opened in append mode.
 The kernel ignores the position argument and always appends the data to
 the end of the file.
 
+On Windows, if the file descriptor is connected to the console (e.g. `fd == 1`
+or `stdout`) a string encoded as UTF-8 or Unicode (`ucs2`) will not be rendered
+properly by default.
+It is possible to configure the console to render UTF-8 properly by changing the
+active codepage with the `chcp 65001` command. See the [chcp][] docs for more
+details.
+
 ## fs.writeFile(file, data[, options], callback)
 <!-- YAML
 added: v0.1.29
@@ -4926,3 +4933,4 @@ the file contents.
 [MSDN-Using-Streams]: https://docs.microsoft.com/en-us/windows/desktop/FileIO/using-streams
 [support of file system `flags`]: #fs_file_system_flags
 [File Access Constants]: #fs_file_access_constants
+[chcp]: https://ss64.com/nt/chcp.html

From aa1e3f4b5de873ab928b651c06dda6680716a723 Mon Sep 17 00:00:00 2001
From: Anna Henningsen <github@addaleax.net>
Date: Sat, 24 Nov 2018 10:52:08 +0100
Subject: [PATCH 2/3] Update doc/api/fs.md

Co-Authored-By: mcollina <matteo.collina@gmail.com>
---
 doc/api/fs.md | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/doc/api/fs.md b/doc/api/fs.md
index 0f5e88fbc8aaa6..7451bad93be858 100644
--- a/doc/api/fs.md
+++ b/doc/api/fs.md
@@ -3529,7 +3529,7 @@ The kernel ignores the position argument and always appends the data to
 the end of the file.
 
 On Windows, if the file descriptor is connected to the console (e.g. `fd == 1`
-or `stdout`) a string encoded as UTF-8 or Unicode (`ucs2`) will not be rendered
+or `stdout`) a string containing non-ASCII characters will not be rendered
 properly by default.
 It is possible to configure the console to render UTF-8 properly by changing the
 active codepage with the `chcp 65001` command. See the [chcp][] docs for more

From 85f4a5b42927a34dfe55d4b4ea640e15774a1a78 Mon Sep 17 00:00:00 2001
From: Nikolai Vavilov <vvnicholas@gmail.com>
Date: Sat, 24 Nov 2018 13:31:21 +0100
Subject: [PATCH 3/3] Update doc/api/fs.md

Co-Authored-By: mcollina <matteo.collina@gmail.com>
---
 doc/api/fs.md | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/doc/api/fs.md b/doc/api/fs.md
index 7451bad93be858..f7727e88008771 100644
--- a/doc/api/fs.md
+++ b/doc/api/fs.md
@@ -3530,7 +3530,7 @@ the end of the file.
 
 On Windows, if the file descriptor is connected to the console (e.g. `fd == 1`
 or `stdout`) a string containing non-ASCII characters will not be rendered
-properly by default.
+properly by default, regardless of the encoding used.
 It is possible to configure the console to render UTF-8 properly by changing the
 active codepage with the `chcp 65001` command. See the [chcp][] docs for more
 details.