Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parallel/test-abortsignal-drop-settled-signals is flaky #56190

Closed
jazelly opened this issue Dec 9, 2024 · 2 comments · Fixed by #56197
Closed

parallel/test-abortsignal-drop-settled-signals is flaky #56190

jazelly opened this issue Dec 9, 2024 · 2 comments · Fixed by #56197
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI.

Comments

@jazelly
Copy link
Member

jazelly commented Dec 9, 2024

Test

test-abortsignal-drop-settled-signals

Platform

No response

Console output

duration_ms: 736.616
exitcode: 1
severity: fail
stack: "\u25B6 when there is a long-lived signal\n  \u2714 drops settled dependant\
  \ signals (164.84014ms)\n  \u2714 keeps all active dependant signals (61.703679ms)\n\
  \u2714 when there is a long-lived signal (227.848054ms)\n\u2714 does not prevent\
  \ source signal from being GCed if it is short-lived (78.327808ms)\n\u2716 drops\
  \ settled dependant signals when signal is composite (9.638435ms)\n  AssertionError\
  \ [ERR_ASSERTION]: Expected values to be strictly equal:\n\n  2 !== 0\n\n      at\
  \ assert.<computed> [as strictEqual] (node:internal/test_runner/test:263:18)\n \
  \     at Immediate._onImmediate (file:///home/iojs/build/workspace/node-test-commit-linuxone/test/parallel/test-abortsignal-drop-settled-signals.mjs:151:16)\n\
  \      at process.processImmediate (node:internal/timers:511:21) {\n    generatedMessage:\
  \ true,\n    code: 'ERR_ASSERTION',\n    actual: 2,\n    expected: 0,\n    operator:\
  \ 'strictEqual'\n  }\n\n\u2714 drops settled signals even when there are listeners\
  \ (176.35303ms)\n\u2139 tests 5\n\u2139 suites 1\n\u2139 pass 4\n\u2139 fail 1\n\
  \u2139 cancelled 0\n\u2139 skipped 0\n\u2139 todo 0\n\u2139 duration_ms 496.249118\n\
  \n\u2716 failing tests:\n\ntest at test/parallel/test-abortsignal-drop-settled-signals.mjs:134:1\n\
  \u2716 drops settled dependant signals when signal is composite (9.638435ms)\n \
  \ AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:\n\n  2 !==\
  \ 0\n\n      at assert.<computed> [as strictEqual] (node:internal/test_runner/test:263:18)\n\
  \      at Immediate._onImmediate (file:///home/iojs/build/workspace/node-test-commit-linuxone/test/parallel/test-abortsignal-drop-settled-signals.mjs:151:16)\n\
  \      at process.processImmediate (node:internal/timers:511:21) {\n    generatedMessage:\
  \ true,\n    code: 'ERR_ASSERTION',\n    actual: 2,\n    expected: 0,\n    operator:\
  \ 'strictEqual'\n  }"

Build links

Additional information

Reliability report: nodejs/reliability#1052

@jazelly jazelly added the flaky-test Issues and PRs related to the tests with unstable failures on the CI. label Dec 9, 2024
@geeksilva97
Copy link
Contributor

geeksilva97 commented Dec 9, 2024

Might it be my latest changes in this file? I will check it.

EDIT: It is. It was not like this before. I'm on it.

@geeksilva97
Copy link
Contributor

PR is in place @jazelly . Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants