SyntaxError bug : Coding style problem

[jefftham]

• Version: v4.3.0
• Platform: Linux kharto-dev01 3.16.0-4-amd64 deps: update openssl to 1.0.1j #1 SMP Debian 3.16.7-ckt11-1+deb8u5 (2015-10-09) x86_64 GNU/Linux

i found a bug that node.js stop me the code differently.

Please refer the the following code:-

//no error
var maximum = Math.max(
1,
10);

//error show
var maximum = Math.max(
1
,10);

// error show
var maximum = Math.max(
1,
10
);

I believe the above code should produce the same result, the position of the comma and closing bracket should not affect the result.

However, node.js throw an error message as:-

SyntaxError: missing ) after argument list

I tested the code in node version 0.12.4, no error shown.

[princejwesley]

Working fine in v5.7.0 and master branch.

node 🙈 ₹ uname -a
Darwin Princes-MacBook-Pro.local 15.3.0 Darwin Kernel Version 15.3.0: Thu Dec 10 18:40:58 PST 2015; root:xnu-3248.30.4~1/RELEASE_X86_64 x86_64

[cjihrig]

I assume you're talking about the REPL. It looks like it was fixed in #3823, which was released in 5.7.0.

I'm going to close this. Please let me know if it is not actually fixed.

[princejwesley]

@cjihrig #4060 can be closed.

[cjihrig]

Thanks @princejwesley, I'll close it.

[jefftham]

Thank for your prompt reply, i know that this problem is fixed in v5.7.0
but my company only allows us to use v4.x

can i know if this problem going to solve in node version 4 ?

[cjihrig]

It doesn't look like #3823 has been marked for LTS backport. @jasnell are you planning to backport, or is the semver-minor label blocking it?

[MylesBorins]

Currently #3823 is not scheduled for back-port. It was a semver-minor change that introduced a new feature.

@jefftham is this something that is breaking for you in production, or is more of an inconvenience?

[jefftham]

it just breaks some code that we wrote in v 0.12.4 ,
anyhow, Thanks a lot for helping me. Really appreciate.

[cjihrig]

FWIW, I don't really see #3823 as semver-minor. I would classify it as fixing an existing bug.

[MylesBorins]

@cjihrig would you chime in as much in the issue? Perhaps we could back port it.

[cjihrig]

Sure. Done.