-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
http2: trailers or response to be emitted? #41251
Comments
👍 |
Following: then const http2 = require('http2');
const server = http2.createServer((request, response) => {
response.end(); // just empty end, nothing else
});
server.listen(() => {
const { port } = server.address();
const session = http2.connect(`http://localhost:${port}`);
const request = session.request({
':path': '/',
':method': 'GET',
});
request.on('response', (headers) => {
console.log('got response', headers);
});
request.on('headers', () => {
console.log('got headers');
});
request.on('trailers', (trailers) => {
console.log('got trailers', trailers);
});
request.end();
request.resume();
request.on('end', () => {
session.close();
server.close();
});
});
I think it should emit |
I think HTTP/2 should be consistent with HTTP/1 behavior. About the above case, they shouldn't emit |
@MoonBall Please note that in the original issue it emits |
In the original issue I think it should emit |
Duplicate of #38258 |
Version
v17.3.0
Platform
Linux pop-os 5.15.5-76051505-generic #202111250933~1638201579~21.04~09f1aa7-Ubuntu SMP Tue Nov 30 02: x86_64 x86_64 x86_64 GNU/Linux
Subsystem
http2
What steps will reproduce the bug?
How often does it reproduce? Is there a required condition?
Always.
What is the expected behavior?
What do you see instead?
got headers +got trailers [Object: null prototype] { ':status': 200, date: 'Mon, 20 Dec 2021 08:27:48 GMT', [Symbol(nodejs.http2.sensitiveHeaders)]: [] }
Additional information
I'm not sure if this is the expected behavior. HTTP/1 for comparison (trailers are empty):
The text was updated successfully, but these errors were encountered: