Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limiting require to Sub-package exports was a bad idea #39619

Closed
alexp1917 opened this issue Aug 1, 2021 · 1 comment
Closed

Limiting require to Sub-package exports was a bad idea #39619

alexp1917 opened this issue Aug 1, 2021 · 1 comment
Labels
duplicate Issues and PRs that are duplicates of other issues or PRs.

Comments

@alexp1917
Copy link

alexp1917 commented Aug 1, 2021

Version

16.6.0

Platform

Linux HOST 5.4.0-80-generic #90-Ubuntu SMP Fri Jul 9 22:49:44 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Subsystem

No response

What steps will reproduce the bug?

the docs themselves agree that this change will break things - https://nodejs.org/api/all.html#packages_package_entry_points

How often does it reproduce? Is there a required condition?

require('your-package/package.json') is a well known way to get the reflective property of what version of a module you have loaded.

What is the expected behavior?

the people who run node prevent bad ideas from being merged into the main release

What do you see instead?

the community failing to admitt that a decision was wrong + rolling it back

Additional information

thanks for reading

@aduh95 aduh95 added the duplicate Issues and PRs that are duplicates of other issues or PRs. label Aug 1, 2021
@aduh95
Copy link
Contributor

aduh95 commented Aug 1, 2021

Looks like a duplicate of #33460, see the discussion there for workaround and replacement API design discussion.

@aduh95 aduh95 closed this as completed Aug 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate Issues and PRs that are duplicates of other issues or PRs.
Projects
None yet
Development

No branches or pull requests

2 participants