-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor EventTarget correctness issues #33773
Comments
Thanks for noticing, I should have probably also used the primordial, I will make a PR to fix this. |
This is probably also true for |
codebytere
pushed a commit
that referenced
this issue
Jun 22, 2020
PR-URL: #33775 Fixes: #33773 Reviewed-By: Denys Otrishko <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Zeyu Yang <[email protected]> Reviewed-By: James M Snell <[email protected]>
codebytere
pushed a commit
that referenced
this issue
Jun 30, 2020
PR-URL: #33775 Fixes: #33773 Reviewed-By: Denys Otrishko <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Zeyu Yang <[email protected]> Reviewed-By: James M Snell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I just noticed some very minor things while idly browsing recent node commits. /cc @benjamingr.
Per Web IDL,
EventTarget.prototype[Symbol.toStringTag]
should be a data property, not a getter. The commit above introduced it as a getter.Note that url.js appears to do this correctly using the
defineIDLClass
function, which perhaps should be shared.isTrusted
should not have a setter. It should only have a getter, since it is declared as areadonly
Web IDL attribute.The text was updated successfully, but these errors were encountered: