Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor EventTarget correctness issues #33773

Closed
domenic opened this issue Jun 6, 2020 · 2 comments
Closed

Minor EventTarget correctness issues #33773

domenic opened this issue Jun 6, 2020 · 2 comments

Comments

@domenic
Copy link
Contributor

domenic commented Jun 6, 2020

I just noticed some very minor things while idly browsing recent node commits. /cc @benjamingr.

  • Version: 56e4460
  • Subsystem: events

Per Web IDL, EventTarget.prototype[Symbol.toStringTag] should be a data property, not a getter. The commit above introduced it as a getter.

Note that url.js appears to do this correctly using the defineIDLClass function, which perhaps should be shared.

  • Version: 2d071e7
  • Subsystem: events

isTrusted should not have a setter. It should only have a getter, since it is declared as a readonly Web IDL attribute.

@benjamingr
Copy link
Member

Thanks for noticing, I should have probably also used the primordial, I will make a PR to fix this.

@benjamingr
Copy link
Member

This is probably also true for Event, I will fix it there too.

codebytere pushed a commit that referenced this issue Jun 22, 2020
PR-URL: #33775
Fixes: #33773
Reviewed-By: Denys Otrishko <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Zeyu Yang <[email protected]>
Reviewed-By: James M Snell <[email protected]>
codebytere pushed a commit that referenced this issue Jun 30, 2020
PR-URL: #33775
Fixes: #33773
Reviewed-By: Denys Otrishko <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Zeyu Yang <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants