Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wasi unit tests failing #30989

Closed
AdamMajer opened this issue Dec 16, 2019 · 5 comments
Closed

wasi unit tests failing #30989

AdamMajer opened this issue Dec 16, 2019 · 5 comments
Labels
wasi Issues and PRs related to the WebAssembly System Interface.

Comments

@AdamMajer
Copy link
Contributor

  • Version: master
  • Platform: openSUSE Tumbleweed
  • Subsystem: tests

https://build.opensuse.org/build/devel:languages:nodejs:staging/openSUSE_Tumbleweed/x86_64/nodejs42/_log

[ 1683s] not ok 2546 wasi/test-wasi
[ 1683s]   ---
[ 1683s]   duration_ms: 16.756
[ 1683s]   severity: fail
[ 1683s]   exitcode: 1
[ 1683s]   stack: |-
[ 1683s]     executing cant_dotdot
[ 1683s]     (node:12925) ExperimentalWarning: WASI is an experimental feature. This feature could change at any time
[ 1683s]     fd_prestat_get(3, 69696)
[ 1683s]     fd_prestat_dir_name(3, 131232, 9)
[ 1683s]     fd_fdstat_get(3, 69672)
[ 1683s]     fd_prestat_get(4, 69696)
[ 1683s]     fd_prestat_dir_name(4, 131232, 5)
[ 1683s]     fd_fdstat_get(4, 69672)
[ 1683s]     fd_prestat_get(5, 69696)
[ 1683s]     environ_sizes_get(69696, 69708)
[ 1683s]     environ_get(131280, 131536)
[ 1683s]     args_sizes_get(69708, 69696)
[ 1683s]     fd_fdstat_get(3, 69608)
[ 1683s]     path_open(3, 1, 1033, 14, 0, 264240830, 268435455, 0, 69604)
[ 1683s]     
[ 1683s]     executing clock_getres
[ 1683s]     (node:12932) ExperimentalWarning: WASI is an experimental feature. This feature could change at any time
[ 1683s]     fd_prestat_get(3, 69664)
[ 1683s]     fd_prestat_dir_name(3, 131232, 9)
[ 1683s]     fd_fdstat_get(3, 69640)
[ 1683s]     fd_prestat_get(4, 69664)
[ 1683s]     fd_prestat_dir_name(4, 131232, 5)
[ 1683s]     fd_fdstat_get(4, 69640)
[ 1683s]     fd_prestat_get(5, 69664)
[ 1683s]     environ_sizes_get(69664, 69676)
[ 1683s]     environ_get(131280, 131536)
[ 1683s]     args_sizes_get(69676, 69664)
[ 1683s]     clock_res_get(0, 69624)
[ 1683s]     clock_res_get(1, 69624)
[ 1683s]     clock_res_get(2, 69624)
[ 1683s]     clock_res_get(3, 69624)
[ 1683s]     
[ 1683s]     executing exitcode
[ 1683s]     (node:12950) ExperimentalWarning: WASI is an experimental feature. This feature could change at any time
[ 1683s]     fd_prestat_get(3, 67056)
[ 1683s]     fd_prestat_dir_name(3, 131232, 9)
[ 1683s]     fd_fdstat_get(3, 67032)
[ 1683s]     fd_prestat_get(4, 67056)
[ 1683s]     fd_prestat_dir_name(4, 131232, 5)
[ 1683s]     fd_fdstat_get(4, 67032)
[ 1683s]     fd_prestat_get(5, 67056)
[ 1683s]     environ_sizes_get(67056, 67068)
[ 1683s]     environ_get(131280, 131536)
[ 1683s]     args_sizes_get(67068, 67056)
[ 1683s]     proc_exit(120)
[ 1683s]     
[ 1683s]     executing fd_prestat_get_refresh
[ 1683s]     (node:12957) ExperimentalWarning: WASI is an experimental feature. This feature could change at any time
[ 1683s]     fd_prestat_get(3, 67056)
[ 1683s]     fd_prestat_dir_name(3, 131232, 9)
[ 1683s]     fd_fdstat_get(3, 67032)
[ 1683s]     fd_prestat_get(4, 67056)
[ 1683s]     fd_prestat_dir_name(4, 131232, 5)
[ 1683s]     fd_fdstat_get(4, 67032)
[ 1683s]     fd_prestat_get(5, 67056)
[ 1683s]     environ_sizes_get(67056, 67068)
[ 1683s]     environ_get(131280, 131536)
[ 1683s]     args_sizes_get(67068, 67056)
[ 1683s]     fd_fdstat_get(1, 67016)
[ 1683s]     fd_fdstat_get(1, 67016)
[ 1683s]     
[ 1683s]     executing getentropy
[ 1683s]     (node:12964) ExperimentalWarning: WASI is an experimental feature. This feature could change at any time
[ 1683s]     fd_prestat_get(3, 69632)
[ 1683s]     fd_prestat_dir_name(3, 131232, 9)
[ 1683s]     fd_fdstat_get(3, 69608)
[ 1683s]     fd_prestat_get(4, 69632)
[ 1683s]     fd_prestat_dir_name(4, 131232, 5)
[ 1683s]     fd_fdstat_get(4, 69608)
[ 1683s]     fd_prestat_get(5, 69632)
[ 1683s]     environ_sizes_get(69632, 69644)
[ 1683s]     environ_get(131280, 131536)
[ 1683s]     args_sizes_get(69644, 69632)
[ 1683s]     random_get(69360, 256)
[ 1683s]     
[ 1683s]     executing getrusage
[ 1683s]     (node:12971) ExperimentalWarning: WASI is an experimental feature. This feature could change at any time
[ 1683s]     fd_prestat_get(3, 69664)
[ 1683s]     fd_prestat_dir_name(3, 131232, 9)
[ 1683s]     fd_fdstat_get(3, 69640)
[ 1683s]     fd_prestat_get(4, 69664)
[ 1683s]     fd_prestat_dir_name(4, 131232, 5)
[ 1683s]     fd_fdstat_get(4, 69640)
[ 1683s]     fd_prestat_get(5, 69664)
[ 1683s]     environ_sizes_get(69664, 69676)
[ 1683s]     environ_get(131280, 131536)
[ 1683s]     args_sizes_get(69676, 69664)
[ 1683s]     clock_time_get(2, 1000, 69528)
[ 1683s]     clock_time_get(2, 1000, 69528)
[ 1683s]     
[ 1683s]     executing gettimeofday
[ 1683s]     (node:12978) ExperimentalWarning: WASI is an experimental feature. This feature could change at any time
[ 1683s]     fd_prestat_get(3, 69664)
[ 1683s]     fd_prestat_dir_name(3, 131232, 9)
[ 1683s]     fd_fdstat_get(3, 69640)
[ 1683s]     fd_prestat_get(4, 69664)
[ 1683s]     fd_prestat_dir_name(4, 131232, 5)
[ 1683s]     fd_fdstat_get(4, 69640)
[ 1683s]     fd_prestat_get(5, 69664)
[ 1683s]     environ_sizes_get(69664, 69676)
[ 1683s]     environ_get(131280, 131536)
[ 1683s]     args_sizes_get(69676, 69664)
[ 1683s]     clock_time_get(0, 1000, 69560)
[ 1683s]     clock_time_get(0, 1000, 69560)
[ 1683s]     
[ 1683s]     executing notdir
[ 1683s]     (node:13003) ExperimentalWarning: WASI is an experimental feature. This feature could change at any time
[ 1683s]     fd_prestat_get(3, 69680)
[ 1683s]     fd_prestat_dir_name(3, 131232, 9)
[ 1683s]     fd_fdstat_get(3, 69656)
[ 1683s]     fd_prestat_get(4, 69680)
[ 1683s]     fd_prestat_dir_name(4, 131232, 5)
[ 1683s]     fd_fdstat_get(4, 69656)
[ 1683s]     fd_prestat_get(5, 69680)
[ 1683s]     environ_sizes_get(69680, 69692)
[ 1683s]     environ_get(131280, 131536)
[ 1683s]     args_sizes_get(69692, 69680)
[ 1683s]     fd_fdstat_get(3, 69624)
[ 1683s]     path_open(3, 1, 1033, 7, 2, 264240830, 268435455, 4, 69620)
[ 1683s]     
[ 1683s]     executing preopen_populates
[ 1683s]     (node:13031) ExperimentalWarning: WASI is an experimental feature. This feature could change at any time
[ 1683s]     fd_prestat_get(3, 67056)
[ 1683s]     fd_prestat_dir_name(3, 131232, 9)
[ 1683s]     fd_fdstat_get(3, 67032)
[ 1683s]     fd_prestat_get(4, 67056)
[ 1683s]     fd_prestat_dir_name(4, 131232, 5)
[ 1683s]     fd_fdstat_get(4, 67032)
[ 1683s]     fd_prestat_get(5, 67056)
[ 1683s]     environ_sizes_get(67056, 67068)
[ 1683s]     environ_get(131280, 131536)
[ 1683s]     args_sizes_get(67068, 67056)
[ 1683s]     
[ 1683s]     executing read_file
[ 1683s]     (node:13052) ExperimentalWarning: WASI is an experimental feature. This feature could change at any time
[ 1683s]     fd_prestat_get(3, 70864)
[ 1683s]     fd_prestat_dir_name(3, 131232, 9)
[ 1683s]     fd_fdstat_get(3, 70840)
[ 1683s]     fd_prestat_get(4, 70864)
[ 1683s]     fd_prestat_dir_name(4, 131232, 5)
[ 1683s]     fd_fdstat_get(4, 70840)
[ 1683s]     fd_prestat_get(5, 70864)
[ 1683s]     environ_sizes_get(70864, 70876)
[ 1683s]     environ_get(131280, 131536)
[ 1683s]     args_sizes_get(70876, 70864)
[ 1683s]     fd_fdstat_get(3, 70776)
[ 1683s]     path_open(3, 1, 1033, 9, 0, 264240830, 268435455, 0, 70772)
[ 1683s]     fd_read(5, 70808, 1, 70804)
[ 1683s]     fd_fdstat_get(1, 70808)
[ 1683s]     fd_write(1, 70816, 2, 70812)
[ 1683s]     fd_read(5, 70808, 1, 70804)
[ 1683s]     
[ 1683s]     executing read_file_twice
[ 1683s]     (node:13073) ExperimentalWarning: WASI is an experimental feature. This feature could change at any time
[ 1683s]     fd_prestat_get(3, 70864)
[ 1683s]     fd_prestat_dir_name(3, 131232, 9)
[ 1683s]     fd_fdstat_get(3, 70840)
[ 1683s]     fd_prestat_get(4, 70864)
[ 1683s]     fd_prestat_dir_name(4, 131232, 5)
[ 1683s]     fd_fdstat_get(4, 70840)
[ 1683s]     fd_prestat_get(5, 70864)
[ 1683s]     environ_sizes_get(70864, 70876)
[ 1683s]     environ_get(131280, 131536)
[ 1683s]     args_sizes_get(70876, 70864)
[ 1683s]     fd_fdstat_get(3, 70760)
[ 1683s]     path_open(3, 1, 1033, 9, 0, 264240830, 268435455, 0, 70756)
[ 1683s]     fd_read(5, 70792, 1, 70788)
[ 1683s]     fd_fdstat_get(1, 70792)
[ 1683s]     fd_write(1, 70800, 2, 70796)
[ 1683s]     fd_read(5, 70792, 1, 70788)
[ 1683s]     fd_fdstat_get(3, 70760)
[ 1683s]     path_open(3, 1, 1033, 9, 0, 264240830, 268435455, 0, 70756)
[ 1683s]     
[ 1683s]     assert.js:99
[ 1684s]       throw new AssertionError(obj);
[ 1684s]       ^
[ 1684s]     
[ 1684s]     AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:
[ 1684s]     
[ 1684s]     null !== 0
[ 1684s]     
[ 1684s]         at runWASI (/home/abuild/rpmbuild/BUILD/node-git.024b658831/test/wasi/test-wasi.js:54:12)
[ 1684s]         at Object.<anonymous> (/home/abuild/rpmbuild/BUILD/node-git.024b658831/test/wasi/test-wasi.js:70:3)
[ 1684s]         at Module._compile (internal/modules/cjs/loader.js:1196:30)
[ 1684s]         at Object.Module._extensions..js (internal/modules/cjs/loader.js:1216:10)
[ 1684s]         at Module.load (internal/modules/cjs/loader.js:1045:32)
[ 1684s]         at Function.Module._load (internal/modules/cjs/loader.js:949:14)
[ 1684s]         at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:71:12)
[ 1684s]         at internal/main/run_main_module.js:17:47 {
[ 1684s]       generatedMessage: true,
[ 1684s]       code: 'ERR_ASSERTION',
[ 1684s]       actual: null,
[ 1684s]       expected: 0,
[ 1684s]       operator: 'strictEqual'
[ 1684s]     }
[ 1684s]   ...
@cjihrig
Copy link
Contributor

cjihrig commented Dec 16, 2019

Just double checking, but did you modify/recompile the .wasm files for that test? Also, can you provide the value of child.signal (it's on the line following the failed assertion).

@AdamMajer
Copy link
Contributor Author

child.signal is SIGABRT

I have not modified any of the .wasm files. If they ever get recompiled, it should be in the log. It seems someone changed that URL to access the log for non-logged in users to

https://build.opensuse.org/public/build/devel:languages:nodejs:staging/openSUSE_Tumbleweed/x86_64/nodejs42/_log

@AdamMajer
Copy link
Contributor Author

AdamMajer commented Dec 16, 2019 •
edited
Loading

also, child.stdout.toString() returns "hello from input.txt" so it's only run once before the signal. So it looks like it opens the file 2nd time but dies before being able to read it... hmm

@gengjiawen gengjiawen added the wasi Issues and PRs related to the WebAssembly System Interface. label Dec 18, 2019
@addaleax
Copy link
Member

@AdamMajer Did #30980 (and in particular nodejs/uvwasi@7579e29) fix this?

@AdamMajer
Copy link
Contributor Author

@addaleax Yes, it's now fixed when that commit landed. Thank you. I'll close this issue now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
wasi Issues and PRs related to the WebAssembly System Interface.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@addaleax @AdamMajer @cjihrig @gengjiawen