Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V8's native Promise misbehaves when resolved with a thenable #2747

Closed
Arnavion opened this issue Sep 8, 2015 · 7 comments
Closed

V8's native Promise misbehaves when resolved with a thenable #2747

Arnavion opened this issue Sep 8, 2015 · 7 comments
Labels
v8 engine Issues and PRs related to the V8 dependency.

Comments

@Arnavion
Copy link

Arnavion commented Sep 8, 2015

I see the v4 post is promoting V8 promises, so just wanted to make sure this issue is on your radar for LTS considerations.

https://code.google.com/p/v8/issues/detail?id=4162

More discussion and test case in zloirock/core-js#78

@mscdex mscdex added the v8 engine Issues and PRs related to the V8 dependency. label Sep 8, 2015
@domenic
Copy link
Contributor

domenic commented Sep 12, 2015

/cc @littledan who I know was looking for promise issues that are causing pain in the wild.

@ChALkeR
Copy link
Member

ChALkeR commented Sep 12, 2015

@Fishrock123 Are we promoting V8 promises?

@Arnavion
Copy link
Author

https://nodejs.org/en/blog/release/v4.0.0/

Node.js v4.0.0 contains V8 v4.5, the same version of V8 shipping with the Chrome web browser today. This brings with it many bonuses for Node.js users, most notably a raft of new ES6 features that are enabled by default including block scoping, classes, typed arrays (Node's Buffer is now backed by Uint8Array), generators, Promises, Symbols, template strings, collections (Map, Set, etc.) and, new to V8 v4.5, arrow functions.

@Fishrock123
Copy link
Contributor

What, should we pretend they don't exist? I wouldn't say we are promoting them though. I'd definitely not recommend using native promises, at least for now.

Actually let's just override the global variable for 5.x+

@littledan
Copy link

Thanks for the bug report and drawing my attention to it. This looks pretty significant. Sorry it hasn't been addressed so far.

@jasnell
Copy link
Member

jasnell commented Mar 9, 2016

Closing as the originally reported issue (https://code.google.com/p/v8/issues/detail?id=4162) appears to have been fixed.

@jasnell jasnell closed this as completed Mar 9, 2016
@littledan
Copy link

Thanks again for the bug report; please let me know if you have any more issues with Promises.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Development

No branches or pull requests

7 participants