Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Node Js 11.1 Can't run on Electron #24102

Closed
HomepcX opened this issue Nov 5, 2018 · 4 comments
Closed

Node Js 11.1 Can't run on Electron #24102

HomepcX opened this issue Nov 5, 2018 · 4 comments
Labels
embedding Issues and PRs related to embedding Node.js in another project.

Comments

@HomepcX
Copy link

HomepcX commented Nov 5, 2018

Node Js 11.1 Can't run on Electron
@refack
Copy link
Contributor

refack commented Nov 5, 2018

Hello @HomepcX and thank you for the report.
Can I ask what exactly are you seeing?
Might this #24034 solve the issue?

@refack refack added the embedding Issues and PRs related to embedding Node.js in another project. label Nov 5, 2018
@codebytere
Copy link
Member

codebytere commented Nov 5, 2018 •
edited
Loading

@HomepcX we've backported a fix for this onto the latest patch versions of our active release lines, so this should no longer be an issue.

@Trott
Copy link
Member

Trott commented Nov 5, 2018

Might this #24034 solve the issue?

(If I'm not mistaken, that would only apply to Windows, so if you're not running Windows, then you can immediately say "Nope, that won't affect me.")

@Trott
Copy link
Member

Trott commented Nov 6, 2018 •
edited
Loading

we've backported a fix for this onto the latest patch versions of our active release lines, so this should no longer be an issue.

Closing but feel free to comment or re-open if there's still a problem with the latest Electron releases.

@Trott Trott closed this as completed Nov 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
embedding Issues and PRs related to embedding Node.js in another project.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@refack @Trott @codebytere @HomepcX