Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fs.createReadStream weirdness on Windows CI #1737

Closed
silverwind opened this issue May 19, 2015 · 2 comments
Closed

test: fs.createReadStream weirdness on Windows CI #1737

silverwind opened this issue May 19, 2015 · 2 comments
Labels
test Issues and PRs related to the tests. windows Issues and PRs related to the Windows platform.

Comments

@silverwind
Copy link
Contributor

test/parallel/test-fs-non-number-arguments-throw.js reads itself and after introducing a 'use strict'; and changing the start and end offsets in fs.createReadStream accordingly, the read string starts one character earlier, presumably because of the added newline character.

See #1721 (comment) and following for more detail. I was unable to reproduce the issue on Windows 7,8.1 and Server 2012 so I'm almost certain it's related to the CI itself.
@silverwind silverwind added windows Issues and PRs related to the Windows platform. test Issues and PRs related to the tests. labels May 19, 2015
@silverwind silverwind mentioned this issue May 19, 2015
Closed
@silverwind silverwind changed the title test: fs.createReadStream on Windows CI test: fs.createReadStream weirdness on Windows CI May 19, 2015
@silverwind
Copy link
Contributor Author

Windows builds are now green after they have been switched to not run as a service (#1777 (comment)), I'll verify this issue later and I'm positive I can include the excluded test in linting again soon.

@silverwind silverwind mentioned this issue Aug 22, 2015
Closed
@silverwind
Copy link
Contributor Author

Fixed in 83c2c3b

@MaxMood96 MaxMood96 mentioned this issue May 23, 2022
Open
@ryan-ally ryan-ally mentioned this issue May 23, 2022
Open
This was referenced May 24, 2022
Open
Open
Open
Open
@snyk-bot snyk-bot mentioned this issue Aug 19, 2022
Open
@snyk-bot snyk-bot mentioned this issue Apr 25, 2023
Open
@leonardoadame leonardoadame mentioned this issue Jul 8, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
test Issues and PRs related to the tests. windows Issues and PRs related to the Windows platform.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@silverwind