Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

investigate flaky parallel/test-repl-envvars on AIX #16859

Closed
Trott opened this issue Nov 7, 2017 · 5 comments
Closed

investigate flaky parallel/test-repl-envvars on AIX #16859

Trott opened this issue Nov 7, 2017 · 5 comments
Labels
aix Issues and PRs related to the AIX platform. flaky-test Issues and PRs related to the tests with unstable failures on the CI. repl Issues and PRs related to the REPL subsystem. test Issues and PRs related to the tests.

Comments

@Trott
Copy link
Member

Trott commented Nov 7, 2017

  • Version: 10.0.0-pre
  • Platform: aix61-ppc64
  • Subsystem: test

https://ci.nodejs.org/job/node-test-commit-aix/10064/nodes=aix61-ppc64/console

not ok 1317 parallel/test-repl-envvars
  ---
  duration_ms: 0.220
  severity: fail
  stack: |-
    assert.js:42
      throw new errors.AssertionError({
      ^
    
    AssertionError [ERR_ASSERTION]: Expected { terminal: true, useColors: true } with { IGNORE_FLAKY_TESTS: 'true',
      GIT_SSL_CAINFO: '/home/iojs/ca-bundle.crt',
      BUILD_CAUSE: 'UPSTREAMTRIGGER',
      GIT_COMMIT: 'cd49807a3b847a76d6aae6138268e2f9a9fe6981',
      CLCMD_PASSTHRU: '1',
      HUDSON_URL: 'https://ci.nodejs.org/',
      IBM_JVM_CHANGED_ENVVARS_5308588: 'AIXTHREAD_SCOPE,NULLPTR,CORE_MMAP',
      BUILD_URL: 'https://ci.nodejs.org/job/node-test-commit-aix/nodes=aix61-ppc64/10064/',
      GIT_PREVIOUS_COMMIT: '84f9982bdb3034341236a26e777cd50425d86758',
      BUILD_TAG: 'jenkins-node-test-commit-aix-nodes=aix61-ppc64-10064',
      AUTHSTATE: 'files',
      HUDSON_SERVER_COOKIE: '77c5c04cfa349d13',
      JENKINS_URL: 'https://ci.nodejs.org/',
      LOGNAME: 'iojs',
      USER: 'iojs',
      WORKSPACE: '/home/iojs/build/workspace/node-test-commit-aix/nodes/aix61-ppc64',
      HOME: '/home/iojs',
      LOCPATH: '/usr/lib/nls/loc',
      PATH: '/opt/freeware/bin/ccache:/home/iojs/jdk8/jre/bin/:/usr/bin:/etc:/usr/sbin:/usr/ucb:/usr/bin/X11:/sbin:/usr/java6/jre/bin:/usr/java6/bin',
      LOGIN: 'iojs',
      NODE_COMMON_PIPE: '/home/iojs/test.pipe',
      JOB_NAME: 'node-test-commit-aix/nodes=aix61-ppc64',
      FLAKY_TESTS: 'dontcare',
      GITHUB_ORG: 'nodejs',
      RUN_DISPLAY_URL: 'https://ci.nodejs.org/job/node-test-commit-aix/nodes=aix61-ppc64/10064/display/redirect',
      jenkins_log_file: '/home/iojs/jenkins_console.log',
      SHELL: '/bin/bash',
      TZ: 'CST6CDT',
      LC__FASTMSG: 'true',
      IBM_JVM_AIXTHREAD_SCOPE_NEW_VALUE: 'S',
      SHLVL: '1',
      IBM_JVM_NULLPTR_NEW_VALUE: 'NOSEGV',
      IBM_JAVA_COMMAND_LINE: '/home/iojs/jdk8/jre/bin/java -Xmx128m -Dorg.jenkinsci.plugins.gitclient.Git.timeOut=30 -jar /home/iojs/slave.jar -secret 6ef0fd9bd426c050b4e710aaa5908baf21957e3c9665acde4f39971935aeade7 -jnlpUrl https://ci.nodejs.org/computer/test-osuosl-aix61-ppc64_be-2/slave-agent.jnlp',
      HUDSON_HOME: '/var/lib/jenkins',
      TEST_THREAD_ID: '0',
      NODE_LABELS: 'aix61-ppc64 test-osuosl-aix61-ppc64_be-2',
      PYTHON: '/usr/bin/python',
      CONFIG_FLAGS: '--dest-cpu=ppc64',
      GIT_REMOTE_REF: 'refs/pull/16795/head',
      ROOT_BUILD_CAUSE_MANUALTRIGGER: 'true',
      MAKEFLAGS: 'w --jobserver-fds=3,4 -j',
      OSTYPE: 'aix',
      SSL_CERT_FILE: '/home/iojs/ca-bundle.crt',
      nodes: 'aix61-ppc64',
      BUILD_CAUSE_UPSTREAMTRIGGER: 'true',
      MFLAGS: '-w --jobserver-fds=3,4 -j',
      ROOT_BUILD_CAUSE: 'MANUALTRIGGER',
      REPO_NAME: 'node',
      BUILD_ID: '10064',
      LANG: 'en_US',
      BUILD_NUMBER: '10064',
      HUDSON_COOKIE: '5e4e7e86-9648-46ec-8757-c2c3ecd5831e',
      TEMP_REPO: '[email protected]:janeasystems/node_binary_tmp.git',
      POST_STATUS_TO_PR: 'true',
      NULLPTR: 'NOSEGV',
      TERM: 'dumb',
      NODES_SUBSET: 'io.js',
      CORE_MMAP: 'yes',
      GIT_URL: 'https://github.com/nodejs/node.git',
      JOB_BASE_NAME: 'nodes=aix61-ppc64',
      RUN_CHANGES_DISPLAY_URL: 'https://ci.nodejs.org/job/node-test-commit-aix/nodes=aix61-ppc64/10064/display/redirect?page=changes',
      JENKINS_HOME: '/var/lib/jenkins',
      NODE_MAJOR_VERSION: '10',
      _: '/usr/bin/gmake',
      GIT_PREVIOUS_SUCCESSFUL_COMMIT: 'bd607c9a949c23ce93753f5b0dbea7c6267fbe2f',
      IBM_JVM_CORE_MMAP_NEW_VALUE: 'yes',
      CC: 'gcc',
      ODMDIR: '/etc/objrepos',
      NODE_TEST_DIR: '/home/iojs/node-tmp',
      JOB_DISPLAY_URL: 'https://ci.nodejs.org/job/node-test-commit-aix/nodes=aix61-ppc64/display/redirect',
      JOB_URL: 'https://ci.nodejs.org/job/node-test-commit-aix/nodes=aix61-ppc64/',
      REBASE_ONTO: '207b24a75e5a23b58e960effe9852430cacdddbe',
      EXECUTOR_NUMBER: '0',
      NODE_NAME: 'test-osuosl-aix61-ppc64_be-2',
      AIXTHREAD_SCOPE: 'S',
      MAKELEVEL: '2',
      PWD: '/home/iojs/build/workspace/node-test-commit-aix/nodes/aix61-ppc64',
      GIT_ORIGIN_SCHEME: 'https://github.com/',
      JENKINS_SERVER_COOKIE: '77c5c04cfa349d13',
      BUILD_DISPLAY_NAME: '#10064',
      LAST_TRIGGERED_JOB_NAME: 'post_build_status_update',
      GIT_BRANCH: 'origin/_jenkins_local_branch',
      NLSPATH: '/usr/lib/nls/msg/%L/%N:/usr/lib/nls/msg/%L/%N.cat' }
        at /home/iojs/build/workspace/node-test-commit-aix/nodes/aix61-ppc64/test/parallel/test-repl-envvars.js:55:12
        at REPLServer.<anonymous> (internal/repl.js:194:9)
        at Object.onceWrapper (events.js:322:30)
        at emitNone (events.js:115:13)
        at REPLServer.emit (events.js:218:7)
        at onwritten (internal/repl.js:230:14)
        at FSReqWrap.wrapper [as oncomplete] (fs.js:703:5)
  ...
@Trott Trott added aix Issues and PRs related to the AIX platform. flaky-test Issues and PRs related to the tests with unstable failures on the CI. repl Issues and PRs related to the REPL subsystem. test Issues and PRs related to the tests. labels Nov 7, 2017
@Trott
Copy link
Member Author

Trott commented Nov 7, 2017

@nodejs/testing @nodejs/platform-aix

@gireeshpunathil
Copy link
Member

ACK, trying to reproduce and debug.

@gireeshpunathil
Copy link
Member

Ran a 1000 times locally, not reproducible.

From the error description, looks like this line thew the error:

  assert.strictEqual(expected.useColors, repl.useColors,
                     `Expected ${inspect(expected)} with ${inspect(env)}`);

and from the test logic, it would hint to the first test, that correponds to:

    env: {},
    expected: { terminal: true, useColors: true }

(by matching the expected values, and the then state of environment).

If there is some difference between my local and the CI, this reduced test should show that up.

const stream = require('stream');
const REPL = require('internal/repl');
const assert = require('assert');

const env = {};
const expected = { terminal: true, useColors: true };
const opts = {
  terminal: true,
  input: new stream.Readable({ read() {} }),
  output: new stream.Writable({ write() {} })
};

REPL.createInternalRepl(env, opts, function(err, repl) {
  assert.strictEqual(expected.useColors, repl.useColors);
});

Can someone with access to the CI (AIX) run this a 1000 times please?

@Trott
Copy link
Member Author

Trott commented Nov 7, 2017

@gireeshpunathil It reproduces reliably on one of the two hosts in CI. I took that host offline. @refack is looking at it now. If you want, hop into IRC #node-build and chat with him.

@Trott
Copy link
Member Author

Trott commented Nov 7, 2017

I'm going to close this one in favor of nodejs/build#984 because I strongly suspect this is a build issue and not a test issue.
¯\(ツ)

@Trott Trott closed this as completed Nov 7, 2017
@mhdawson mhdawson added this to the terminal milestone Nov 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aix Issues and PRs related to the AIX platform. flaky-test Issues and PRs related to the tests with unstable failures on the CI. repl Issues and PRs related to the REPL subsystem. test Issues and PRs related to the tests.
Projects
None yet
Development

No branches or pull requests

3 participants