-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add $HOME/.config/nodejs with an option for deduping default repl history #11907
Comments
hmm... I'd say -0 on it. Wouldn't object but not overly favorable as I just don't see it as being that important. |
I think we should really moderate ourselves with new environment variables. Maybe a |
I agree with @silverwind that we should be conservative with adding new environment variables. The comment you link to mentions multi-line input, like a function definition. Deduping individual lines in multi-line input seems broken to me, I would expect it to either filter everything or nothing. |
If we feel |
The correct place is Note: we might prefer to put things into a directory (e.g. That said, I am not convinced if we should store the configuration at all, so that's |
I honestly don't really care where it is, but it would be nice to store repl options somewhere outside cli flags. |
Maybe this can be specifically for repl options then. Would people prefer that? |
@Fishrock123 I saw a Node.js config file being mentioned in nodejs/node-eps#39. /cc @bmeck and @michael-ciniawsky, perhaps. |
I cannot say that I'm a big fan of having a .noderc type config file. Yes, there are a number a ways in which it could be used but the added benefit is minimal in my opinion and there's plenty of room for issues (such as conflicting config requirements for multiple node.js apps). Not going to -1 this right now, tho, just not a fan. |
|
Please note that any talk of My talks in other issues about similar global files have often resulted in problems with keeping default behavior set in expected ways. I fear that having this config functionality will remove barriers to using features that are not intended to be used in non-testing scenarios ( |
Yep agreed with @bmeck, also |
Closing as this seems inactive and with no clear consensus on how to approach it. However, if I'm wrong about that, or even if we just want it open as a placeholder/reminder, feel free to re-open. Just tidying up, no super-strong opinion. |
I just landed 5bda5fa which allows readlines to dedupe their history automatically when an option is set. I originally thought this would also be nice to have in the repl, but @DannyNemer made some good points in #2982 (comment) about why we shouldn't have that on by default.
I personally think there could be room for an env variable for this, and I'd personally kinda like to have it.
The text was updated successfully, but these errors were encountered: