Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 862d005e603e8897336ee021094106c402603c2d
Choose a base ref
...
head repository: nodejs/node
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 921f75534cdc2ad6fdc61c573d18f61ca14b35da
Choose a head ref
  • 2 commits
  • 2 files changed
  • 1 contributor

Commits on Jun 9, 2020

  1. doc: update V8 inspector example

    This commit updates the V8 inspector example to reflect what
    is currently printed to the console.
    
    PR-URL: #33758
    Reviewed-By: Anna Henningsen <[email protected]>
    Reviewed-By: Eugene Ostroukhov <[email protected]>
    Reviewed-By: Matheus Marchini <[email protected]>
    Reviewed-By: Trivikram Kamat <[email protected]>
    Reviewed-By: David Carlier <[email protected]>
    cjihrig committed Jun 9, 2020
    Copy the full SHA
    fd7e408 View commit details
  2. inspector: drop 'chrome-' from inspector url

    It has been reported that the
    https://github.com/cjihrig/node-v8-inspector V8 inspector
    extension can no longer connect DevTools (despite no code changes
    to the extension since Feb. 2017). Upon investigation, Chrome
    dropped support for the chrome-devtools: scheme recently. I've
    confirmed that dropping 'chrome-' from the URL here allows the
    debugger to function properly with modern Chrome.
    
    Refs: https://chromium.googlesource.com/chromium/src/+/6700d12448f76712c62a6d2372a95b97a26d4779
    PR-URL: #33758
    Reviewed-By: Anna Henningsen <[email protected]>
    Reviewed-By: Eugene Ostroukhov <[email protected]>
    Reviewed-By: Matheus Marchini <[email protected]>
    Reviewed-By: Trivikram Kamat <[email protected]>
    Reviewed-By: David Carlier <[email protected]>
    cjihrig committed Jun 9, 2020
    Copy the full SHA
    921f755 View commit details
Showing with 3 additions and 4 deletions.
  1. +2 βˆ’3 doc/api/debugger.md
  2. +1 βˆ’1 src/inspector_socket_server.cc
5 changes: 2 additions & 3 deletions doc/api/debugger.md
Original file line number Diff line number Diff line change
@@ -185,9 +185,8 @@ flag instead of `--inspect`.

```console
$ node --inspect index.js
Debugger listening on 127.0.0.1:9229.
To start debugging, open the following URL in Chrome:
chrome-devtools://devtools/bundled/js_app.html?experiments=true&v8only=true&ws=127.0.0.1:9229/dc9010dd-f8b8-4ac5-a510-c1a114ec7d29
Debugger listening on ws://127.0.0.1:9229/dc9010dd-f8b8-4ac5-a510-c1a114ec7d29
For help, see: https://nodejs.org/en/docs/inspector
```

(In the example above, the UUID dc9010dd-f8b8-4ac5-a510-c1a114ec7d29
2 changes: 1 addition & 1 deletion src/inspector_socket_server.cc
Original file line number Diff line number Diff line change
@@ -373,7 +373,7 @@ void InspectorSocketServer::SendListResponse(InspectorSocket* socket,
std::string InspectorSocketServer::GetFrontendURL(bool is_compat,
const std::string &formatted_address) {
std::ostringstream frontend_url;
frontend_url << "chrome-devtools://devtools/bundled/";
frontend_url << "devtools://devtools/bundled/";
frontend_url << (is_compat ? "inspector" : "js_app");
frontend_url << ".html?experiments=true&v8only=true&ws=";
frontend_url << formatted_address;