lib: use remaining typed arrays from primordials

PR-URL: #35499 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Ujjwal Sharma <[email protected]> Reviewed-By: Shingo Inoue <[email protected]>
nodejs · Oct 13, 2020 · fa171db · fa171db
1 parent 7e8fdd3
commit fa171db
Show file tree

Hide file tree

Showing 13 changed files with 29 additions and 3 deletions.
diff --git a/lib/.eslintrc.yaml b/lib/.eslintrc.yaml
@@ -11,6 +11,8 @@ rules:
     - error
     - name: Array
       message: "Use `const { Array } = primordials;` instead of the global."
+    - name: ArrayBuffer
+      message: "Use `const { ArrayBuffer } = primordials;` instead of the global."
     - name: BigInt
       message: "Use `const { BigInt } = primordials;` instead of the global."
     - name: BigInt64Array
@@ -67,6 +69,12 @@ rules:
       message: "Use `const { URIError } = primordials;` instead of the global."
     - name: Uint16Array
       message: "Use `const { Uint16Array } = primordials;` instead of the global."
+    - name: Uint32Array
+      message: "Use `const { Uint32Array } = primordials;` instead of the global."
+    - name: Uint8Array
+      message: "Use `const { Uint8Array } = primordials;` instead of the global."
+    - name: Uint8ClampedArray
+      message: "Use `const { Uint8ClampedArray } = primordials;` instead of the global."
     - name: WeakMap
       message: "Use `const { WeakMap } = primordials;` instead of the global."
     - name: WeakSet

diff --git a/lib/buffer.js b/lib/buffer.js
@@ -39,6 +39,7 @@ const {
   ObjectSetPrototypeOf,
   SymbolSpecies,
   SymbolToPrimitive,
+  Uint8Array,
   Uint8ArrayPrototype,
 } = primordials;
 
@@ -403,7 +404,7 @@ function SlowBuffer(length) {
   return createUnsafeBuffer(length);
 }
 
-ObjectSetPrototypeOf(SlowBuffer.prototype, Uint8Array.prototype);
+ObjectSetPrototypeOf(SlowBuffer.prototype, Uint8ArrayPrototype);
 ObjectSetPrototypeOf(SlowBuffer, Uint8Array);
 
 function allocate(size) {

diff --git a/lib/internal/buffer.js b/lib/internal/buffer.js
@@ -6,6 +6,7 @@ const {
   Float64Array,
   MathFloor,
   Number,
+  Uint8Array,
 } = primordials;
 
 const {

diff --git a/lib/internal/child_process.js b/lib/internal/child_process.js
@@ -5,6 +5,7 @@ const {
   ObjectDefineProperty,
   ObjectSetPrototypeOf,
   Symbol,
+  Uint8Array,
 } = primordials;
 
 const {

diff --git a/lib/internal/encoding.js b/lib/internal/encoding.js
@@ -10,6 +10,8 @@ const {
   ObjectGetOwnPropertyDescriptors,
   Symbol,
   SymbolToStringTag,
+  Uint32Array,
+  Uint8Array,
 } = primordials;
 
 const {

diff --git a/lib/internal/http2/core.js b/lib/internal/http2/core.js
@@ -15,6 +15,8 @@ const {
   ReflectGetPrototypeOf,
   Set,
   Symbol,
+  Uint32Array,
+  Uint8Array,
 } = primordials;
 
 const {

diff --git a/lib/internal/process/per_thread.js b/lib/internal/process/per_thread.js
@@ -18,6 +18,7 @@ const {
   SetPrototype,
   SetPrototypeHas,
   StringPrototypeReplace,
+  Uint32Array,
 } = primordials;
 
 const {

diff --git a/lib/internal/streams/buffer_list.js b/lib/internal/streams/buffer_list.js
@@ -2,6 +2,7 @@
 
 const {
   SymbolIterator,
+  Uint8Array,
 } = primordials;
 
 const { Buffer } = require('buffer');

diff --git a/lib/internal/util/comparisons.js b/lib/internal/util/comparisons.js
@@ -20,6 +20,7 @@ const {
   StringPrototypeValueOf,
   SymbolPrototypeValueOf,
   SymbolToStringTag,
+  Uint8Array,
 } = primordials;
 
 const { compare } = internalBinding('buffer');

diff --git a/lib/internal/util/inspect.js b/lib/internal/util/inspect.js
@@ -58,6 +58,10 @@ const {
   SymbolIterator,
   SymbolToStringTag,
   Uint16Array,
+  Uint32Array,
+  Uint8Array,
+  Uint8ArrayPrototype,
+  Uint8ClampedArray,
   uncurryThis,
 } = primordials;
 
@@ -138,7 +142,7 @@ const mapSizeGetter = uncurryThis(
   ObjectGetOwnPropertyDescriptor(MapPrototype, 'size').get);
 const typedArraySizeGetter = uncurryThis(
   ObjectGetOwnPropertyDescriptor(
-    ObjectGetPrototypeOf(Uint8Array.prototype), 'length').get);
+    ObjectGetPrototypeOf(Uint8ArrayPrototype), 'length').get);
 
 let hexSlice;
 

diff --git a/lib/internal/util/types.js b/lib/internal/util/types.js
@@ -5,10 +5,11 @@ const {
   ObjectGetOwnPropertyDescriptor,
   ObjectGetPrototypeOf,
   SymbolToStringTag,
+  Uint8ArrayPrototype,
   uncurryThis,
 } = primordials;
 
-const TypedArrayPrototype = ObjectGetPrototypeOf(Uint8Array.prototype);
+const TypedArrayPrototype = ObjectGetPrototypeOf(Uint8ArrayPrototype);
 
 const TypedArrayProto_toStringTag =
     uncurryThis(

diff --git a/lib/internal/worker.js b/lib/internal/worker.js
@@ -14,6 +14,7 @@ const {
   String,
   Symbol,
   SymbolFor,
+  Uint32Array,
 } = primordials;
 
 const EventEmitter = require('events');

diff --git a/lib/zlib.js b/lib/zlib.js
@@ -22,6 +22,7 @@
 'use strict';
 
 const {
+  ArrayBuffer,
   Error,
   MathMax,
   NumberIsFinite,
@@ -33,6 +34,7 @@ const {
   ObjectKeys,
   ObjectSetPrototypeOf,
   Symbol,
+  Uint32Array,
 } = primordials;
 
 const {