Skip to content

Commit

Permalink
n-api: add error message for date expected
Browse files Browse the repository at this point in the history
PR-URL: #28303
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
  • Loading branch information
Gabriel Schulhof authored and targos committed Jul 2, 2019
1 parent d759e0f commit ed8cee6
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion src/js_native_api_v8.cc
Original file line number Diff line number Diff line change
Expand Up @@ -676,6 +676,7 @@ const char* error_messages[] = {nullptr,
"Thread-safe function queue is full",
"Thread-safe function handle is closing",
"A bigint was expected",
"A date was expected",
};

napi_status napi_get_last_error_info(napi_env env,
Expand All @@ -688,7 +689,7 @@ napi_status napi_get_last_error_info(napi_env env,
// We don't have a napi_status_last as this would result in an ABI
// change each time a message was added.
static_assert(
NAPI_ARRAYSIZE(error_messages) == napi_bigint_expected + 1,
NAPI_ARRAYSIZE(error_messages) == napi_date_expected + 1,
"Count of error messages must match count of error values");
CHECK_LE(env->last_error.error_code, napi_callback_scope_mismatch);

Expand Down

0 comments on commit ed8cee6

Please sign in to comment.