events: deal with Symbol() passed to event constructor

PR-URL: #33612 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
nodejs · Jun 18, 2020 · e7bce2e · e7bce2e
1 parent 21f1e64
commit e7bce2e
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/lib/internal/event_target.js b/lib/internal/event_target.js
@@ -50,7 +50,7 @@ class Event {
     this.#cancelable = !!cancelable;
     this.#bubbles = !!bubbles;
     this.#composed = !!composed;
-    this.#type = String(type);
+    this.#type = `${type}`;
     // isTrusted is special (LegacyUnforgeable)
     Object.defineProperty(this, 'isTrusted', {
       get() { return false; },

diff --git a/test/parallel/test-eventtarget.js b/test/parallel/test-eventtarget.js
@@ -49,6 +49,7 @@ ok(EventTarget);
 
   ev.preventDefault();
   strictEqual(ev.defaultPrevented, true);
+  throws(() => new Event(Symbol()), TypeError);
 }
 {
   const ev = new Event('foo');