From e58f14fee70d7a81605e280310022ce090005b73 Mon Sep 17 00:00:00 2001 From: cjihrig Date: Fri, 5 Jun 2020 14:22:39 -0400 Subject: [PATCH] inspector: drop 'chrome-' from inspector url It has been reported that the https://github.com/cjihrig/node-v8-inspector V8 inspector extension can no longer connect DevTools (despite no code changes to the extension since Feb. 2017). Upon investigation, Chrome dropped support for the chrome-devtools: scheme recently. I've confirmed that dropping 'chrome-' from the URL here allows the debugger to function properly with modern Chrome. Refs: https://chromium.googlesource.com/chromium/src/+/6700d12448f76712c62a6d2372a95b97a26d4779 PR-URL: https://github.com/nodejs/node/pull/33758 Reviewed-By: Anna Henningsen Reviewed-By: Eugene Ostroukhov Reviewed-By: Matheus Marchini Reviewed-By: Trivikram Kamat Reviewed-By: David Carlier --- src/inspector_socket_server.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/inspector_socket_server.cc b/src/inspector_socket_server.cc index 9e27bd30f76871..29e0c128026ed0 100644 --- a/src/inspector_socket_server.cc +++ b/src/inspector_socket_server.cc @@ -373,7 +373,7 @@ void InspectorSocketServer::SendListResponse(InspectorSocket* socket, std::string InspectorSocketServer::GetFrontendURL(bool is_compat, const std::string &formatted_address) { std::ostringstream frontend_url; - frontend_url << "chrome-devtools://devtools/bundled/"; + frontend_url << "devtools://devtools/bundled/"; frontend_url << (is_compat ? "inspector" : "js_app"); frontend_url << ".html?experiments=true&v8only=true&ws="; frontend_url << formatted_address;