lib: create global console properties at snapshot build time

It is safe to create the console properties for the global console at snapshot build time. Streams must still be created lazily however because they need special synchronization for the handles. PR-URL: #51700 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Moshe Atlow <[email protected]>
nodejs · Mar 25, 2024 · d6e8d03 · d6e8d03
1 parent fdc7d75
commit d6e8d03
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/lib/internal/console/constructor.js b/lib/internal/console/constructor.js
@@ -689,8 +689,6 @@ Console.prototype.groupCollapsed = Console.prototype.group;
 
 function initializeGlobalConsole(globalConsole) {
   globalConsole[kBindStreamsLazy](process);
-  globalConsole[kBindProperties](true, 'auto');
-
   const {
     namespace: {
       addSerializeCallback,

diff --git a/lib/internal/console/global.js b/lib/internal/console/global.js
@@ -21,6 +21,7 @@ const {
 
 const {
   Console,
+  kBindProperties,
 } = require('internal/console/constructor');
 
 const globalConsole = { __proto__: {} };
@@ -41,6 +42,8 @@ for (const prop of ReflectOwnKeys(Console.prototype)) {
   ReflectDefineProperty(globalConsole, prop, desc);
 }
 
+globalConsole[kBindProperties](true, 'auto');
+
 // This is a legacy feature - the Console constructor is exposed on
 // the global console instance.
 globalConsole.Console = Console;