deps,v8: silence V8 self-deprecation warnings

PR-URL: #25394 Reviewed-By: Ujjwal Sharma <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Yang Guo <[email protected]>
nodejs · Jan 14, 2019 · d1b7193 · d1b7193
1 parent eb5aab2
commit d1b7193
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 4 deletions.
diff --git a/common.gypi b/common.gypi
@@ -45,12 +45,13 @@
     # Old time default, now explicitly stated.
     'v8_use_snapshot': 'true',
 
+    # These are more relevant for V8 internal development.
     # Refs: https://github.com/nodejs/node/issues/23122
     # Refs: https://github.com/nodejs/node/issues/23167
-    # Enable compiler warnings when using V8_DEPRECATED apis.
-    'v8_deprecation_warnings': 1,
-    # Enable compiler warnings when using V8_DEPRECATE_SOON apis.
-    'v8_imminent_deprecation_warnings': 1,
+    # Enable compiler warnings when using V8_DEPRECATED apis from V8 code.
+    'v8_deprecation_warnings': 0,
+    # Enable compiler warnings when using V8_DEPRECATE_SOON apis from V8 code.
+    'v8_imminent_deprecation_warnings': 0,
 
     # Enable disassembler for `--print-code` v8 options
     'v8_enable_disassembler': 1,

diff --git a/deps/v8/gypfiles/features.gypi b/deps/v8/gypfiles/features.gypi
@@ -164,9 +164,13 @@
       }],
       ['v8_deprecation_warnings==1', {
         'defines': ['V8_DEPRECATION_WARNINGS',],
+      },{
+        'defines!': ['V8_DEPRECATION_WARNINGS',],
       }],
       ['v8_imminent_deprecation_warnings==1', {
         'defines': ['V8_IMMINENT_DEPRECATION_WARNINGS',],
+      },{
+        'defines!': ['V8_IMMINENT_DEPRECATION_WARNINGS',],
       }],
       ['v8_enable_i18n_support==1', {
         'defines': ['V8_INTL_SUPPORT',],