From cafc0b2b337f121e52ad6cf2673561d114fe48c8 Mon Sep 17 00:00:00 2001 From: Antoine du Hamel Date: Sat, 18 Feb 2023 18:56:43 +0100 Subject: [PATCH] lib: add trailing commas in `internal/process` PR-URL: https://github.com/nodejs/node/pull/46687 Reviewed-By: Moshe Atlow Reviewed-By: Darshan Sen --- lib/.eslintrc.yaml | 1 + lib/internal/process/execution.js | 6 ++--- lib/internal/process/per_thread.js | 16 ++++++------- lib/internal/process/policy.js | 2 +- lib/internal/process/pre_execution.js | 28 +++++++++++----------- lib/internal/process/promises.js | 10 ++++---- lib/internal/process/report.js | 6 ++--- lib/internal/process/signal.js | 2 +- lib/internal/process/task_queues.js | 12 +++++----- lib/internal/process/worker_thread_only.js | 4 ++-- 10 files changed, 44 insertions(+), 43 deletions(-) diff --git a/lib/.eslintrc.yaml b/lib/.eslintrc.yaml index eb9a81077ff9fb..4537a3a2b47d4b 100644 --- a/lib/.eslintrc.yaml +++ b/lib/.eslintrc.yaml @@ -286,6 +286,7 @@ overrides: - ./internal/per_context/messageport.js - ./internal/policy/*.js - ./internal/priority_queue.js + - ./internal/process/*.js - ./internal/readline/*.js - ./internal/readme.md - ./internal/repl/history.js diff --git a/lib/internal/process/execution.js b/lib/internal/process/execution.js index 7c17e6f729cc44..afe2ba2c2c977b 100644 --- a/lib/internal/process/execution.js +++ b/lib/internal/process/execution.js @@ -87,7 +87,7 @@ function evalScript(name, body, breakFirstLine, print, shouldLoadESM = false) { importModuleDynamically(specifier, _, importAssertions) { const loader = asyncESM.esmLoader; return loader.import(specifier, baseUrl, importAssertions); - } + }, })); if (print) { const { log } = require('internal/console/global'); @@ -106,7 +106,7 @@ function evalScript(name, body, breakFirstLine, print, shouldLoadESM = false) { const exceptionHandlerState = { captureFn: null, - reportFlag: false + reportFlag: false, }; function setUncaughtExceptionCaptureCallback(fn) { @@ -213,5 +213,5 @@ module.exports = { evalScript, onGlobalUncaughtException: createOnGlobalUncaughtException(), setUncaughtExceptionCaptureCallback, - hasUncaughtExceptionCaptureCallback + hasUncaughtExceptionCaptureCallback, }; diff --git a/lib/internal/process/per_thread.js b/lib/internal/process/per_thread.js index 00d20470860dbd..ce4822af019d5f 100644 --- a/lib/internal/process/per_thread.js +++ b/lib/internal/process/per_thread.js @@ -38,8 +38,8 @@ const { ERR_INVALID_ARG_TYPE, ERR_INVALID_ARG_VALUE, ERR_OUT_OF_RANGE, - ERR_UNKNOWN_SIGNAL - } + ERR_UNKNOWN_SIGNAL, + }, } = require('internal/errors'); const format = require('internal/util/inspect').format; const { @@ -108,7 +108,7 @@ function wrapProcessMethods(binding) { cpuUsage: _cpuUsage, memoryUsage: _memoryUsage, rss, - resourceUsage: _resourceUsage + resourceUsage: _resourceUsage, } = binding; function _rawDebug(...args) { @@ -145,14 +145,14 @@ function wrapProcessMethods(binding) { if (prevValue) { return { user: cpuValues[0] - prevValue.user, - system: cpuValues[1] - prevValue.system + system: cpuValues[1] - prevValue.system, }; } // If no previous value passed in, return current value. return { user: cpuValues[0], - system: cpuValues[1] + system: cpuValues[1], }; } @@ -172,7 +172,7 @@ function wrapProcessMethods(binding) { heapTotal: memValues[1], heapUsed: memValues[2], external: memValues[3], - arrayBuffers: memValues[4] + arrayBuffers: memValues[4], }; } @@ -255,7 +255,7 @@ function wrapProcessMethods(binding) { ipcReceived: resourceValues[12], signalsCount: resourceValues[13], voluntaryContextSwitches: resourceValues[14], - involuntaryContextSwitches: resourceValues[15] + involuntaryContextSwitches: resourceValues[15], }; } @@ -266,7 +266,7 @@ function wrapProcessMethods(binding) { resourceUsage, memoryUsage, kill, - exit + exit, }; } diff --git a/lib/internal/process/policy.js b/lib/internal/process/policy.js index ea283a449742fc..075c4c9299a428 100644 --- a/lib/internal/process/policy.js +++ b/lib/internal/process/policy.js @@ -57,5 +57,5 @@ module.exports = ObjectFreeze({ assertIntegrity(moduleURL, content) { this.manifest.assertIntegrity(moduleURL, content); - } + }, }); diff --git a/lib/internal/process/pre_execution.js b/lib/internal/process/pre_execution.js index 32f1dbb4d75e9f..ebc699ef1de87a 100644 --- a/lib/internal/process/pre_execution.js +++ b/lib/internal/process/pre_execution.js @@ -40,7 +40,7 @@ function prepareMainThreadExecution(expandArgv1 = false, initializeModules = tru prepareExecution({ expandArgv1, initializeModules, - isMainThread: true + isMainThread: true, }); } @@ -48,7 +48,7 @@ function prepareWorkerThreadExecution() { prepareExecution({ expandArgv1: false, initializeModules: false, // Will need to initialize it after policy setup - isMainThread: false + isMainThread: false, }); } @@ -139,7 +139,7 @@ function patchProcessObject(expandArgv1) { enumerable: true, // Only set it to true during snapshot building. configurable: getOptionValue('--build-snapshot'), - value: process.argv[0] + value: process.argv[0], }); process.exitCode = undefined; @@ -188,7 +188,7 @@ function addReadOnlyProcessAlias(name, option, enumerable = true) { writable: false, configurable: true, enumerable, - value + value, }); } } @@ -196,7 +196,7 @@ function addReadOnlyProcessAlias(name, option, enumerable = true) { function setupWarningHandler() { const { onWarning, - resetForSerialization + resetForSerialization, } = require('internal/process/warning'); if (getOptionValue('--warnings') && process.env.NODE_NO_WARNINGS !== '1') { @@ -245,7 +245,7 @@ function setupFetch() { }, set(value) { exposeInterface(globalThis, name, value); - } + }, }; } @@ -291,7 +291,7 @@ function setupWebCrypto() { { __proto__: null, ...ObjectGetOwnPropertyDescriptor({ get crypto() { throw new ERR_NO_CRYPTO(); - } + }, }, 'crypto') }); } @@ -339,7 +339,7 @@ function initializeReport() { get() { const { report } = require('internal/process/report'); return report; - } + }, }); } @@ -400,7 +400,7 @@ function setupInspectorHooks() { if (internalBinding('config').hasInspector) { const { enable, - disable + disable, } = require('internal/inspector_async_hook'); internalBinding('inspector').registerAsyncHook(enable, disable); } @@ -455,7 +455,7 @@ function initializeDeprecations() { writable: false, enumerable: true, configurable: true, - value: noBrowserGlobals + value: noBrowserGlobals, }); } @@ -526,7 +526,7 @@ function readPolicyFromDisk() { for (let i = 0; i < integrityEntries.length; i++) { const { algorithm, - value: expected + value: expected, } = integrityEntries[i]; const hash = createHash(algorithm); hash.update(src); @@ -543,7 +543,7 @@ function readPolicyFromDisk() { } } return { - manifestSrc: src, manifestURL: manifestURL.href + manifestSrc: src, manifestURL: manifestURL.href, }; } } @@ -599,7 +599,7 @@ function loadPreloadModules() { if (preloadModules && preloadModules.length > 0) { const { Module: { - _preloadModules + _preloadModules, }, } = require('internal/modules/cjs/loader'); _preloadModules(preloadModules); @@ -614,5 +614,5 @@ module.exports = { setupUserModules, prepareMainThreadExecution, prepareWorkerThreadExecution, - markBootstrapComplete + markBootstrapComplete, }; diff --git a/lib/internal/process/promises.js b/lib/internal/process/promises.js index ecc4afc4f56c8a..d80ce1ef764a00 100644 --- a/lib/internal/process/promises.js +++ b/lib/internal/process/promises.js @@ -15,9 +15,9 @@ const { kPromiseRejectWithNoHandler, kPromiseHandlerAddedAfterReject, kPromiseResolveAfterResolved, - kPromiseRejectAfterResolved + kPromiseRejectAfterResolved, }, - setPromiseRejectCallback + setPromiseRejectCallback, } = internalBinding('task_queue'); const { deprecate } = require('internal/util'); @@ -33,8 +33,8 @@ const { popAsyncContext, symbols: { async_id_symbol: kAsyncIdSymbol, - trigger_async_id_symbol: kTriggerAsyncIdSymbol - } + trigger_async_id_symbol: kTriggerAsyncIdSymbol, + }, } = require('internal/async_hooks'); const { isErrorStackTraceLimitWritable } = require('internal/errors'); @@ -155,7 +155,7 @@ function unhandledRejection(promise, reason) { uid: ++lastPromiseId, warned: false, domain: process.domain, - emit + emit, }); // This causes the promise to be referenced at least for one tick. ArrayPrototypePush(pendingUnhandledRejections, promise); diff --git a/lib/internal/process/report.js b/lib/internal/process/report.js index b07fd0c1ff6eb7..c83371dcfcf938 100644 --- a/lib/internal/process/report.js +++ b/lib/internal/process/report.js @@ -1,6 +1,6 @@ 'use strict'; const { - ERR_SYNTHETIC + ERR_SYNTHETIC, } = require('internal/errors').codes; const { validateBoolean, @@ -92,7 +92,7 @@ const report = { validateBoolean(trigger, 'trigger'); nr.setReportOnUncaughtException(trigger); - } + }, }; function addSignalHandler(sig) { @@ -117,5 +117,5 @@ function signalHandler(sig) { module.exports = { addSignalHandler, - report + report, }; diff --git a/lib/internal/process/signal.js b/lib/internal/process/signal.js index 0631fe2b29ab01..548f19a65c7602 100644 --- a/lib/internal/process/signal.js +++ b/lib/internal/process/signal.js @@ -50,5 +50,5 @@ function stopListeningIfSignal(type) { module.exports = { startListeningIfSignal, - stopListeningIfSignal + stopListeningIfSignal, }; diff --git a/lib/internal/process/task_queues.js b/lib/internal/process/task_queues.js index 51ebe8c111abf7..bcb5eef841dd00 100644 --- a/lib/internal/process/task_queues.js +++ b/lib/internal/process/task_queues.js @@ -12,14 +12,14 @@ const { // Used to run V8's micro task queue. runMicrotasks, setTickCallback, - enqueueMicrotask + enqueueMicrotask, } = internalBinding('task_queue'); const { setHasRejectionToWarn, hasRejectionToWarn, listenForRejections, - processPromiseRejections + processPromiseRejections, } = require('internal/process/promises'); const { @@ -31,7 +31,7 @@ const { emitBefore, emitAfter, emitDestroy, - symbols: { async_id_symbol, trigger_async_id_symbol } + symbols: { async_id_symbol, trigger_async_id_symbol }, } = require('internal/async_hooks'); const FixedQueue = require('internal/fixed_queue'); @@ -126,7 +126,7 @@ function nextTick(callback) { [async_id_symbol]: asyncId, [trigger_async_id_symbol]: triggerAsyncId, callback, - args + args, }; if (initHooksExist()) emitInit(asyncId, 'TickObject', triggerAsyncId, tickObject); @@ -166,8 +166,8 @@ module.exports = { setTickCallback(processTicksAndRejections); return { nextTick, - runNextTicks + runNextTicks, }; }, - queueMicrotask + queueMicrotask, }; diff --git a/lib/internal/process/worker_thread_only.js b/lib/internal/process/worker_thread_only.js index 9d2a43b441a584..2f5a10c9d63f19 100644 --- a/lib/internal/process/worker_thread_only.js +++ b/lib/internal/process/worker_thread_only.js @@ -4,7 +4,7 @@ // run in the worker thread. const { - codes: { ERR_WORKER_UNSUPPORTED_OPERATION } + codes: { ERR_WORKER_UNSUPPORTED_OPERATION }, } = require('internal/errors'); function unavailable(name) { @@ -17,5 +17,5 @@ function unavailable(name) { } module.exports = { - unavailable + unavailable, };