From c5e35ada52a59347496881757ec559f97d47eed9 Mon Sep 17 00:00:00 2001 From: Rich Trott Date: Tue, 19 Oct 2021 21:35:54 -0700 Subject: [PATCH] fixup! doc: document considerations for inclusion in core --- doc/guides/modules-in-core.md | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/doc/guides/modules-in-core.md b/doc/guides/modules-in-core.md index 5d43a9b22053e8..8cd7fc7647d983 100644 --- a/doc/guides/modules-in-core.md +++ b/doc/guides/modules-in-core.md @@ -11,9 +11,12 @@ not. 2. The module can only be implemented in core. 3. The module can only be implemented in a performant way in core. 4. Developer experience is significantly improved if the module is in core. -5. The module will be widely used, have cross platform native code, and being in - core will avoid the need for an end-user compilation chain. -6. Part or all of the module will also be re-used or duplicated in core. +5. The module provides functionality that can be expected to solve at least one + common use case Node.js users face. +6. The module requires native bindings. Inclusion in core enables utility across + operating systems and architectures without requiring users to have a native + compilation toolchain. +7. Part or all of the module will also be re-used or duplicated in core. ## Strong arguments against including a module in core