stream: make Duplex inherit destroy from Writable

Make `Duplex` inherit the `destroy` method from `Writable` instead of `Readable` so that pending write callbacks are correctly invoked when the stream is destroyed. PR-URL: #52318 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
nodejs · Apr 5, 2024 · c02de65 · c02de65
1 parent 461d9d6
commit c02de65
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 0 deletions.
diff --git a/lib/internal/streams/duplex.js b/lib/internal/streams/duplex.js
@@ -59,6 +59,9 @@ ObjectSetPrototypeOf(Duplex, Readable);
   }
 }
 
+// Use the `destroy` method of `Writable`.
+Duplex.prototype.destroy = Writable.prototype.destroy;
+
 function Duplex(options) {
   if (!(this instanceof Duplex))
     return new Duplex(options);

diff --git a/test/parallel/test-stream-duplex-destroy.js b/test/parallel/test-stream-duplex-destroy.js
@@ -238,6 +238,7 @@ const assert = require('assert');
   });
   duplex.on('close', common.mustCall());
 }
+
 {
   // Check abort signal
   const controller = new AbortController();
@@ -255,3 +256,16 @@ const assert = require('assert');
   duplex.on('close', common.mustCall());
   controller.abort();
 }
+
+{
+  const duplex = new Duplex({
+    read() {},
+    write(chunk, enc, cb) { cb(); }
+  });
+
+  duplex.cork();
+  duplex.write('foo', common.mustCall((err) => {
+    assert.strictEqual(err.code, 'ERR_STREAM_DESTROYED');
+  }));
+  duplex.destroy();
+}