test_runner: track bootstrapping process

This commit updates the test harness and root test to track when bootstrapping has completed. PR-URL: #46962 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
nodejs · Mar 14, 2023 · b832d77 · b832d77
1 parent 05614f8
commit b832d77
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 9 deletions.
diff --git a/lib/internal/test_runner/harness.js b/lib/internal/test_runner/harness.js
@@ -178,13 +178,14 @@ function getGlobalRoot() {
     globalRoot.reporter.once('test:fail', () => {
       process.exitCode = kGenericUserError;
     });
-    reportersSetup = setupTestReporters(globalRoot.reporter);
+    reportersSetup = setupTestReporters(globalRoot);
   }
   return globalRoot;
 }
 
 async function startSubtest(subtest) {
   await reportersSetup;
+  getGlobalRoot().harness.bootstrapComplete = true;
   await subtest.start();
 }
 

diff --git a/lib/internal/test_runner/runner.js b/lib/internal/test_runner/runner.js
@@ -387,13 +387,16 @@ function run(options) {
     filesWatcher = watchFiles(testFiles, root, inspectPort);
     postRun = undefined;
   }
-  const runFiles = () => SafePromiseAllSettledReturnVoid(testFiles, (path) => {
-    const subtest = runTestFile(path, root, inspectPort, filesWatcher);
-    runningSubtests.set(path, subtest);
-    return subtest;
-  });
+  const runFiles = () => {
+    root.harness.bootstrapComplete = true;
+    return SafePromiseAllSettledReturnVoid(testFiles, (path) => {
+      const subtest = runTestFile(path, root, inspectPort, filesWatcher);
+      runningSubtests.set(path, subtest);
+      return subtest;
+    });
+  };
 
-  PromisePrototypeThen(PromisePrototypeThen(PromiseResolve(setup?.(root.reporter)), runFiles), postRun);
+  PromisePrototypeThen(PromisePrototypeThen(PromiseResolve(setup?.(root)), runFiles), postRun);
 
   return root.reporter;
 }

diff --git a/lib/internal/test_runner/utils.js b/lib/internal/test_runner/utils.js
@@ -150,13 +150,13 @@ async function getReportersMap(reporters, destinations) {
 }
 
 
-async function setupTestReporters(testsStream) {
+async function setupTestReporters(rootTest) {
   try {
     const { reporters, destinations } = parseCommandLine();
     const reportersMap = await getReportersMap(reporters, destinations);
     for (let i = 0; i < reportersMap.length; i++) {
       const { reporter, destination } = reportersMap[i];
-      compose(testsStream, reporter).pipe(destination);
+      compose(rootTest.reporter, reporter).pipe(destination);
     }
   } catch (err) {
     throw new ERR_TEST_FAILURE(err, kAsyncBootstrapFailure);