module: [email protected] big endian fix

PR-URL: #35634 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Ujjwal Sharma <[email protected]>
nodejs · Oct 14, 2020 · b82fc40 · b82fc40
1 parent 775af7a
commit b82fc40
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 15 deletions.
diff --git a/deps/cjs-module-lexer/dist/lexer.js b/deps/cjs-module-lexer/dist/lexer.js
diff --git a/deps/cjs-module-lexer/dist/lexer.mjs b/deps/cjs-module-lexer/dist/lexer.mjs
diff --git a/deps/cjs-module-lexer/package.json b/deps/cjs-module-lexer/package.json
@@ -1,6 +1,6 @@
 {
   "name": "cjs-module-lexer",
-  "version": "0.4.0",
+  "version": "0.4.2",
   "description": "Lexes CommonJS modules, returning their named exports metadata",
   "main": "lexer.js",
   "exports": {

diff --git a/doc/api/esm.md b/doc/api/esm.md
@@ -1282,7 +1282,7 @@ success!
 [`transformSource` hook]: #esm_transformsource_source_context_defaulttransformsource
 [`string`]: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String
 [`util.TextDecoder`]: util.md#util_class_util_textdecoder
-[cjs-module-lexer]: https://github.com/guybedford/cjs-module-lexer/tree/0.4.0
+[cjs-module-lexer]: https://github.com/guybedford/cjs-module-lexer/tree/0.4.2
 [special scheme]: https://url.spec.whatwg.org/#special-scheme
 [the official standard format]: https://tc39.github.io/ecma262/#sec-modules
 [transpiler loader example]: #esm_transpiler_loader
diff --git a/lib/internal/modules/esm/translators.js b/lib/internal/modules/esm/translators.js
@@ -60,20 +60,14 @@ const { emitWarningSync } = require('internal/process/warning');
 
 let cjsParse;
 async function initCJSParse() {
-  if (typeof WebAssembly !== 'undefined') {
+  if (typeof WebAssembly === 'undefined') {
+    cjsParse = require('internal/deps/cjs-module-lexer/lexer');
+  } else {
     const { parse, init } =
         require('internal/deps/cjs-module-lexer/dist/lexer');
     await init();
-    let exports;
-    try {
-      ({ exports } = parse('exports.a=1'));
-      if (exports.length === 1) {
-        cjsParse = parse;
-        return;
-      }
-    } catch {}
+    cjsParse = parse;
   }
-  cjsParse = require('internal/deps/cjs-module-lexer/lexer');
 }
 
 const translators = new SafeMap();