tools: update eslint

This updates eslint from v6.0.0-alpha.2 to v6.0.1 This also removes eslint-disable comments about `bigint` typeof checks. Those would otherwise have caused linting errors now that `bigint` is accepted as valid entry. PR-URL: #28173 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]>
nodejs · Jul 2, 2019 · b744bd9 · b744bd9
1 parent 3c047b3
commit b744bd9
Show file tree

Hide file tree

Showing 63 changed files with 1,963 additions and 396 deletions.
diff --git a/benchmark/process/bench-hrtime.js b/benchmark/process/bench-hrtime.js
@@ -37,6 +37,5 @@ function main({ n, type }) {
       break;
   }
 
-  // eslint-disable-next-line valid-typeof
   assert.ok(Array.isArray(noDead) || typeof noDead === 'bigint');
 }
diff --git a/lib/internal/buffer.js b/lib/internal/buffer.js
@@ -43,7 +43,6 @@ function checkBounds(buf, offset, byteLength) {
 
 function checkInt(value, min, max, buf, offset, byteLength) {
   if (value > max || value < min) {
-    // eslint-disable-next-line valid-typeof
     const n = typeof min === 'bigint' ? 'n' : '';
     let range;
     if (byteLength > 3) {

diff --git a/lib/internal/errors.js b/lib/internal/errors.js
@@ -1039,7 +1039,6 @@ E('ERR_OUT_OF_RANGE',
     let received;
     if (Number.isInteger(input) && Math.abs(input) > 2 ** 32) {
       received = addNumericalSeparator(String(input));
-    // eslint-disable-next-line valid-typeof
     } else if (typeof input === 'bigint') {
       received = String(input);
       if (input > 2n ** 32n || input < -(2n ** 32n)) {

diff --git a/lib/internal/fs/utils.js b/lib/internal/fs/utils.js
@@ -276,7 +276,7 @@ Stats.prototype._checkModeProperty = function(property) {
     property === S_IFSOCK)) {
     return false;  // Some types are not available on Windows
   }
-  if (typeof this.mode === 'bigint') {  // eslint-disable-line valid-typeof
+  if (typeof this.mode === 'bigint') {
     return (this.mode & BigInt(S_IFMT)) === BigInt(property);
   }
   return (this.mode & S_IFMT) === property;

diff --git a/lib/internal/util/inspect.js b/lib/internal/util/inspect.js
@@ -1012,7 +1012,6 @@ function groupArrayElements(ctx, output, value) {
     let order = 'padStart';
     if (value !== undefined) {
       for (let i = 0; i < output.length; i++) {
-        // eslint-disable-next-line valid-typeof
         if (typeof value[i] !== 'number' && typeof value[i] !== 'bigint') {
           order = 'padEnd';
           break;
@@ -1087,7 +1086,6 @@ function formatPrimitive(fn, value, ctx) {
   }
   if (typeof value === 'number')
     return formatNumber(fn, value);
-  // eslint-disable-next-line valid-typeof
   if (typeof value === 'bigint')
     return formatBigInt(fn, value);
   if (typeof value === 'boolean')
@@ -1550,7 +1548,6 @@ function formatWithOptions(inspectOptions, ...args) {
               const tempArg = args[++a];
               if (typeof tempArg === 'number') {
                 tempStr = formatNumber(stylizeNoColor, tempArg);
-              // eslint-disable-next-line valid-typeof
               } else if (typeof tempArg === 'bigint') {
                 tempStr = `${tempArg}n`;
               } else {
@@ -1582,7 +1579,6 @@ function formatWithOptions(inspectOptions, ...args) {
               break;
             case 100: // 'd'
               const tempNum = args[++a];
-              // eslint-disable-next-line valid-typeof
               if (typeof tempNum === 'bigint') {
                 tempStr = `${tempNum}n`;
               } else if (typeof tempNum === 'symbol') {
@@ -1606,7 +1602,6 @@ function formatWithOptions(inspectOptions, ...args) {
             }
             case 105: // 'i'
               const tempInteger = args[++a];
-              // eslint-disable-next-line valid-typeof
               if (typeof tempInteger === 'bigint') {
                 tempStr = `${tempInteger}n`;
               } else if (typeof tempInteger === 'symbol') {

diff --git a/test/common/index.js b/test/common/index.js
@@ -239,9 +239,6 @@ const pwdCommand = isWindows ?
 
 
 function platformTimeout(ms) {
-  // ESLint will not support 'bigint' in valid-typeof until it reaches stage 4.
-  // See https://github.com/eslint/eslint/pull/9636.
-  // eslint-disable-next-line valid-typeof
   const multipliers = typeof ms === 'bigint' ?
     { two: 2n, four: 4n, seven: 7n } : { two: 2, four: 4, seven: 7 };
 

diff --git a/tools/node_modules/eslint/README.md b/tools/node_modules/eslint/README.md
diff --git a/tools/node_modules/eslint/bin/eslint.js b/tools/node_modules/eslint/bin/eslint.js
diff --git a/tools/node_modules/eslint/lib/cli-engine/cascading-config-array-factory.js b/tools/node_modules/eslint/lib/cli-engine/cascading-config-array-factory.js
diff --git a/tools/node_modules/eslint/lib/cli-engine/cli-engine.js b/tools/node_modules/eslint/lib/cli-engine/cli-engine.js
diff --git a/tools/node_modules/eslint/lib/cli-engine/config-array-factory.js b/tools/node_modules/eslint/lib/cli-engine/config-array-factory.js
diff --git a/tools/node_modules/eslint/lib/cli-engine/config-array/config-array.js b/tools/node_modules/eslint/lib/cli-engine/config-array/config-array.js
diff --git a/tools/node_modules/eslint/lib/cli-engine/config-array/override-tester.js b/tools/node_modules/eslint/lib/cli-engine/config-array/override-tester.js
diff --git a/tools/node_modules/eslint/lib/cli-engine/formatters/junit.js b/tools/node_modules/eslint/lib/cli-engine/formatters/junit.js
diff --git a/tools/node_modules/eslint/lib/linter/linter.js b/tools/node_modules/eslint/lib/linter/linter.js
diff --git a/tools/node_modules/eslint/lib/linter/node-event-generator.js b/tools/node_modules/eslint/lib/linter/node-event-generator.js
-Original file line number
+Diff line change
@@ Expand Up / @@ -37,6 +37,5 @@ function main({ n, type }) { @@
           break;
       }
-      // eslint-disable-next-line valid-typeof
       assert.ok(Array.isArray(noDead) || typeof noDead === 'bigint');
     }