src: use v8::Isolate::TryGetCurrent() in DumpJavaScriptBacktrace()

It was using Isolate::GetCurrent() which DCHECK on nullptr, even though what we wanted was to return early if it is nullptr. PR-URL: #50518 Refs: #50242 Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]>
nodejs · Nov 14, 2023 · b740324 · b740324
1 parent aa8feea
commit b740324
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/src/debug_utils.cc b/src/debug_utils.cc
@@ -319,7 +319,7 @@ void DumpNativeBacktrace(FILE* fp) {
 }
 
 void DumpJavaScriptBacktrace(FILE* fp) {
-  v8::Isolate* isolate = v8::Isolate::GetCurrent();
+  v8::Isolate* isolate = v8::Isolate::TryGetCurrent();
   if (isolate == nullptr) {
     return;
   }

diff --git a/test/cctest/test_util.cc b/test/cctest/test_util.cc
@@ -299,3 +299,7 @@ TEST(UtilTest, SPrintF) {
   const std::string with_zero = std::string("a") + '\0' + 'b';
   EXPECT_EQ(SPrintF("%s", with_zero), with_zero);
 }
+
+TEST(UtilTest, DumpJavaScriptStackWithNoIsolate) {
+  node::DumpJavaScriptBacktrace(stderr);
+}