tools: disable automated libuv updates

Because the previous security release modified the bundled version of libuv, we cannot automatically update libuv without potentially undoing those changes. PR-URL: #51775 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Marco Ippolito <[email protected]>
nodejs · Feb 27, 2024 · b502be1 · b502be1
1 parent f845a16
commit b502be1
Showing 1 changed file with 12 additions and 9 deletions.
diff --git a/.github/workflows/tools.yml b/.github/workflows/tools.yml
@@ -27,7 +27,7 @@ on:
           - googletest
           - histogram
           - icu
-          - libuv
+          # - libuv
           - lint-md-dependencies
           - llhttp
           - minimatch
@@ -174,14 +174,17 @@ jobs:
               cat temp-output
               tail -n1 temp-output | grep "NEW_VERSION=" >> "$GITHUB_ENV" || true
               rm temp-output
-          - id: libuv
-            subsystem: deps
-            label: dependencies
-            run: |
-              ./tools/dep_updaters/update-libuv.sh > temp-output
-              cat temp-output
-              tail -n1 temp-output | grep "NEW_VERSION=" >> "$GITHUB_ENV" || true
-              rm temp-output
+          # libuv update was disabled because of Feb 14, 2024 security releas
+          # modified the bundled version of libuv, we cannot automatically update
+          # libuv without potentially undoing those changes.
+          # - id: libuv
+          #   subsystem: deps
+          #   label: dependencies
+          #   run: |
+          #     ./tools/dep_updaters/update-libuv.sh > temp-output
+          #     cat temp-output
+          #     tail -n1 temp-output | grep "NEW_VERSION=" >> "$GITHUB_ENV" || true
+          #     rm temp-output
           - id: lint-md-dependencies
             subsystem: tools
             label: tools