doc: mention adding Fixes to collaborator onboarding PR

Also update the example to include the Fixes url. PR-URL: #37097 Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: Zijian Liu <[email protected]> Reviewed-By: Beth Griggs <[email protected]>
nodejs · May 1, 2021 · b353549 · b353549
1 parent 55a7b0c
commit b353549
Showing 1 changed file with 6 additions and 3 deletions.
diff --git a/onboarding.md b/onboarding.md
@@ -204,11 +204,14 @@ needs to be pointed out separately during the onboarding.
 ## Exercise: Make a PR adding yourself to the README
 
 * Example:
-  <https://github.com/nodejs/node/commit/ce986de829457c39257cd205067602e765768fb0>
-  * For raw commit message: `git log ce986de829457c39257cd205067602e765768fb0
-    -1`
+  <https://github.com/nodejs/node/commit/b58fe52692659c0bc25ddbe6afa7f4ae2c7f14a8>
+  * For raw commit message:
+    `git show --format=%Bb58fe52692659c0bc25ddbe6afa7f4ae2c7f14a8`
 * Collaborators are in alphabetical order by GitHub username.
 * Optionally, include your personal pronouns.
+* Add the `Fixes: <collaborator-nomination-issue-url>` to the commit message
+  so that when the commit lands, the nomination issue url will be
+  automatically closed.
 * Label your pull request with the `doc`, `notable-change`, and `fast-track`
   labels.
 * Run CI on the PR. Use the `node-test-pull-request` CI task.