stream: fix performance regression

PR-URL: #39254 Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
nodejs · Jul 8, 2021 · a5ba28d · a5ba28d
1 parent ce00381
commit a5ba28d
Showing 1 changed file with 15 additions and 11 deletions.
diff --git a/lib/internal/streams/duplex.js b/lib/internal/streams/duplex.js
@@ -56,19 +56,23 @@ function Duplex(options) {
   Readable.call(this, options);
   Writable.call(this, options);
 
-  this.allowHalfOpen = options?.allowHalfOpen !== false;
+  if (options) {
+    this.allowHalfOpen = options.allowHalfOpen !== false;
 
-  if (options?.readable === false) {
-    this._readableState.readable = false;
-    this._readableState.ended = true;
-    this._readableState.endEmitted = true;
-  }
+    if (options.readable === false) {
+      this._readableState.readable = false;
+      this._readableState.ended = true;
+      this._readableState.endEmitted = true;
+    }
 
-  if (options?.writable === false) {
-    this._writableState.writable = false;
-    this._writableState.ending = true;
-    this._writableState.ended = true;
-    this._writableState.finished = true;
+    if (options.writable === false) {
+      this._writableState.writable = false;
+      this._writableState.ending = true;
+      this._writableState.ended = true;
+      this._writableState.finished = true;
+    }
+  } else {
+    this.allowHalfOpen = true;
   }
 }