diff --git a/src/node_errors.cc b/src/node_errors.cc index 64667ae2ebc411..7161a2d1bb7167 100644 --- a/src/node_errors.cc +++ b/src/node_errors.cc @@ -242,12 +242,11 @@ void AppendExceptionLine(Environment* env, } [[noreturn]] void Assert(const AssertionInfo& info) { - char name[1024]; - GetHumanReadableProcessName(&name); + std::string name = GetHumanReadableProcessName(); fprintf(stderr, "%s: %s:%s%s Assertion `%s' failed.\n", - name, + name.c_str(), info.file_line, info.function, *info.function ? ":" : "", diff --git a/src/node_internals.h b/src/node_internals.h index 05e9473771e43c..0ba13ceaea2ea2 100644 --- a/src/node_internals.h +++ b/src/node_internals.h @@ -100,7 +100,6 @@ void RegisterSignalHandler(int signal, std::string GetProcessTitle(const char* default_title); std::string GetHumanReadableProcessName(); -void GetHumanReadableProcessName(char (*name)[1024]); void InitializeContextRuntime(v8::Local); diff --git a/src/util.cc b/src/util.cc index 2a594d81ecab8e..29bfb5d351e35b 100644 --- a/src/util.cc +++ b/src/util.cc @@ -161,13 +161,6 @@ std::string GetHumanReadableProcessName() { return SPrintF("%s[%d]", GetProcessTitle("Node.js"), uv_os_getpid()); } -void GetHumanReadableProcessName(char (*name)[1024]) { - // Leave room after title for pid, which can be up to 20 digits for 64 bit. - char title[1000] = "Node.js"; - uv_get_process_title(title, sizeof(title)); - snprintf(*name, sizeof(*name), "%s[%d]", title, uv_os_getpid()); -} - std::vector SplitString(const std::string& in, char delim) { std::vector out; if (in.empty())