node: mark promises as handled as soon as possible

Fixes: #1912 PR-URL: #1952 Reviewed-By: Domenic Denicola <[email protected]> Reviewed-By: Petka Antonov <[email protected]>
nodejs · Jun 12, 2015 · a251657 · a251657
1 parent 03ce84d
commit a251657
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 5 deletions.
diff --git a/src/node.js b/src/node.js
@@ -515,18 +515,20 @@
       var hasBeenNotified = hasBeenNotifiedProperty.get(promise);
       if (hasBeenNotified !== undefined) {
         hasBeenNotifiedProperty.delete(promise);
-        if (hasBeenNotified === true)
-          process.emit('rejectionHandled', promise);
+        if (hasBeenNotified === true) {
+          process.nextTick(function() {
+            process.emit('rejectionHandled', promise);
+          });
+        }
+
       }
     }
 
     process._setupPromises(function(event, promise, reason) {
       if (event === promiseRejectEvent.unhandled)
         unhandledRejection(promise, reason);
       else if (event === promiseRejectEvent.handled)
-        process.nextTick(function() {
-          rejectionHandled(promise);
-        });
+        rejectionHandled(promise);
       else
         NativeModule.require('assert').fail('unexpected PromiseRejectEvent');
     });

diff --git a/test/parallel/test-promises-unhandled-rejections.js b/test/parallel/test-promises-unhandled-rejections.js
@@ -275,6 +275,21 @@ asyncTest('Attaching a promise catch in a process.nextTick is soon enough to' +
   });
 });
 
+asyncTest('While inside setImmediate, catching a rejected promise derived ' +
+          'from returning a rejected promise in a fulfillment handler ' +
+          'prevents unhandledRejection', function(done) {
+  onUnhandledFail(done);
+
+  setImmediate(function() {
+    // reproduces on first tick and inside of setImmediate
+    Promise
+      .resolve('resolve')
+      .then(function() {
+        return Promise.reject('reject');
+      }).catch(function(e) {});
+  });
+});
+
 // State adapation tests
 asyncTest('catching a promise which is asynchronously rejected (via' +
           'resolution to an asynchronously-rejected promise) prevents' +