From a1f590ebd609c72587fc9adda43c1b530e15bf11 Mon Sep 17 00:00:00 2001
From: Rongjian Zhang <pd4d10@gmail.com>
Date: Sun, 9 May 2021 02:35:53 +0800
Subject: [PATCH] test: improve coverage of lib/fs.js

PR-URL: https://github.com/nodejs/node/pull/38604
Refs: https://coverage.nodejs.org/coverage-29f1b609ba5d12d3/lib/fs.js.html#L2045
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
---
 test/parallel/test-fs-write-file.js        | 10 ++++++++
 test/parallel/test-fs-writefile-with-fd.js | 28 ++++++++++++++++++++++
 2 files changed, 38 insertions(+)

diff --git a/test/parallel/test-fs-write-file.js b/test/parallel/test-fs-write-file.js
index 3d0fd48f05f361..45cbde4a90eb88 100644
--- a/test/parallel/test-fs-write-file.js
+++ b/test/parallel/test-fs-write-file.js
@@ -95,3 +95,13 @@ fs.open(filename4, 'w+', common.mustSucceed((fd) => {
 
   process.nextTick(() => controller.abort());
 }
+
+{
+  // Test read-only mode
+  const filename = join(tmpdir.path, 'test6.txt');
+  fs.writeFileSync(filename, '');
+
+  // TODO: Correct the error type
+  const expectedError = common.isWindows ? /EPERM/ : /EBADF/;
+  fs.writeFile(filename, s, { flag: 'r' }, common.expectsError(expectedError));
+}
diff --git a/test/parallel/test-fs-writefile-with-fd.js b/test/parallel/test-fs-writefile-with-fd.js
index 1effc519627b50..2af5b39adbc14a 100644
--- a/test/parallel/test-fs-writefile-with-fd.js
+++ b/test/parallel/test-fs-writefile-with-fd.js
@@ -55,3 +55,31 @@ tmpdir.refresh();
     }));
   }));
 }
+
+
+// Test read-only file descriptor
+{
+  // TODO(pd4d10): https://github.com/nodejs/node/issues/38607
+  const expectedError = common.isWindows ? /EPERM/ : /EBADF/;
+
+  const file = join(tmpdir.path, 'test.txt');
+
+  fs.open(file, 'r', common.mustSucceed((fd) => {
+    fs.writeFile(fd, 'World', common.expectsError(expectedError));
+  }));
+}
+
+// Test with an AbortSignal
+{
+  const controller = new AbortController();
+  const signal = controller.signal;
+  const file = join(tmpdir.path, 'test.txt');
+
+  fs.open(file, 'w', common.mustSucceed((fd) => {
+    fs.writeFile(fd, 'World', { signal }, common.expectsError({
+      name: 'AbortError'
+    }));
+  }));
+
+  controller.abort();
+}