-
Notifications
You must be signed in to change notification settings - Fork 30k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
repl: make 'Unexpected token' errors recoverable
Fix the regexp used to detect 'Unexpected token' errors so that they can be considered as recoverable. This fixes the following use case: > var foo = 'bar \ ... baz'; undefined > foo 'bar baz' > Fixes: nodejs/node-v0.x-archive#8874 PR-URL: nodejs/node-v0.x-archive#8875 PR-URL: #2052 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
- Loading branch information
Showing
2 changed files
with
34 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,33 @@ | ||
'use strict'; | ||
/* | ||
* This is a regression test for https://github.com/joyent/node/issues/8874. | ||
*/ | ||
var common = require('../common'); | ||
var assert = require('assert'); | ||
|
||
var spawn = require('child_process').spawn; | ||
// use -i to force node into interactive mode, despite stdout not being a TTY | ||
var args = [ '-i' ]; | ||
var child = spawn(process.execPath, args); | ||
|
||
var input = 'var foo = "bar\\\nbaz"'; | ||
// Match '...' as well since it marks a multi-line statement | ||
var expectOut = /^> ... undefined\n/; | ||
|
||
child.stderr.setEncoding('utf8'); | ||
child.stderr.on('data', function(c) { | ||
throw new Error('child.stderr be silent'); | ||
}); | ||
|
||
child.stdout.setEncoding('utf8'); | ||
var out = ''; | ||
child.stdout.on('data', function(c) { | ||
out += c; | ||
}); | ||
|
||
child.stdout.on('end', function() { | ||
assert(expectOut.test(out)); | ||
console.log('ok'); | ||
}); | ||
|
||
child.stdin.end(input); |