zlib: throw TypeError if callback is missing

Get a proper stack trace when no callback is passed. PR-URL: #24929 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Denys Otrishko <[email protected]> Reviewed-By: Weijia Wang <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
nodejs · Dec 12, 2018 · 9a26546 · 9a26546
1 parent a0bdeb5
commit 9a26546
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 0 deletions.
diff --git a/lib/zlib.js b/lib/zlib.js
@@ -73,6 +73,8 @@ for (var ck = 0; ck < ckeys.length; ck++) {
 }
 
 function zlibBuffer(engine, buffer, callback) {
+  if (typeof callback !== 'function')
+    throw new ERR_INVALID_ARG_TYPE('callback', 'function', callback);
   // Streams do not support non-Buffer ArrayBufferViews yet. Convert it to a
   // Buffer without copying.
   if (isArrayBufferView(buffer) &&

diff --git a/test/parallel/test-zlib-convenience-methods.js b/test/parallel/test-zlib-convenience-methods.js
@@ -119,3 +119,13 @@ for (const [type, expect] of [
     }
   }
 }
+
+common.expectsError(
+  () => zlib.gzip('abc'),
+  {
+    code: 'ERR_INVALID_ARG_TYPE',
+    type: TypeError,
+    message: 'The "callback" argument must be of type function. ' +
+             'Received type undefined'
+  }
+);