src: introduce DCHECK macro

This commit adds a DCHECK macro for consistency with the other DCHECK_* macros. PR-URL: #25207 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
nodejs · Jan 1, 2019 · 99a5af6 · 99a5af6
1 parent e2a01ca
commit 99a5af6
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 13 deletions.
diff --git a/src/aliased_buffer.h b/src/aliased_buffer.h
@@ -231,9 +231,7 @@ class AliasedBuffer {
   void reserve(size_t new_capacity) {
     DCHECK_GE(new_capacity, count_);
     DCHECK_EQ(byte_offset_, 0);
-#if defined(DEBUG) && DEBUG
-    CHECK(free_buffer_);
-#endif
+    DCHECK(free_buffer_);
     const v8::HandleScope handle_scope(isolate_);
 
     const size_t old_size_in_bytes = sizeof(NativeT) * count_;

diff --git a/src/base_object-inl.h b/src/base_object-inl.h
@@ -113,9 +113,7 @@ void BaseObject::ClearWeak() {
 v8::Local<v8::FunctionTemplate>
 BaseObject::MakeLazilyInitializedJSTemplate(Environment* env) {
   auto constructor = [](const v8::FunctionCallbackInfo<v8::Value>& args) {
-#ifdef DEBUG
-    CHECK(args.IsConstructCall());
-#endif
+    DCHECK(args.IsConstructCall());
     DCHECK_GT(args.This()->InternalFieldCount(), 0);
     args.This()->SetAlignedPointerInInternalField(0, nullptr);
   };

diff --git a/src/inspector/node_string.h b/src/inspector/node_string.h
@@ -73,8 +73,4 @@ extern size_t kNotFound;
 }  // namespace inspector
 }  // namespace node
 
-#ifndef DCHECK
-  #define DCHECK CHECK
-  #define DCHECK_LT CHECK_LT
-#endif  // DCHECK
 #endif  // SRC_INSPECTOR_NODE_STRING_H_
diff --git a/src/string_decoder.cc b/src/string_decoder.cc
@@ -44,9 +44,7 @@ MaybeLocal<String> MakeString(Isolate* isolate,
     isolate->ThrowException(error);
   }
 
-#ifdef DEBUG
-  CHECK(ret.IsEmpty() || ret.ToLocalChecked()->IsString());
-#endif
+  DCHECK(ret.IsEmpty() || ret.ToLocalChecked()->IsString());
   return ret.FromMaybe(Local<Value>()).As<String>();
 }
 

diff --git a/src/util.h b/src/util.h
@@ -130,6 +130,7 @@ void DumpBacktrace(FILE* fp);
 #define CHECK_IMPLIES(a, b) CHECK(!(a) || (b))
 
 #ifdef DEBUG
+  #define DCHECK(expr) CHECK(expr)
   #define DCHECK_EQ(a, b) CHECK((a) == (b))
   #define DCHECK_GE(a, b) CHECK((a) >= (b))
   #define DCHECK_GT(a, b) CHECK((a) > (b))
@@ -140,6 +141,7 @@ void DumpBacktrace(FILE* fp);
   #define DCHECK_NOT_NULL(val) CHECK((val) != nullptr)
   #define DCHECK_IMPLIES(a, b) CHECK(!(a) || (b))
 #else
+  #define DCHECK(expr)
   #define DCHECK_EQ(a, b)
   #define DCHECK_GE(a, b)
   #define DCHECK_GT(a, b)