From 925b29f95958cc66808a0e4bf26b341b79c6a285 Mon Sep 17 00:00:00 2001 From: Ben Noordhuis Date: Wed, 30 Sep 2015 02:13:31 +0200 Subject: [PATCH] deps: backport f782159 from v8's upstream Backport f78215962bf5de9d47c022e7baa3952d0bf6d17f from V8's upstream to speed up promise introspection. Original commit message: Remove obsolete try/catch from ObjectIsPromise(). Review URL: https://codereview.chromium.org/1367123003 Cr-Commit-Position: refs/heads/master@{#30966} PR-URL: https://github.com/nodejs/node/pull/3130 Reviewed-By: Evan Lucas Reviewed-By: Sakthipriyan Vairamani --- deps/v8/src/mirror-debugger.js | 11 ++--------- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/deps/v8/src/mirror-debugger.js b/deps/v8/src/mirror-debugger.js index dbdc68e68f88e2..d37776af386857 100644 --- a/deps/v8/src/mirror-debugger.js +++ b/deps/v8/src/mirror-debugger.js @@ -19,16 +19,9 @@ function ToggleMirrorCache(value) { } -// Wrapper to check whether an object is a Promise. The call may not work -// if promises are not enabled. -// TODO(yangguo): remove try-catch once promises are enabled by default. function ObjectIsPromise(value) { - try { - return IS_SPEC_OBJECT(value) && - !IS_UNDEFINED(%DebugGetProperty(value, builtins.$promiseStatus)); - } catch (e) { - return false; - } + return IS_SPEC_OBJECT(value) && + !IS_UNDEFINED(%DebugGetProperty(value, builtins.$promiseStatus)); }